From 6c4a2d91ec82b15bc21825276d94b0233448870b Mon Sep 17 00:00:00 2001 From: snomiao Date: Mon, 6 Oct 2025 21:41:29 +0000 Subject: [PATCH] Fix CI: Remove explicit repository parameter from checkout steps This fixes non-reproducible test results caused by explicit repository parameter forcing checkout to default branch instead of PR context. - Remove repository: 'Comfy-Org/ComfyUI_frontend' from setup job - Remove repository: 'Comfy-Org/ComfyUI_frontend' from merge-reports job - Update setup-frontend action to use actions/checkout@v5 When checking out the same repository running the workflow, specifying the repository parameter causes actions/checkout to default to the repository's default branch (main) instead of using the PR context. This was causing tests to run PR code against main branch snapshots, leading to inconsistent and non-reproducible test failures. --- .github/actions/setup-frontend/action.yml | 5 ++--- .github/workflows/tests-ci.yaml | 4 +--- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/.github/actions/setup-frontend/action.yml b/.github/actions/setup-frontend/action.yml index 3ebc12eb3f..125eaa92fc 100644 --- a/.github/actions/setup-frontend/action.yml +++ b/.github/actions/setup-frontend/action.yml @@ -9,15 +9,14 @@ runs: using: 'composite' steps: - name: Checkout ComfyUI - uses: actions/checkout@v4 + uses: actions/checkout@v5 with: repository: 'comfyanonymous/ComfyUI' path: 'ComfyUI' - name: Checkout ComfyUI_frontend - uses: actions/checkout@v4 + uses: actions/checkout@v5 with: - repository: 'Comfy-Org/ComfyUI_frontend' path: 'ComfyUI_frontend' - name: Copy ComfyUI_devtools from frontend repo diff --git a/.github/workflows/tests-ci.yaml b/.github/workflows/tests-ci.yaml index 94d0f0b2d6..d402fe4685 100644 --- a/.github/workflows/tests-ci.yaml +++ b/.github/workflows/tests-ci.yaml @@ -23,7 +23,6 @@ jobs: - name: Checkout ComfyUI_frontend uses: actions/checkout@v5 with: - repository: 'Comfy-Org/ComfyUI_frontend' path: 'ComfyUI_frontend' - name: Copy ComfyUI_devtools from frontend repo @@ -88,7 +87,7 @@ jobs: - name: Wait for cache propagation run: sleep 10 - - name: Restore cached setup + - name: Restore cached setup uses: actions/cache/restore@5a3ec84eff668545956fd18022155c47e93e2684 with: fail-on-cache-miss: true @@ -217,7 +216,6 @@ jobs: - name: Checkout ComfyUI_frontend uses: actions/checkout@v5 with: - repository: 'Comfy-Org/ComfyUI_frontend' path: 'ComfyUI_frontend' - name: Install pnpm