Add tests.

Author: robinjhuang

comfy_cli/command/custom_nodes/command.py

@@ -26,7 +26,6 @@
     extract_node_configuration,
     initialize_project_config,
 )
-from comfy_cli.validators import MutuallyExclusiveValidator
 from comfy_cli.workspace_manager import WorkspaceManager
 
 console = Console()
@@ -36,9 +35,6 @@
 workspace_manager = WorkspaceManager()
 registry_api = RegistryAPI()
 
-# Global validator for mutually exclusive dependency options
-g_deps_exclusivity = MutuallyExclusiveValidator()
-
 
 def validate_comfyui_manager(_env_checker):
     manager_path = _env_checker.get_comfyui_manager_path()
@@ -402,7 +398,6 @@ def install(
             "--fast-deps",
             show_default=False,
             help="Use new fast dependency installer",
-            callback=g_deps_exclusivity.validate,
         ),
     ] = False,
     no_deps: Annotated[
@@ -411,7 +406,6 @@ def install(
             "--no-deps",
             show_default=False,
             help="Skip dependency installation",
-            callback=g_deps_exclusivity.validate,
         ),
     ] = False,
     exit_on_fail: Annotated[
@@ -431,6 +425,10 @@ def install(
         typer.echo(f"Invalid command: {mode}. `install all` is not allowed", err=True)
         raise typer.Exit(code=1)
 
+    if fast_deps and no_deps:
+        typer.echo("Cannot use --fast-deps and --no-deps together", err=True)
+        raise typer.Exit(code=1)
+
     validate_mode(mode)
 
     if exit_on_fail:

tests/comfy_cli/command/nodes/test_install.py

@@ -0,0 +1,88 @@
+from unittest.mock import patch
+
+from typer.testing import CliRunner
+
+from comfy_cli.command.custom_nodes.command import app
+
+runner = CliRunner()
+
+
+def test_install_no_deps_option_exists():
+    """Test that the --no-deps option appears in the help."""
+    result = runner.invoke(app, ["install", "--help"])
+    assert result.exit_code == 0
+    assert "--no-deps" in result.stdout
+    assert "Skip dependency installation" in result.stdout
+
+
+def test_install_fast_deps_and_no_deps_mutually_exclusive():
+    """Test that --fast-deps and --no-deps cannot be used together."""
+    result = runner.invoke(app, ["install", "test-node", "--fast-deps", "--no-deps"])
+    assert result.exit_code != 0
+    assert "Cannot use --fast-deps and --no-deps together" in result.stdout
+
+
+def test_install_no_deps_alone_works():
+    """Test that --no-deps can be used by itself."""
+    with patch("comfy_cli.command.custom_nodes.command.execute_cm_cli") as mock_execute:
+        result = runner.invoke(app, ["install", "test-node", "--no-deps"])
+
+        # Should not exit with error due to mutual exclusivity
+        if result.exit_code != 0:
+            # Only acceptable if it fails due to missing ComfyUI setup, not mutual exclusivity
+            assert "Cannot use --fast-deps and --no-deps together" not in result.stdout
+
+        # Verify execute_cm_cli was called with no_deps=True
+        if mock_execute.called:
+            _, kwargs = mock_execute.call_args
+            assert kwargs.get("no_deps") is True
+            assert kwargs.get("fast_deps") is False
+
+
+def test_install_fast_deps_alone_works():
+    """Test that --fast-deps can be used by itself."""
+    with patch("comfy_cli.command.custom_nodes.command.execute_cm_cli") as mock_execute:
+        result = runner.invoke(app, ["install", "test-node", "--fast-deps"])
+
+        # Should not exit with error due to mutual exclusivity
+        if result.exit_code != 0:
+            # Only acceptable if it fails due to missing ComfyUI setup, not mutual exclusivity
+            assert "Cannot use --fast-deps and --no-deps together" not in result.stdout
+
+        # Verify execute_cm_cli was called with fast_deps=True
+        if mock_execute.called:
+            _, kwargs = mock_execute.call_args
+            assert kwargs.get("fast_deps") is True
+            assert kwargs.get("no_deps") is False
+
+
+def test_install_neither_deps_option():
+    """Test that install works without any deps options."""
+    with patch("comfy_cli.command.custom_nodes.command.execute_cm_cli") as mock_execute:
+        result = runner.invoke(app, ["install", "test-node"])
+
+        # Should not exit with error due to mutual exclusivity
+        if result.exit_code != 0:
+            # Only acceptable if it fails due to missing ComfyUI setup, not mutual exclusivity
+            assert "Cannot use --fast-deps and --no-deps together" not in result.stdout
+
+        # Verify execute_cm_cli was called with both flags False
+        if mock_execute.called:
+            _, kwargs = mock_execute.call_args
+            assert kwargs.get("fast_deps") is False
+            assert kwargs.get("no_deps") is False
+
+
+def test_multiple_commands_work_independently():
+    """Test that multiple commands work independently without state interference."""
+    # First command with --no-deps should work
+    with patch("comfy_cli.command.custom_nodes.command.execute_cm_cli"):
+        result1 = runner.invoke(app, ["install", "test-node", "--no-deps"])
+        if result1.exit_code != 0:
+            assert "Cannot use --fast-deps and --no-deps together" not in result1.stdout
+
+    # Second command with --fast-deps should also work
+    with patch("comfy_cli.command.custom_nodes.command.execute_cm_cli"):
+        result2 = runner.invoke(app, ["install", "test-node2", "--fast-deps"])
+        if result2.exit_code != 0:
+            assert "Cannot use --fast-deps and --no-deps together" not in result2.stdout