Skip to content

Commit b2ba7d0

Browse files
authored
Continue on update node cache error when installing ComfyUI-Manager (#208)
* Add. * Catch errro.. * Update ruff. * Revert.
1 parent 2ff6f6e commit b2ba7d0

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

comfy_cli/command/custom_nodes/command.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -491,13 +491,7 @@ def update_node_id_cache():
491491

492492
new_env = os.environ.copy()
493493
new_env["COMFYUI_PATH"] = workspace_path
494-
res = subprocess.run(cmd, env=new_env, check=True)
495-
if res.returncode != 0:
496-
typer.echo(
497-
"Failed to update node id cache.",
498-
err=True,
499-
)
500-
raise typer.Exit(code=1)
494+
subprocess.run(cmd, env=new_env, check=True)
501495

502496

503497
# `update, disable, enable, fix` allows `all` param

comfy_cli/command/install.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,10 @@ def execute(
251251
depComp.install_deps()
252252

253253
if not skip_manager:
254-
update_node_id_cache()
254+
try:
255+
update_node_id_cache()
256+
except subprocess.CalledProcessError as e:
257+
rprint(f"Failed to update node id cache: {e}")
255258

256259
os.chdir(repo_dir)
257260

0 commit comments

Comments
 (0)