Improve error messages for Publishing nodes. (#72)

Author: robinjhuang

DEV_README.md

@@ -10,11 +10,15 @@ This guide provides an overview of how to develop in this repository.
 
 `pip install -e .`
 
-3. Test script running
+3. Set ENVIRONMENT variable to DEV.
+
+`export ENVIRONMENT=dev`
+
+4. Test script running
 
 `comfy --help`
 
-4. Use pre commit hook
+5. Use pre commit hook
 
 `pre-commit install`
 

comfy_cli/command/custom_nodes/command.py

@@ -668,17 +668,20 @@ def publish(
 
     # Call API to fetch node version with the token in the body
     typer.echo("Publishing node version...")
-    response = registry_api.publish_node_version(config, token)
-
-    # Zip up all files in the current directory, respecting .gitignore files.
-    signed_url = response.signedUrl
-    zip_filename = "node.tar.gz"
-    typer.echo("Creating zip file...")
-    zip_files(zip_filename)
-
-    # Upload the zip file to the signed URL
-    typer.echo("Uploading zip file...")
-    upload_file_to_signed_url(signed_url, zip_filename)
+    try:
+        response = registry_api.publish_node_version(config, token)
+        # Zip up all files in the current directory, respecting .gitignore files.
+        signed_url = response.signedUrl
+        zip_filename = "node.tar.gz"
+        typer.echo("Creating zip file...")
+        zip_files(zip_filename)
+
+        # Upload the zip file to the signed URL
+        typer.echo("Uploading zip file...")
+        upload_file_to_signed_url(signed_url, zip_filename)
+    except Exception as e:
+        ui.display_error_message({str(e)})
+        return
 
 
 @app.command("init", help="Init scaffolding for custom node")

comfy_cli/registry/api.py

@@ -1,8 +1,11 @@
 import logging
 import os
-
+from rich.console import Console
 import requests
 import json
+from typing import Optional
+
+from comfy_cli.registry.types import PyProjectConfig, PublishNodeVersionResponse
 
 # Reduced global imports from comfy_cli.registry
 from comfy_cli.registry.types import NodeVersion, Node
@@ -18,7 +21,7 @@ def determine_base_url(self):
         else:
             return "https://api.comfy.org"
 
-    def publish_node_version(self, node_config, token):
+    def publish_node_version(self, node_config, token) -> PublishNodeVersionResponse:
         """
         Publishes a new version of a node.
 
@@ -30,7 +33,16 @@ def publish_node_version(self, node_config, token):
         PublishNodeVersionResponse: The response object from the API server.
         """
         # Local import to prevent circular dependency
-        from comfy_cli.registry.types import PyProjectConfig, PublishNodeVersionResponse
+
+        if not node_config.tool_comfy.publisher_id:
+            raise Exception(
+                "Publisher ID is required in pyproject.toml to publish a node version"
+            )
+
+        if not node_config.project.name:
+            raise Exception(
+                "Project name is required in pyproject.toml to publish a node version"
+            )
 
         url = f"{self.base_url}/publishers/{node_config.tool_comfy.publisher_id}/nodes/{node_config.project.name}/versions"
         headers = {"Content-Type": "application/json"}