--pr cannot be used with --version or --commit

[marchuk-vlad]

Describe the bug
The bug is here.
According to operator precedence, the current condition means
if (pr and version not in {None, "nightly"}) or commit,
but it should be
if pr and (version not in {None, "nightly"} or commit).
As a result, specifying --commit causes a crash.

To Reproduce
comfy --skip-prompt --workspace ./confy2/ install --version nightly --commit 93292bc450dd291925c45adea00ebedb8a3209ef --manager-commit 3.31.12 --cpu
--pr cannot be used with --version or --commit

Expected behavior
Guess :)

Nice to have

• Terminal output
• Screenshots

Additional context
I think no needs.

[dosubot]

Hi @marchuk-vlad! I'm Dosu and I’m helping the comfy-cli team.

You're right about the operator precedence bug in the conditional statement in cmdline.py. The current logic:

if pr and version not in {None, "nightly"} or commit:

is evaluated as if (pr and version not in {None, "nightly"}) or commit, which means the error message will trigger if --commit is specified, regardless of the values of --pr or --version. This leads to a crash or incorrect error message when using --commit with other flags. The correct logic should be:

if pr and (version not in {None, "nightly"} or commit):

This ensures --pr cannot be used with either a specific --version or --commit, as intended. Adding parentheses resolves the precedence issue and prevents the crash, making the CLI argument handling work as expected. You can see the code and the impact of this bug here.

To reply, just mention @dosu.

---

^{How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other}