diff --git a/.github/workflows/run-on-gpu.yml b/.github/workflows/run-on-gpu.yml old mode 100644 new mode 100755 index 069296a2..1e4370a4 --- a/.github/workflows/run-on-gpu.yml +++ b/.github/workflows/run-on-gpu.yml @@ -61,7 +61,7 @@ jobs: env: PYTHONPATH: ${{ github.workspace }} TEST_E2E: true - TEST_E2E_COMFY_INSTALL_FLAGS: --nvidia --cuda-version 11.8 + TEST_E2E_COMFY_INSTALL_FLAGS: --nvidia --cuda-version 12.4 TEST_E2E_COMFY_LAUNCH_FLAGS_EXTRA: "" run: | pytest tests/e2e diff --git a/.github/workflows/test-windows.yml b/.github/workflows/test-windows.yml old mode 100644 new mode 100755 index 66f04881..63fe2593 --- a/.github/workflows/test-windows.yml +++ b/.github/workflows/test-windows.yml @@ -27,7 +27,7 @@ jobs: python -m pip install --upgrade pip pip install pytest pip install -e . - comfy --skip-prompt --workspace ./ComfyUI install --fast-deps --nvidia --cuda-version 12.1 --skip-manager + comfy --skip-prompt --workspace ./ComfyUI install --fast-deps --nvidia --cuda-version 12.4 --skip-manager comfy --workspace ./ComfyUI standalone --platform windows --proc x86_64 ls comfy standalone --rehydrate --platform windows --proc x86_64 diff --git a/comfy_cli/cmdline.py b/comfy_cli/cmdline.py index 37dbd61b..b74caa68 100644 --- a/comfy_cli/cmdline.py +++ b/comfy_cli/cmdline.py @@ -198,7 +198,7 @@ def install( callback=g_gpu_exclusivity.validate, ), ] = None, - cuda_version: Annotated[CUDAVersion, typer.Option(show_default=True)] = CUDAVersion.v12_1, + cuda_version: Annotated[CUDAVersion, typer.Option(show_default=True)] = CUDAVersion.v12_4, amd: Annotated[ Optional[bool], typer.Option( diff --git a/comfy_cli/command/install.py b/comfy_cli/command/install.py old mode 100644 new mode 100755 index 9586dd2e..7a500675 --- a/comfy_cli/command/install.py +++ b/comfy_cli/command/install.py @@ -68,7 +68,12 @@ def pip_install_comfyui_dependencies( "torchvision", "torchaudio", ] - if plat == constants.OS.WINDOWS and cuda_version == constants.CUDAVersion.v12_1: + if plat == constants.OS.WINDOWS and cuda_version == constants.CUDAVersion.v12_4: + base_command += [ + "--extra-index-url", + "https://download.pytorch.org/whl/cu124", + ] + elif plat == constants.OS.WINDOWS and cuda_version == constants.CUDAVersion.v12_1: base_command += [ "--extra-index-url", "https://download.pytorch.org/whl/cu121", @@ -159,7 +164,7 @@ def execute( commit: Optional[str] = None, manager_commit: Optional[str] = None, gpu: constants.GPU_OPTION = None, - cuda_version: constants.CUDAVersion = constants.CUDAVersion.v12_1, + cuda_version: constants.CUDAVersion = constants.CUDAVersion.v12_4, plat: constants.OS = None, skip_torch_or_directml: bool = False, skip_requirement: bool = False, diff --git a/comfy_cli/constants.py b/comfy_cli/constants.py index 6d59fc6c..50b7a533 100644 --- a/comfy_cli/constants.py +++ b/comfy_cli/constants.py @@ -60,6 +60,7 @@ class PROC(str, Enum): class CUDAVersion(str, Enum): + v12_4 = "12.4" v12_1 = "12.1" v11_8 = "11.8"