From 4544e425c7002bb1ab28337cfdf80ee977a13dce Mon Sep 17 00:00:00 2001 From: snomiao Date: Thu, 5 Jun 2025 05:23:09 +0000 Subject: [PATCH 1/6] feat(config_parser.py): add documentation and bug tracker URLs to project config for better resource accessibility --- comfy_cli/registry/config_parser.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/comfy_cli/registry/config_parser.py b/comfy_cli/registry/config_parser.py index 1a243943..1ccc7b0f 100644 --- a/comfy_cli/registry/config_parser.py +++ b/comfy_cli/registry/config_parser.py @@ -110,6 +110,9 @@ def initialize_project_config(): project = document.get("project", tomlkit.table()) urls = project.get("urls", tomlkit.table()) urls["Repository"] = git_remote_url + urls["Documentation"] = git_remote_url + "/wiki" + urls["Bug Tracker"] = git_remote_url + "/issues" + project["urls"] = urls project["name"] = sanitize_node_name(repo_name) project["description"] = "" From 9f4b9c66a0a8c6716dbd91742c1e138de7a5b465 Mon Sep 17 00:00:00 2001 From: snomiao Date: Thu, 5 Jun 2025 05:24:00 +0000 Subject: [PATCH 2/6] feat(config_parser.py): add requires-comfyui key to project config to specify dependency version requirement --- comfy_cli/registry/config_parser.py | 1 + 1 file changed, 1 insertion(+) diff --git a/comfy_cli/registry/config_parser.py b/comfy_cli/registry/config_parser.py index 1ccc7b0f..9fe63a16 100644 --- a/comfy_cli/registry/config_parser.py +++ b/comfy_cli/registry/config_parser.py @@ -126,6 +126,7 @@ def initialize_project_config(): tool = document.get("tool", tomlkit.table()) comfy = tool.get("comfy", tomlkit.table()) comfy["DisplayName"] = repo_name + comfy["requires-comfyui"] = ">=1.0.0" tool["comfy"] = comfy document["tool"] = tool From 1583a5812d4a4f4fc61366805e77162563d2441e Mon Sep 17 00:00:00 2001 From: snomiao Date: Thu, 5 Jun 2025 05:28:51 +0000 Subject: [PATCH 3/6] docs(config_parser.py): add comment to clarify the purpose of the requires-comfyui version constraint for better understanding --- comfy_cli/registry/config_parser.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/comfy_cli/registry/config_parser.py b/comfy_cli/registry/config_parser.py index 9fe63a16..649b86fb 100644 --- a/comfy_cli/registry/config_parser.py +++ b/comfy_cli/registry/config_parser.py @@ -126,7 +126,8 @@ def initialize_project_config(): tool = document.get("tool", tomlkit.table()) comfy = tool.get("comfy", tomlkit.table()) comfy["DisplayName"] = repo_name - comfy["requires-comfyui"] = ">=1.0.0" + comfy["requires-comfyui"] = ">=1.0.0" # ComfyUI version compatibility + tool["comfy"] = comfy document["tool"] = tool From d8ef3a7b7e02e00be451e36c6b82b9693fa04c07 Mon Sep 17 00:00:00 2001 From: snomiao Date: Thu, 5 Jun 2025 08:57:14 +0000 Subject: [PATCH 4/6] feat(config_parser.py): add project classifiers to enhance package metadata and compatibility information --- comfy_cli/registry/config_parser.py | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/comfy_cli/registry/config_parser.py b/comfy_cli/registry/config_parser.py index 649b86fb..fdbb1d0f 100644 --- a/comfy_cli/registry/config_parser.py +++ b/comfy_cli/registry/config_parser.py @@ -122,6 +122,33 @@ def initialize_project_config(): license_table = tomlkit.inline_table() license_table["file"] = "LICENSE" project["license"] = license_table + + # Classifiers + # [project] + # classifiers = [ + # # For OS-independent nodes (works on all operating systems) + # "Operating System :: OS Independent", + + # # OR for OS-specific nodes, specify the supported systems: + # "Operating System :: Microsoft :: Windows", # Windows specific + # "Operating System :: POSIX :: Linux", # Linux specific + # "Operating System :: MacOS", # macOS specific + + # # GPU Accelerator support + # "Environment :: GPU :: NVIDIA CUDA", # NVIDIA CUDA support + # "Environment :: GPU :: AMD ROCm", # AMD ROCm support + # "Environment :: GPU :: Intel Arc", # Intel Arc support + # "Environment :: NPU :: Huawei Ascend", # Huawei Ascend support + # "Environment :: GPU :: Apple Metal", # Apple Metal support + # ] + project["classifiers"] = tomlkit.array( + "Operating System :: OS Independent", + "Environment :: GPU :: NVIDIA CUDA", + "Environment :: GPU :: AMD ROCm", + "Environment :: GPU :: Intel Arc", + "Environment :: NPU :: Huawei Ascend", + "Environment :: GPU :: Apple Metal", + ) tool = document.get("tool", tomlkit.table()) comfy = tool.get("comfy", tomlkit.table()) From 15e85dd0068866142d8443457c6896204a2ccd7d Mon Sep 17 00:00:00 2001 From: snomiao Date: Mon, 9 Jun 2025 13:09:11 +0900 Subject: [PATCH 5/6] Update comfy_cli/registry/config_parser.py Co-authored-by: Robin Huang --- comfy_cli/registry/config_parser.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/comfy_cli/registry/config_parser.py b/comfy_cli/registry/config_parser.py index fdbb1d0f..de2d863f 100644 --- a/comfy_cli/registry/config_parser.py +++ b/comfy_cli/registry/config_parser.py @@ -134,7 +134,7 @@ def initialize_project_config(): # "Operating System :: POSIX :: Linux", # Linux specific # "Operating System :: MacOS", # macOS specific - # # GPU Accelerator support + # # GPU Accelerator support. Pick the ones that are supported by your extension. # "Environment :: GPU :: NVIDIA CUDA", # NVIDIA CUDA support # "Environment :: GPU :: AMD ROCm", # AMD ROCm support # "Environment :: GPU :: Intel Arc", # Intel Arc support From 717164d7d1f1bf3cfa3abe14ae7d3299f0354a10 Mon Sep 17 00:00:00 2001 From: snomiao Date: Wed, 11 Jun 2025 06:42:49 +0000 Subject: [PATCH 6/6] chore(config_parser.py): clean up commented-out classifiers and add a comment for requires-comfyui for better readability and maintainability --- comfy_cli/registry/config_parser.py | 50 +++++++++++++---------------- 1 file changed, 23 insertions(+), 27 deletions(-) diff --git a/comfy_cli/registry/config_parser.py b/comfy_cli/registry/config_parser.py index fdbb1d0f..56737d97 100644 --- a/comfy_cli/registry/config_parser.py +++ b/comfy_cli/registry/config_parser.py @@ -122,38 +122,34 @@ def initialize_project_config(): license_table = tomlkit.inline_table() license_table["file"] = "LICENSE" project["license"] = license_table - + # Classifiers - # [project] - # classifiers = [ - # # For OS-independent nodes (works on all operating systems) - # "Operating System :: OS Independent", - - # # OR for OS-specific nodes, specify the supported systems: - # "Operating System :: Microsoft :: Windows", # Windows specific - # "Operating System :: POSIX :: Linux", # Linux specific - # "Operating System :: MacOS", # macOS specific - - # # GPU Accelerator support - # "Environment :: GPU :: NVIDIA CUDA", # NVIDIA CUDA support - # "Environment :: GPU :: AMD ROCm", # AMD ROCm support - # "Environment :: GPU :: Intel Arc", # Intel Arc support - # "Environment :: NPU :: Huawei Ascend", # Huawei Ascend support - # "Environment :: GPU :: Apple Metal", # Apple Metal support - # ] - project["classifiers"] = tomlkit.array( - "Operating System :: OS Independent", - "Environment :: GPU :: NVIDIA CUDA", - "Environment :: GPU :: AMD ROCm", - "Environment :: GPU :: Intel Arc", - "Environment :: NPU :: Huawei Ascend", - "Environment :: GPU :: Apple Metal", - ) + + project["classifiers"] = tomlkit.array() + project["classifiers"].comment(""" +# classifiers = [ +# # For OS-independent nodes (works on all operating systems) +# "Operating System :: OS Independent", +# +# # OR for OS-specific nodes, specify the supported systems: +# "Operating System :: Microsoft :: Windows", # Windows specific +# "Operating System :: POSIX :: Linux", # Linux specific +# "Operating System :: MacOS", # macOS specific +# +# # GPU Accelerator support +# "Environment :: GPU :: NVIDIA CUDA", # NVIDIA CUDA support +# "Environment :: GPU :: AMD ROCm", # AMD ROCm support +# "Environment :: GPU :: Intel Arc", # Intel Arc support +# "Environment :: NPU :: Huawei Ascend", # Huawei Ascend support +# "Environment :: GPU :: Apple Metal", # Apple Metal support +# ] +""") tool = document.get("tool", tomlkit.table()) comfy = tool.get("comfy", tomlkit.table()) comfy["DisplayName"] = repo_name - comfy["requires-comfyui"] = ">=1.0.0" # ComfyUI version compatibility + document.add(tomlkit.comment('"requires-comfyui" = ">=1.0.0" # ComfyUI version compatibility')) + # comfy["requires-comfyui"] = ">=1.0.0" # ComfyUI version compatibility tool["comfy"] = comfy document["tool"] = tool