React template does not initialize

[mcmalt]

When run by comfy node scaffold and React is selected as a frontend type, the resulting directory does not contain anything from the react extension template.

I'm not particularly familiar with cookiecutter, but I believe I have narrowed down the issue.

cookiecutter-comfy-extension/hooks/pre_gen_project.py

Line 64 in db6cfd9

if template_source.startswith("gh:") and frontend_type == "react":

When run, template_source => https://github.com/Comfy-Org/cookiecutter-comfy-extension.git, which does not start with gh, so submodules are never initialized

Removing the condition template_source.startswith("gh:") correctly initializes the submodule.

I have not attempted running cookiecutter directly on the template, so perhaps the behavior is different between comfy node scaffold and cookiecutter gh:comfy-org/cookiecutter-comfy-extension

Edit 2: after looking at the cli source, cookiecutter is run on https://github.com/Comfy-Org/cookiecutter-comfy-extension.git not gh:comfy-org/cookiecutter-comfy-extension, so this may be the cause of the unexpected behavior

[zcfrank1st]

+1

[christian-byrne]

@jtydhr88 Any idea why this happens?

[jtydhr88]

I will take a look at it

[jtydhr88]

thanks @mcmalt feedback, fixed in Comfy-Org/comfy-cli#310

[jtydhr88]

at the fixed merged in cli side, I will close it for now, please try later once we release a new version, and please feel free to reopen it if you still have questions

[mcmalt]

I have manually tested it by mirroring the changes locally to my comfy_cli installation and it works as expected, so when the new version is released I expect it to work correctly. Thanks!