Skip to content

Commit 32ddf43

Browse files
authored
Fixed: User gets stuck in Desktop Updating page when error occurs (#1055)
When installation of requirements error out (it did on Windows with access denied error when installing new dependencies), don't have the user get stuck in the `desktop-update` page. Currently user will wait in the Desktop update spinner forever. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-1055-Draft-Show-maintenance-page-when-1b46d73d365081d6a088c96f741fd026) by [Unito](https://www.unito.io)
1 parent 92ba36e commit 32ddf43

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

src/install/installationManager.ts

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -285,9 +285,14 @@ export class InstallationManager implements HasTelemetry {
285285
onStdout: sendLogIpc,
286286
onStderr: sendLogIpc,
287287
};
288-
await installation.virtualEnvironment.installComfyUIRequirements(callbacks);
289-
await installation.virtualEnvironment.installComfyUIManagerRequirements(callbacks);
290-
await installation.validate();
288+
try {
289+
await installation.virtualEnvironment.installComfyUIRequirements(callbacks);
290+
await installation.virtualEnvironment.installComfyUIManagerRequirements(callbacks);
291+
await installation.validate();
292+
} catch (error) {
293+
log.error('Error auto-updating packages:', error);
294+
await this.appWindow.loadPage('server-start');
295+
}
291296
}
292297

293298
static setReinstallHandler(installation: ComfyInstallation) {

0 commit comments

Comments
 (0)