Always use unique names when adding slots

Author: webfiltered

src/strings.ts

@@ -21,3 +21,19 @@ export function stringOrEmpty(value: unknown): string {
 export function parseSlotTypes(type: ISlotType): string[] {
   return type == "" || type == "0" ? ["*"] : String(type).toLowerCase().split(",")
 }
+
+/**
+ * Creates a unique name by appending an underscore and a number to the end of the name
+ * if it already exists.
+ * @param name The name to make unique
+ * @param existingNames The names that already exist. Default: an empty array
+ * @returns The name, or a unique name if it already exists.
+ */
+export function nextUniqueName(name: string, existingNames: string[] = []): string {
+  let i = 1
+  const baseName = name
+  while (existingNames.includes(name)) {
+    name = `${baseName}_${i++}`
+  }
+  return name
+}

src/subgraph/EmptySubgraphInput.ts

@@ -4,6 +4,7 @@ import type { LGraphNode } from "@/LGraphNode"
 import type { RerouteId } from "@/Reroute"
 
 import { LLink } from "@/LLink"
+import { nextUniqueName } from "@/strings"
 import { zeroUuid } from "@/utils/uuid"
 
 import { SubgraphInput } from "./SubgraphInput"
@@ -23,7 +24,11 @@ export class EmptySubgraphInput extends SubgraphInput {
   }
 
   override connect(slot: INodeInputSlot, node: LGraphNode, afterRerouteId?: RerouteId): LLink | undefined {
-    const input = this.parent.subgraph.addInput(slot.name, String(slot.type))
+    const { subgraph } = this.parent
+    const existingNames = subgraph.inputs.map(x => x.name)
+
+    const name = nextUniqueName(slot.name, existingNames)
+    const input = subgraph.addInput(name, String(slot.type))
     return input.connect(slot, node, afterRerouteId)
   }
 

src/subgraph/EmptySubgraphOutput.ts

@@ -4,6 +4,7 @@ import type { LGraphNode } from "@/LGraphNode"
 import type { RerouteId } from "@/Reroute"
 
 import { LLink } from "@/LLink"
+import { nextUniqueName } from "@/strings"
 import { zeroUuid } from "@/utils/uuid"
 
 import { SubgraphOutput } from "./SubgraphOutput"
@@ -23,7 +24,11 @@ export class EmptySubgraphOutput extends SubgraphOutput {
   }
 
   override connect(slot: INodeOutputSlot, node: LGraphNode, afterRerouteId?: RerouteId): LLink | undefined {
-    const output = this.parent.subgraph.addOutput(slot.name, String(slot.type))
+    const { subgraph } = this.parent
+    const existingNames = subgraph.outputs.map(x => x.name)
+
+    const name = nextUniqueName(slot.name, existingNames)
+    const output = subgraph.addOutput(name, String(slot.type))
     return output.connect(slot, node, afterRerouteId)
   }