add error handling

Author: Commandcracker

README.md

@@ -240,7 +240,6 @@ selenium or playwright
 - [ ] Update checker option to perform update
 - [ ] Watchlist
 - [ ] New anime/series Notifications
-- [ ] Image preview (Kitty protocol, iterm protocol, Sixel, textual-web)
 - [ ] Use something like opencv to time match a sub from aniworld with a high quality video form another site.
 - [ ] Nix package
 - [ ] Docker image
@@ -271,7 +270,6 @@ selenium or playwright
 
 ### Bugs & DX
 
-- [ ] Proper error handling
 - [ ] Logging and Crash reports
 - [ ] Blacklist detection & bypass
 - [ ] 404 detection inside Hoster and don't crash whole program on http error + crash reports/logs

src/gucken/__init__.py

@@ -1,4 +1,4 @@
 import warnings
 warnings.filterwarnings('ignore', message='Using slow pure-python SequenceMatcher. Install python-Levenshtein to remove this warning')
 
-__version__ = "0.3.5"
+__version__ = "0.3.6"

src/gucken/gucken.py

@@ -100,13 +100,41 @@ def hoster_sort_key(_hoster: str) -> int:
     return sorted(hoster_list, key=hoster_sort_key)
 
 
-async def get_working_direct_link(hosters: list[Hoster]) -> Union[DirectLink, None]:
+async def get_working_direct_link(hosters: list[Hoster], app: "GuckenApp") -> Union[DirectLink, None]:
     for hoster in hosters:
-        direct_link = await hoster.get_direct_link()
+        name = type(hoster).__name__
+        try:
+            direct_link = await hoster.get_direct_link()
+        except Exception:
+            logging.warning(
+                "%s: failed to retrieve video URL from: \"%s\"",
+                name,
+                hoster.url,
+                exc_info=True
+            )
+            app.notify(
+                "Failed to retrieve video URL",
+                title=f"{name} error",
+                severity="warning",
+            )
+            continue
+        if direct_link is None:
+            logging.warning(
+                "%s: failed to retrieve video URL from: \"%s\"",
+                name,
+                hoster.url,
+                exc_info=True
+            )
+            app.notify(
+                "Failed to retrieve video URL",
+                title=f"{name} error",
+                severity="warning",
+            )
+            continue
         is_working = await direct_link.check_is_working()
         logging.info(
             'Check: "%s" Working: "%s" URL: "%s"',
-            type(hoster).__name__,
+            name,
             is_working,
             direct_link,
         )
@@ -716,7 +744,7 @@ async def play(
 
         lang = sort_favorite_lang(episode.available_language, self.language)[0]
         sorted_hoster = sort_favorite_hoster(processed_hoster.get(lang), self.hoster)
-        direct_link = await get_working_direct_link(sorted_hoster)
+        direct_link = await get_working_direct_link(sorted_hoster, self)
 
         # TODO: check for header support
         syncplay = gucken_settings_manager.settings["settings"]["syncplay"]

src/gucken/hoster/common.py

@@ -29,13 +29,6 @@ def has_headers(self) -> bool:
         return False
 
 
-@dataclass
-class EmptyDirectLink(DirectLink):
-    url: str = None
-
-    async def check_is_working(self) -> bool:
-        return False
-
 @dataclass
 class Hoster:
     url: str

src/gucken/hoster/filemoon.py

@@ -1,7 +1,6 @@
-import logging
 from re import compile as re_compile
 
-from .common import DirectLink, Hoster, EmptyDirectLink
+from .common import DirectLink, Hoster
 from ..networking import AsyncClient
 from ..packer import unpack
 
@@ -33,6 +32,3 @@ async def get_direct_link(self) -> DirectLink:
                 video_match = VIDEO_URL_REGEX.search(unpacked)
                 if video_match:
                     return DirectLink(video_match.group(1))
-
-            logging.warning("Filemoon: failed to retrieve video URL from: \"%s\"", self.url)
-            return EmptyDirectLink()