Skip to content

Commit 8635758

Browse files
committed
Revert up to "SampleApp: Add keystore files"
Revert "Build: Separate plugin and sampleapp build steps" This reverts commit b7a61bd. Revert "SampleApp: Update proguardFiles configuration" This reverts commit 36320a2. Revert "Build: Do not include plugin module in root project" This reverts commit 0c31335.
1 parent b7a61bd commit 8635758

File tree

4 files changed

+16
-23
lines changed

4 files changed

+16
-23
lines changed

.github/workflows/build.yml

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,10 @@ jobs:
3131
- name: Grant execute permission for gradlew
3232
run: chmod +x gradlew
3333

34-
- name: Run plugin build with caching enabled
34+
- name: Run build with caching enabled
3535
uses: gradle/[email protected]
3636
with:
37-
arguments: :secretsvaultplugin:clean :secretsvaultplugin:build -s
37+
arguments: clean build -s
3838

39-
- name: Run Detekt for plugin
40-
run: ./gradlew :secretsvaultplugin:detektMain
41-
42-
- name: Run sampleapp build with caching enabled
43-
uses: gradle/[email protected]
44-
with:
45-
arguments: :sampleapp:clean :sampleapp:build -s
39+
- name: Run Detekt
40+
run: ./gradlew detektMain

build.gradle.kts

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,10 @@
11
plugins {
2+
alias(libs.plugins.kotlin.jvm).apply(false)
3+
alias(libs.plugins.gradle.publish).apply(false)
4+
alias(libs.plugins.detekt).apply(false)
5+
alias(libs.plugins.kotlin.serialization).apply(false)
6+
7+
// Sample App
28
alias(libs.plugins.android.application).apply(false)
39
alias(libs.plugins.kotlin.android).apply(false)
410
}
5-
6-
tasks.register("build") {
7-
gradle.includedBuilds.forEach {
8-
dependsOn(it.task(":build"))
9-
}
10-
}
11-
12-
tasks.register("clean") {
13-
gradle.includedBuilds.forEach {
14-
dependsOn(it.task(":clean"))
15-
}
16-
}

sampleapp/build.gradle.kts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,8 @@ android {
4444
signingConfig = signingConfigs.getByName("release")
4545
isMinifyEnabled = true
4646
proguardFiles(
47-
getDefaultProguardFile("proguard-android-optimize.txt")
47+
getDefaultProguardFile("proguard-android-optimize.txt"),
48+
"proguard-rules.pro"
4849
)
4950
}
5051
}

settings.gradle.kts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
pluginManagement {
2-
includeBuild("secretsvaultplugin")
2+
includeBuild("secretsvaultplugin") {
3+
name = "secretsvaultplugin_included"
4+
}
35
repositories {
46
google()
57
mavenCentral()
@@ -17,3 +19,4 @@ dependencyResolutionManagement {
1719
rootProject.name = "Secrets Vault Plugin"
1820

1921
include(":sampleapp")
22+
include(":secretsvaultplugin")

0 commit comments

Comments
 (0)