CBST-19: missing relays warning (#185)

Author: ltitanb

crates/common/src/pbs/event.rs

@@ -31,7 +31,13 @@ pub enum BuilderEvent {
     GetStatusResponse,
     SubmitBlockRequest(Box<SignedBlindedBeaconBlock>),
     SubmitBlockResponse(Box<SubmitBlindedBlockResponse>),
-    MissedPayload { block_hash: B256, relays: String },
+    MissedPayload {
+        /// Hash for the block for which no payload was received
+        block_hash: B256,
+        /// Relays which delivered the header but for which no payload was
+        /// received
+        missing_relays: String,
+    },
     RegisterValidatorRequest(Vec<ValidatorRegistration>),
     RegisterValidatorResponse,
 }

crates/pbs/src/routes/submit_block.rs

@@ -49,24 +49,21 @@ pub async fn handle_submit_block<S: BuilderApiState, A: BuilderApi<S>>(
 
         Err(err) => {
             if let Some(fault_pubkeys) = state.get_relays_by_block_hash(slot, block_hash) {
-                let fault_relays = state
+                let missing_relays = state
                     .relays()
                     .iter()
                     .filter(|relay| fault_pubkeys.contains(&relay.pubkey()))
                     .map(|relay| &**relay.id)
                     .collect::<Vec<_>>()
                     .join(",");
 
-                error!(%err, %block_hash, fault_relays, "CRITICAL: no payload received from relays");
-                state.publish_event(BuilderEvent::MissedPayload {
-                    block_hash,
-                    relays: fault_relays,
-                });
+                error!(%err, %block_hash, missing_relays, "CRITICAL: no payload received from relays");
+                state.publish_event(BuilderEvent::MissedPayload { block_hash, missing_relays });
             } else {
                 error!(%err, %block_hash, "CRITICAL: no payload delivered and no relay for block hash. Was getHeader even called?");
                 state.publish_event(BuilderEvent::MissedPayload {
                     block_hash,
-                    relays: String::default(),
+                    missing_relays: String::default(),
                 });
             };