Fix flagging so IA instructions don't mess with other games

Author: fl4tisjustice

mgs-spec-bank/data.yaml

@@ -35,15 +35,19 @@ flags:
     new_bgmstop: yes
     new_bgmplay: yes
     new_createsurface: yes
+    new_createthread: no
     new_loaddata: yes
     new_memberwrite: yes
+    new_messetid: no
     new_playmovie: yes
     new_presence: yes
     new_pressstart: no
+    new_resetflag: no
     new_save: yes
     new_seplay: yes
     new_setdic: yes
     new_setevflag: yes
+    new_setflag: no
     new_scriptload: no
     new_sseplay: no
     new_titlemenu: yes
@@ -63,20 +67,25 @@ flags:
     new_bgmplay: yes
     new_bgmstop: yes
     new_createsurface: yes
+    new_createthread: no
     new_ev: yes
+    new_messetid: no
     new_playmovie: yes
     new_presence: yes
     new_save: yes
+    new_resetflag: no
     new_scriptload: no
     new_seplay: yes
     new_setdic: yes
     new_setevflag: no
+    new_setflag: no
     new_sseplay: no
     new_titlemenu: no
     new_voiceplay: no
     new_voicestop: no
     add_contents: no
 
+    achchktitle: no
     effyuge: no
     chaload: yes
     mescls: yes
@@ -88,21 +97,26 @@ flags:
 
     new_bgmplay: yes
     new_bgmstop: yes
+    new_createthread: no
     new_loaddata: yes
     new_memberwrite: yes
+    new_messetid: no
     new_playmovie: yes
     new_presence: yes
     new_pressstart: no
+    new_resetflag: no
     new_save: yes
     new_scriptload: no
     new_seplay: yes
     new_setdic: yes
     new_setevflag: yes
+    new_setflag: no
     new_sseplay: yes
     new_titlemenu: yes
     new_voicestop: yes
     add_contents: yes
 
+    achchktitle: yes
     effyuge: yes
     bgrelease: yes
     chaload: yes
@@ -115,16 +129,20 @@ flags:
 
     new_bgmplay: yes
     new_bgmstop: yes
+    new_createthread: no
     new_loaddata: yes
     new_memberwrite: yes
+    new_messetid: no
     new_playmovie: yes
     new_presence: yes
     new_pressstart: no
+    new_resetflag: no
     new_save: yes
     new_scriptload: yes
     new_seplay: yes
     new_setdic: yes
     new_setevflag: yes
+    new_setflag: no
     new_sseplay: yes
     new_titlemenu: yes
     new_voicestop: yes
@@ -144,14 +162,18 @@ flags:
     new_bgmplay: yes
     new_bgmstop: yes
     new_createsurface: yes
+    new_createthread: no
+    new_messetid: no
     new_playmovie: yes
     new_presence: yes
     new_pressstart: yes
+    new_resetflag: no
     new_save: yes
     new_scriptload: no
     new_seplay: yes
     new_setdic: yes
     new_setevflag: no
+    new_setflag: no
     new_sseplay: no
     new_titlemenu: yes
     new_voiceplay: no
@@ -173,12 +195,16 @@ flags:
 
     new_bgmplay: yes
     new_bgmstop: yes
+    new_createthread: yes
+    new_messetid: yes
     new_playmovie: yes
     new_presence: yes
+    new_resetflag: yes
     new_save: yes
     new_scriptload: no
     new_seplay: yes
     new_setevflag: yes
+    new_setflag: yes
     new_sseplay: yes
     new_titlemenu: yes
     new_voicestop: yes

mgs-spec-bank/instructions/base/base_00.yaml

@@ -6,7 +6,17 @@
 - pattern: 00 01
   name: CreateThread
   operands: [expr, expr, int16]
-  flags: [~game_ia]
+  flags: [~new_createthread]
+
+- pattern: 00 01 00
+  name: CreateThread
+  operands: [expr, expr, int16]
+  flags: [new_createthread]
+
+- pattern: 00 01 80
+  name: CreateNamedThread
+  operands: [expr, expr, int16, str]
+  flags: [new_createthread]
 
 - pattern: 00 04
   name: ScriptLoad
@@ -111,12 +121,42 @@
 - pattern: 00 12
   name: SetFlag
   operands: [expr]
-  flags: [~game_ia]
+  flags: [~new_setflag]
 
 - pattern: 00 13
   name: ResetFlag
   operands: [expr]
-  flags: [~game_ia]
+  flags: [~new_resetflag]
+
+- pattern: 00 12 00
+  name: SetFlag
+  operands: [expr]
+  flags: [new_setflag]
+
+- pattern: 00 12 01
+  name: SetNFlagsFrom
+  operands: [expr, expr]
+  flags: [new_setflag]
+
+- pattern: 00 12 02
+  name: SetFlagsThru
+  operands: [expr, expr]
+  flags: [new_setflag]
+
+- pattern: 00 13 00
+  name: ResetFlag
+  operands: [expr]
+  flags: [new_resetflag]
+
+- pattern: 00 13 01
+  name: ResetNFlagsFrom
+  operands: [expr, expr]
+  flags: [new_resetflag]
+
+- pattern: 00 13 02
+  name: ResetFlagsThru
+  operands: [expr, expr]
+  flags: [new_resetflag]
 
 - pattern: 00 14
   name: CopyFlag

mgs-spec-bank/instructions/base/base_01.yaml

@@ -111,17 +111,47 @@
 - pattern: 01 09 00
   name: MesSetSavePointRL
   operands: [int16]
-  flags: [return_labels, ~game_ia]
+  flags: [return_labels, ~new_messetid]
 
 - pattern: 01 09 01
   name: MesSSetSavePointRL
   operands: [int16, expr]
-  flags: [return_labels, ~game_ia]
+  flags: [return_labels, ~new_messetid]
 
 - pattern: 01 09 02
   name: MesSSetSavePoint
   operands: [expr]
-  flags: [return_labels, ~game_ia]
+  flags: [return_labels, ~new_messetid]
+
+- pattern: 01 09 80
+  name: MesSetSavePointRL
+  operands: [int16]
+  flags: [return_labels, new_messetid]
+
+- pattern: 01 09 81
+  name: MesSSetSavePointRL
+  operands: [int16, expr]
+  flags: [return_labels, new_messetid]
+
+- pattern: 01 09 82
+  name: MesSSetSavePoint
+  operands: [expr]
+  flags: [return_labels, new_messetid]
+
+- pattern: 01 09 00
+  name: MesSetIdRL
+  operands: [int16]
+  flags: [return_labels, new_messetid]
+
+- pattern: 01 09 01
+  name: MesSSetIdRL
+  operands: [expr]
+  flags: [return_labels, new_messetid]
+
+- pattern: 01 09 02
+  name: MesSetId
+  operands: [expr]
+  flags: [return_labels, new_messetid]
 
 - pattern: 01 0A 03
   name: CalcSinL

mgs-spec-bank/instructions/base/base_10.yaml

@@ -431,7 +431,7 @@
 - pattern: 10 2D
   name: AchChkTitle
   operands: []
-  flags: [~game_chlcc]
+  flags: [achchktitle]
 
 - pattern: 10 2E
   name: Unk_10_2E

mgs-spec-bank/instructions/iwakura_aria.yaml

@@ -1,43 +1,3 @@
-- pattern: 00 01 00
-  name: CreateThread
-  operands: [expr, expr, int16]
-  flags: [game_ia]
-
-- pattern: 00 01 80
-  name: CreateNamedThread
-  operands: [expr, expr, int16, str]
-  flags: [game_ia]
-
-- pattern: 00 12 00
-  name: SetFlag
-  operands: [expr]
-  flags: [game_ia]
-
-- pattern: 00 12 01
-  name: SetNFlagsFrom
-  operands: [expr, expr]
-  flags: [game_ia]
-
-- pattern: 00 12 02
-  name: SetFlagsThru
-  operands: [expr, expr]
-  flags: [game_ia]
-
-- pattern: 00 13 00
-  name: ResetFlag
-  operands: [expr]
-  flags: [game_ia]
-
-- pattern: 00 13 01
-  name: ResetNFlagsFrom
-  operands: [expr, expr]
-  flags: [game_ia]
-
-- pattern: 00 13 02
-  name: ResetFlagsThru
-  operands: [expr, expr]
-  flags: [game_ia]
-
 - pattern: 00 26 00
   name: SSEplayEx
   operands: [expr]
@@ -78,36 +38,6 @@
   operands: [expr]
   flags: [game_ia]
 
-- pattern: 01 09 80
-  name: MesSetSavePointRL
-  operands: [int16]
-  flags: [return_labels, game_ia]
-
-- pattern: 01 09 81
-  name: MesSSetSavePointRL
-  operands: [int16, expr]
-  flags: [return_labels, game_ia]
-
-- pattern: 01 09 82
-  name: MesSSetSavePoint
-  operands: [expr]
-  flags: [return_labels, game_ia]
-
-- pattern: 01 09 00
-  name: MesSetIdRL
-  operands: [int16]
-  flags: [return_labels, game_ia]
-
-- pattern: 01 09 01
-  name: MesSSetIdRL
-  operands: [expr]
-  flags: [return_labels, game_ia]
-
-- pattern: 01 09 02
-  name: MesSetId
-  operands: [expr]
-  flags: [return_labels, game_ia]
-
 - pattern: 10 22 28
   name: AutoSave_28
   operands: []