Skip to content

Commit 2638299

Browse files
taylorarndtCopilot
andcommitted
Search: result titles as h2 headings, count says 'X results found'
- Each result title is now an <h2> with a link (screen reader navigable by heading) - Status message reads '5 results found for "issues"' instead of '5 results for...' Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 1567acf commit 2638299

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

html/search.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
.search-results-list { list-style: none; padding: 0; margin: 0; }
2020
.search-result-item { margin-bottom: 2rem; padding-bottom: 1.5rem; border-bottom: 1px solid var(--borderColor-default, #d0d7de); }
2121
.search-result-item:last-child { border-bottom: none; }
22-
.search-result-title { font-size: 1.2rem; font-weight: 600; margin-bottom: 0.25rem; }
22+
.search-result-title { font-size: 1.2rem; font-weight: 600; margin: 0 0 0.25rem 0; padding: 0; border: none; }
2323
.search-result-title a { color: #0969da; text-decoration: none; }
2424
.search-result-title a:hover { text-decoration: underline; }
2525
.search-result-url { font-size: 0.8rem; color: #57606a; margin-bottom: 0.4rem; }
@@ -116,7 +116,7 @@ <h1>Search</h1>
116116
return;
117117
}
118118

119-
statusEl.textContent = results.length + ' result' + (results.length === 1 ? '' : 's') + ' for "' + query + '"';
119+
statusEl.textContent = results.length + ' result' + (results.length === 1 ? '' : 's') + ' found for "' + query + '"';
120120

121121
var pageMap = {};
122122
pages.forEach(function (p) { pageMap[p.id] = p; });
@@ -149,7 +149,7 @@ <h1>Search</h1>
149149
var li = document.createElement('li');
150150
li.className = 'search-result-item';
151151
li.innerHTML =
152-
'<div class="search-result-title"><a href="./' + page.url + '">' + page.title + '</a></div>' +
152+
'<h2 class="search-result-title"><a href="./' + page.url + '">' + page.title + '</a></h2>' +
153153
'<div class="search-result-url">' + page.url + '</div>' +
154154
'<div class="search-result-snippet">' + snippet + '</div>';
155155
resultsEl.appendChild(li);

scripts/build-html.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -681,7 +681,7 @@ function buildSearchPage(outputDir) {
681681
.search-results-list { list-style: none; padding: 0; margin: 0; }
682682
.search-result-item { margin-bottom: 2rem; padding-bottom: 1.5rem; border-bottom: 1px solid var(--borderColor-default, #d0d7de); }
683683
.search-result-item:last-child { border-bottom: none; }
684-
.search-result-title { font-size: 1.2rem; font-weight: 600; margin-bottom: 0.25rem; }
684+
.search-result-title { font-size: 1.2rem; font-weight: 600; margin: 0 0 0.25rem 0; padding: 0; border: none; }
685685
.search-result-title a { color: #0969da; text-decoration: none; }
686686
.search-result-title a:hover { text-decoration: underline; }
687687
.search-result-url { font-size: 0.8rem; color: #57606a; margin-bottom: 0.4rem; }
@@ -778,7 +778,7 @@ function buildSearchPage(outputDir) {
778778
return;
779779
}
780780
781-
statusEl.textContent = results.length + ' result' + (results.length === 1 ? '' : 's') + ' for "' + query + '"';
781+
statusEl.textContent = results.length + ' result' + (results.length === 1 ? '' : 's') + ' found for "' + query + '"';
782782
783783
var pageMap = {};
784784
pages.forEach(function (p) { pageMap[p.id] = p; });
@@ -811,7 +811,7 @@ function buildSearchPage(outputDir) {
811811
var li = document.createElement('li');
812812
li.className = 'search-result-item';
813813
li.innerHTML =
814-
'<div class="search-result-title"><a href="./' + page.url + '">' + page.title + '</a></div>' +
814+
'<h2 class="search-result-title"><a href="./' + page.url + '">' + page.title + '</a></h2>' +
815815
'<div class="search-result-url">' + page.url + '</div>' +
816816
'<div class="search-result-snippet">' + snippet + '</div>';
817817
resultsEl.appendChild(li);

0 commit comments

Comments
 (0)