Skip to content

Commit cf3eff7

Browse files
taylorarndtCopilot
andcommitted
fix: unwrap <p> from list items so screen readers read bullets correctly
Loose markdown lists (blank lines between items) caused marked to wrap each item in <p> tags, making screen readers announce a paragraph break before reading the bullet text. Added a listitem renderer that strips the wrapping <p> when an item contains a single paragraph. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent b5f8d17 commit cf3eff7

File tree

68 files changed

+1136
-1226
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

68 files changed

+1136
-1226
lines changed

html/ACCESSIBILITY_TESTING.html

Lines changed: 102 additions & 102 deletions
Large diffs are not rendered by default.

html/CHALLENGE_SYSTEM_ARCHITECTURE.html

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -655,21 +655,21 @@ <h3 id="generated-for-a-30-person-cohort">Generated for a 30-person cohort:</h3>
655655
<h2 id="next-steps-future-enhancements">Next Steps (Future Enhancements)</h2>
656656
<h3 id="short-term">Short Term</h3>
657657
<ul>
658-
<li><input checked="" disabled="" type="checkbox"> Add templates for guided chapters (7-10, 12-16) -- completed via <code>create_all_challenges.ps1</code></li>
659-
<li><input aria-label="Create facilitator monitoring dashboard (custom actions)" disabled="" type="checkbox"> Create facilitator monitoring dashboard (custom actions)</li>
660-
<li><input aria-label="Add bulk archive script for end-of-workshop cleanup" disabled="" type="checkbox"> Add bulk archive script for end-of-workshop cleanup</li>
658+
<li><input type="checkbox" checked disabled> <input checked="" disabled="" type="checkbox"> Add templates for guided chapters (7-10, 12-16) -- completed via <code>create_all_challenges.ps1</code></li>
659+
<li><input type="checkbox" disabled> <input aria-label="Create facilitator monitoring dashboard (custom actions)" disabled="" type="checkbox"> Create facilitator monitoring dashboard (custom actions)</li>
660+
<li><input type="checkbox" disabled> <input aria-label="Add bulk archive script for end-of-workshop cleanup" disabled="" type="checkbox"> Add bulk archive script for end-of-workshop cleanup</li>
661661
</ul>
662662
<h3 id="medium-term">Medium Term</h3>
663663
<ul>
664-
<li><input aria-label="Student self-assessment: &quot;Did this challenge teach the concept?&quot;" disabled="" type="checkbox"> Student self-assessment: &quot;Did this challenge teach the concept?&quot;</li>
665-
<li><input aria-label="Difficulty calibration: Track which challenges take longest" disabled="" type="checkbox"> Difficulty calibration: Track which challenges take longest</li>
666-
<li><input aria-label="Peer feedback: Students comment on each other&#39;s solutions" disabled="" type="checkbox"> Peer feedback: Students comment on each other&#39;s solutions</li>
664+
<li><input type="checkbox" disabled> <input aria-label="Student self-assessment: &quot;Did this challenge teach the concept?&quot;" disabled="" type="checkbox"> Student self-assessment: &quot;Did this challenge teach the concept?&quot;</li>
665+
<li><input type="checkbox" disabled> <input aria-label="Difficulty calibration: Track which challenges take longest" disabled="" type="checkbox"> Difficulty calibration: Track which challenges take longest</li>
666+
<li><input type="checkbox" disabled> <input aria-label="Peer feedback: Students comment on each other&#39;s solutions" disabled="" type="checkbox"> Peer feedback: Students comment on each other&#39;s solutions</li>
667667
</ul>
668668
<h3 id="long-term">Long Term</h3>
669669
<ul>
670-
<li><input aria-label="Gamification: Badges for challenge streaks, skill level badges" disabled="" type="checkbox"> Gamification: Badges for challenge streaks, skill level badges</li>
671-
<li><input aria-label="Difficulty curves: AI recommendation of next challenge based on pace" disabled="" type="checkbox"> Difficulty curves: AI recommendation of next challenge based on pace</li>
672-
<li><input aria-label="Mobile: GitHub Mobile app integration for easier issue tracking" disabled="" type="checkbox"> Mobile: GitHub Mobile app integration for easier issue tracking</li>
670+
<li><input type="checkbox" disabled> <input aria-label="Gamification: Badges for challenge streaks, skill level badges" disabled="" type="checkbox"> Gamification: Badges for challenge streaks, skill level badges</li>
671+
<li><input type="checkbox" disabled> <input aria-label="Difficulty curves: AI recommendation of next challenge based on pace" disabled="" type="checkbox"> Difficulty curves: AI recommendation of next challenge based on pace</li>
672+
<li><input type="checkbox" disabled> <input aria-label="Mobile: GitHub Mobile app integration for easier issue tracking" disabled="" type="checkbox"> Mobile: GitHub Mobile app integration for easier issue tracking</li>
673673
</ul>
674674
<h2 id="document-control">Document Control</h2>
675675
<table>

html/COMPREHENSIVE_VALIDATION_AUDIT.html

Lines changed: 41 additions & 56 deletions
Large diffs are not rendered by default.

html/ENROLLMENT_SUMMARY.html

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -229,43 +229,43 @@ <h2 id="verification-checklist-friday">Verification Checklist (Friday)</h2>
229229
<p>Before Saturday workshop, verify:</p>
230230
<h3 id="organization-setup">Organization Setup</h3>
231231
<ul>
232-
<li><input aria-label="All 67 invitations sent to students" disabled="" type="checkbox"> All 67 invitations sent to students</li>
233-
<li><input aria-label="Check pending invitations:" disabled="" type="checkbox"> Check pending invitations: <a href="https://github.com/orgs/Community-Access/pending_invitations">https://github.com/orgs/Community-Access/pending_invitations</a></li>
234-
<li><input aria-label="Track acceptance rate (aim for 100% by 3pm Friday)" disabled="" type="checkbox"> Track acceptance rate (aim for 100% by 3pm Friday)</li>
235-
<li><input aria-label="Document any students who don&#39;t accept" disabled="" type="checkbox"> Document any students who don&#39;t accept</li>
232+
<li><input type="checkbox" disabled> <input aria-label="All 67 invitations sent to students" disabled="" type="checkbox"> All 67 invitations sent to students</li>
233+
<li><input type="checkbox" disabled> <input aria-label="Check pending invitations:" disabled="" type="checkbox"> Check pending invitations: <a href="https://github.com/orgs/Community-Access/pending_invitations">https://github.com/orgs/Community-Access/pending_invitations</a></li>
234+
<li><input type="checkbox" disabled> <input aria-label="Track acceptance rate (aim for 100% by 3pm Friday)" disabled="" type="checkbox"> Track acceptance rate (aim for 100% by 3pm Friday)</li>
235+
<li><input type="checkbox" disabled> <input aria-label="Document any students who don&#39;t accept" disabled="" type="checkbox"> Document any students who don&#39;t accept</li>
236236
</ul>
237237
<h3 id="repository-readiness">Repository Readiness</h3>
238238
<ul>
239-
<li><input aria-label="67 student branches visible in repository" disabled="" type="checkbox"> 67 student branches visible in repository</li>
240-
<li><input aria-label="Main branch protection enabled" disabled="" type="checkbox"> Main branch protection enabled</li>
241-
<li><input aria-label="GitHub Actions workflows enabled and tested" disabled="" type="checkbox"> GitHub Actions workflows enabled and tested</li>
242-
<li><input aria-label="Assignment issues created (run" disabled="" type="checkbox"> Assignment issues created (run <code>python scripts/batch_create_issues.py</code> once members join)</li>
239+
<li><input type="checkbox" disabled> <input aria-label="67 student branches visible in repository" disabled="" type="checkbox"> 67 student branches visible in repository</li>
240+
<li><input type="checkbox" disabled> <input aria-label="Main branch protection enabled" disabled="" type="checkbox"> Main branch protection enabled</li>
241+
<li><input type="checkbox" disabled> <input aria-label="GitHub Actions workflows enabled and tested" disabled="" type="checkbox"> GitHub Actions workflows enabled and tested</li>
242+
<li><input type="checkbox" disabled> <input aria-label="Assignment issues created (run" disabled="" type="checkbox"> Assignment issues created (run <code>python scripts/batch_create_issues.py</code> once members join)</li>
243243
</ul>
244244
<h3 id="facilitator-readiness">Facilitator Readiness</h3>
245245
<ul>
246-
<li><input aria-label="2-3 admins added as organization admin role" disabled="" type="checkbox"> 2-3 admins added as organization admin role<pre><code class="hljs language-bash">gh api /orgs/Community-Access/members/[username] -X PUT -f role=admin</code></pre>
246+
<li><input type="checkbox" disabled> <input aria-label="2-3 admins added as organization admin role" disabled="" type="checkbox"> 2-3 admins added as organization admin role<pre><code class="hljs language-bash">gh api /orgs/Community-Access/members/[username] -X PUT -f role=admin</code></pre>
247247
</li>
248-
<li><input aria-label="Facilitators read FACILITATOR_GUIDE.md" disabled="" type="checkbox"> Facilitators read FACILITATOR_GUIDE.md</li>
249-
<li><input aria-label="Facilitators understand peer review assignments" disabled="" type="checkbox"> Facilitators understand peer review assignments</li>
250-
<li><input aria-label="Facilitators have access to progress tracker" disabled="" type="checkbox"> Facilitators have access to progress tracker</li>
248+
<li><input type="checkbox" disabled> <input aria-label="Facilitators read FACILITATOR_GUIDE.md" disabled="" type="checkbox"> Facilitators read FACILITATOR_GUIDE.md</li>
249+
<li><input type="checkbox" disabled> <input aria-label="Facilitators understand peer review assignments" disabled="" type="checkbox"> Facilitators understand peer review assignments</li>
250+
<li><input type="checkbox" disabled> <input aria-label="Facilitators have access to progress tracker" disabled="" type="checkbox"> Facilitators have access to progress tracker</li>
251251
</ul>
252252
<h3 id="documentation-complete">Documentation Complete</h3>
253253
<ul>
254-
<li><input aria-label="ADMIN_TEST_PLAN.md reviewed (8 test scenarios)" disabled="" type="checkbox"> ADMIN_TEST_PLAN.md reviewed (8 test scenarios)</li>
255-
<li><input aria-label="REPOSITORY_SECURITY.md accessible to facilitators" disabled="" type="checkbox"> REPOSITORY_SECURITY.md accessible to facilitators</li>
256-
<li><input aria-label="Facilitator guide has key timestamps" disabled="" type="checkbox"> Facilitator guide has key timestamps</li>
257-
<li><input aria-label="Learning paths with challenge solutions ready" disabled="" type="checkbox"> Learning paths with challenge solutions ready</li>
254+
<li><input type="checkbox" disabled> <input aria-label="ADMIN_TEST_PLAN.md reviewed (8 test scenarios)" disabled="" type="checkbox"> ADMIN_TEST_PLAN.md reviewed (8 test scenarios)</li>
255+
<li><input type="checkbox" disabled> <input aria-label="REPOSITORY_SECURITY.md accessible to facilitators" disabled="" type="checkbox"> REPOSITORY_SECURITY.md accessible to facilitators</li>
256+
<li><input type="checkbox" disabled> <input aria-label="Facilitator guide has key timestamps" disabled="" type="checkbox"> Facilitator guide has key timestamps</li>
257+
<li><input type="checkbox" disabled> <input aria-label="Learning paths with challenge solutions ready" disabled="" type="checkbox"> Learning paths with challenge solutions ready</li>
258258
</ul>
259259
<h3 id="test-runs-friday-2-3pm">Test Runs (Friday 2-3pm)</h3>
260260
<ul>
261-
<li><input aria-label="Admin Test Scenario 1: Student branch access" disabled="" type="checkbox"> Admin Test Scenario 1: Student branch access </li>
262-
<li><input aria-label="Admin Test Scenario 2: Assignment issue visibility" disabled="" type="checkbox"> Admin Test Scenario 2: Assignment issue visibility </li>
263-
<li><input aria-label="Admin Test Scenario 3: PR template functionality" disabled="" type="checkbox"> Admin Test Scenario 3: PR template functionality </li>
264-
<li><input aria-label="Admin Test Scenario 4: GitHub Actions bot response" disabled="" type="checkbox"> Admin Test Scenario 4: GitHub Actions bot response </li>
265-
<li><input aria-label="Admin Test Scenario 5: Peer reviewer assignments" disabled="" type="checkbox"> Admin Test Scenario 5: Peer reviewer assignments </li>
266-
<li><input aria-label="Admin Test Scenario 6: Facilitator guide accessibility" disabled="" type="checkbox"> Admin Test Scenario 6: Facilitator guide accessibility </li>
267-
<li><input aria-label="Admin Test Scenario 7: Progress tracker setup" disabled="" type="checkbox"> Admin Test Scenario 7: Progress tracker setup </li>
268-
<li><input aria-label="Admin Test Scenario 8: End-to-end workflow" disabled="" type="checkbox"> Admin Test Scenario 8: End-to-end workflow</li>
261+
<li><input type="checkbox" disabled> <input aria-label="Admin Test Scenario 1: Student branch access" disabled="" type="checkbox"> Admin Test Scenario 1: Student branch access </li>
262+
<li><input type="checkbox" disabled> <input aria-label="Admin Test Scenario 2: Assignment issue visibility" disabled="" type="checkbox"> Admin Test Scenario 2: Assignment issue visibility </li>
263+
<li><input type="checkbox" disabled> <input aria-label="Admin Test Scenario 3: PR template functionality" disabled="" type="checkbox"> Admin Test Scenario 3: PR template functionality </li>
264+
<li><input type="checkbox" disabled> <input aria-label="Admin Test Scenario 4: GitHub Actions bot response" disabled="" type="checkbox"> Admin Test Scenario 4: GitHub Actions bot response </li>
265+
<li><input type="checkbox" disabled> <input aria-label="Admin Test Scenario 5: Peer reviewer assignments" disabled="" type="checkbox"> Admin Test Scenario 5: Peer reviewer assignments </li>
266+
<li><input type="checkbox" disabled> <input aria-label="Admin Test Scenario 6: Facilitator guide accessibility" disabled="" type="checkbox"> Admin Test Scenario 6: Facilitator guide accessibility </li>
267+
<li><input type="checkbox" disabled> <input aria-label="Admin Test Scenario 7: Progress tracker setup" disabled="" type="checkbox"> Admin Test Scenario 7: Progress tracker setup </li>
268+
<li><input type="checkbox" disabled> <input aria-label="Admin Test Scenario 8: End-to-end workflow" disabled="" type="checkbox"> Admin Test Scenario 8: End-to-end workflow</li>
269269
</ul>
270270
<h2 id="known-blockers--constraints">Known Blockers / Constraints</h2>
271271
<h3 id="http-422-validation-error-on-invitations">HTTP 422 Validation Error on Invitations</h3>

0 commit comments

Comments
 (0)