Remove deprecated IDistributedApplicationLifecycleHook interface #915

Copilot · 2025-10-22T04:58:53Z

Overview

This PR removes all usages of the deprecated IDistributedApplicationLifecycleHook interface and replaces them with modern event-based patterns, as required by dotnet/aspire#11266.

Changes

Deno & Bun: Installer Resource Pattern

Previously, Deno and Bun used lifecycle hooks to install packages before application startup. This PR migrates them to use the installer resource pattern (consistent with NodeJS npm/yarn/pnpm):

Before:

resource.ApplicationBuilder.Services.TryAddLifecycleHook<DenoPackageInstallerLifecycleHook>();

After:

var installer = new DenoInstallerResource(installerName, workingDirectory);
var installerBuilder = builder.AddResource(installer)
    .WithArgs("install")
    .WithParentRelationship(resource.Resource)
    .ExcludeFromManifest();
resource.WaitForCompletion(installerBuilder);

Files Changed:

Added: DenoInstallerResource.cs, BunInstallerResource.cs
Removed: DenoPackageInstallerLifecycleHook.cs, DenoPackageInstaller.cs, BunPackageInstallerLifecycleHook.cs
Updated: DenoAppHostingExtensions.cs, BunAppExtensions.cs

Dapr: IDistributedApplicationEventingSubscriber Pattern

Dapr's lifecycle hook has been converted to use the IDistributedApplicationEventingSubscriber pattern for idempotent registration:

Before:

builder.Services.TryAddLifecycleHook<DaprDistributedApplicationLifecycleHook>();

After:

builder.Services.TryAddEventingSubscriber<DaprDistributedApplicationLifecycleHook>();

// In the subscriber class:
public Task SubscribeAsync(IDistributedApplicationEventing eventing, DistributedApplicationExecutionContext executionContext, CancellationToken cancellationToken)
{
    eventing.Subscribe<BeforeStartEvent>(OnBeforeStartAsync);
    return Task.CompletedTask;
}

Files Changed:

Updated: IDistributedApplicationBuilderExtensions.cs, DaprDistributedApplicationLifecycleHook.cs

Pattern Benefits:

Idempotent registration via TryAddEventingSubscriber (similar to old TryAddLifecycleHook)
Cleaner separation of concerns with subscriber pattern
Consistent with other Aspire infrastructure components (e.g., Azure AppService)

Tests

Updated tests to use standard public APIs instead of internal lifecycle hook methods:

Replaced ExecuteBeforeStartHooksAsync() with app.StartAsync()
Added tests to verify installer resources are created correctly
Removed UnsafeAccessor reflection code

Benefits

No deprecated APIs - Eliminates all usages of IDistributedApplicationLifecycleHook
Consistency - Deno and Bun now follow the same pattern as NodeJS integrations
Better visibility - Package installers now appear as resources in the Aspire dashboard
Improved testability - Tests use standard public APIs
Idempotent registration - Dapr uses IDistributedApplicationEventingSubscriber for proper lifecycle management
Future-proof - Aligned with current .NET Aspire architecture

Migration Notes

No breaking changes for users:

WithDenoPackageInstallation() and WithBunPackageInstallation() work exactly as before
AddDapr() continues to work with the same API
The only visible change is that installer resources now appear in the Aspire dashboard

Fixes #890

Original prompt

This section details on the original issue you should resolve

<issue_title>Ensure life cycle hooks interface isn't used anymore</issue_title>
<issue_description>See dotnet/aspire#11266 - IDistributedApplicationLifecycleHook has been deprecated, so we need to ensure it's no longer used.</issue_description>

<agent_instructions>Compiling the solution will show the errors around the obsolete type and gives an indication on what to fix.</agent_instructions>

Comments on the Issue (you are @copilot in this section)

Fixes #890

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: aaronpowell <[email protected]>

davidfowl · 2025-10-22T05:35:37Z

You want to replace these with IDistributedApplicationEventingSubscriber is there a branch for 13? Is it main?

aaronpowell · 2025-10-22T06:01:52Z

You want to replace these with IDistributedApplicationEventingSubscriber is there a branch for 13? Is it main?

don't we want to replace them with the On<Event> methods?

davidfowl · 2025-10-22T06:06:01Z

IDistributedApplicationEventingSubscriber is a way to get both idempotency during registration (TryAddLifecycleHook) and it relies on subscribing to events via the On<X> methods.

aaronpowell · 2025-10-23T00:29:08Z

@copilot according to @davidfowl we should be using IDistributedApplicationEventingSubscriber instead. Here is the type definition: https://github.com/dotnet/aspire/blob/05ef4762f6748e9a8ff3d30857ab07bac3fd6f54/src/Aspire.Hosting/Lifecycle/IDistributedApplicationEventingSubscriber.cs#L12-L22 and you can find an example usage https://github.com/dotnet/aspire/blob/05ef4762f6748e9a8ff3d30857ab07bac3fd6f54/src/Aspire.Hosting.Azure.AppService/AzureAppServiceInfrastructure.cs#L73-L77 with the registration of the type https://github.com/dotnet/aspire/blob/05ef4762f6748e9a8ff3d30857ab07bac3fd6f54/src/Aspire.Hosting.Azure.AppService/AzureAppServiceEnvironmentExtensions.cs#L22-L32

Co-authored-by: aaronpowell <[email protected]>

Copilot · 2025-10-23T00:33:08Z

@copilot according to @davidfowl we should be using IDistributedApplicationEventingSubscriber instead. Here is the type definition: https://github.com/dotnet/aspire/blob/05ef4762f6748e9a8ff3d30857ab...

Updated Dapr to use IDistributedApplicationEventingSubscriber following the pattern from the Azure AppService example. The subscriber is now registered with TryAddEventingSubscriber for idempotency, and the SubscribeAsync method subscribes to BeforeStartEvent.

Commit: 69ebc86

aaronpowell · 2025-10-23T00:34:43Z

@davidfowl how's that looking?

davidfowl · 2025-10-23T03:39:06Z

src/CommunityToolkit.Aspire.Hosting.Bun/BunAppExtensions.cs

+        // Only install packages during development, not in publish mode
+        if (!resource.ApplicationBuilder.ExecutionContext.IsPublishMode)
+        {
+            var installerName = $"{resource.Resource.Name}-bun-install";


This call isn't idempotent. There's a new helper here https://github.com/dotnet/aspire/blob/5a87acfdb041ce3f89189a8af379fa24df4f3d44/src/Aspire.Hosting/DistributedApplicationBuilderExtensions.cs#L91.

You can use it like so https://github.com/dotnet/aspire/blob/5a87acfdb041ce3f89189a8af379fa24df4f3d44/src/Aspire.Hosting/ProjectResourceBuilderExtensions.cs#L822-L829

But this is moving away from the event model for doing this to the same model used for npm/pnpm/etc. installing.

davidfowl · 2025-10-23T03:39:26Z

src/CommunityToolkit.Aspire.Hosting.Deno/DenoAppHostingExtensions.cs

+        if (!resource.ApplicationBuilder.ExecutionContext.IsPublishMode)
+        {
+            var installerName = $"{resource.Resource.Name}-deno-install";
+            var installer = new DenoInstallerResource(installerName, resource.Resource.WorkingDirectory);


Same comment as above.

davidfowl · 2025-10-23T03:40:20Z

Yep!

…ire 13 update

* baseline branch for the next major release * Updating nightly * Remove deprecated IDistributedApplicationLifecycleHook interface (#915) * Initial plan * Replace IDistributedApplicationLifecycleHook with event-based patterns Co-authored-by: aaronpowell <[email protected]> * Add tests for installer resources and update Dapr tests Co-authored-by: aaronpowell <[email protected]> * Refactor Dapr to use IDistributedApplicationEventingSubscriber Co-authored-by: aaronpowell <[email protected]> * Fixing build issue * Updating the endpoint port * Disabling some tests so we can move forward in other parts of the Aspire 13 update --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: aaronpowell <[email protected]> Co-authored-by: Aaron Powell <[email protected]> * Adjusting the version of keycloak * Updating aspire nightly * New nightly * Remove npm functionality moved to Aspire 13 (#928) * Initial plan * Remove AddViteApp and npm-specific functionality (moved to Aspire 13) Co-authored-by: aaronpowell <[email protected]> * Update comments and tests to reflect npm removal Co-authored-by: aaronpowell <[email protected]> * Update MONOREPO.md to remove npm references Co-authored-by: aaronpowell <[email protected]> * Adding missing types * Bad copilot code * Fixing missing namespace * Handling port forwarding * removing more stuff that has been migrated to aspire core * Reworking how package installing is handled * daily update * Adding back the annotation that is no longer moving to core * Forgot to install packages * adding a bunch more annotations to provide enough metadata * Removing old demo apps * Disabling python tests * Removing a testing change * Updating to the latest nightly and dealing with type name changes * Removing type that was can repurpose from aspire core * breaking the tests down so they are easier to read * Removing legacy docs * Fixing failing tests --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: aaronpowell <[email protected]> Co-authored-by: Aaron Powell <[email protected]> * Fixing failing test * Remove deprecated EventStore integrations (#946) * Initial plan * Remove EventStore integrations and all associated files Co-authored-by: aaronpowell <[email protected]> * Remove EventStore project references from solution file Co-authored-by: aaronpowell <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: aaronpowell <[email protected]> Co-authored-by: Aaron Powell <[email protected]> Co-authored-by: Fredi Machado <[email protected]> * Creating a new agent for generating hosting integrations * Creating a new agent for generating client integrations * Expanded the hosting agent a bit * Removing the legacy approach to checking resource health and updated the last usages of it * Bumping go and removing pnpm setup * maybe we need an explicit health check * Using the new JavaScriptAppResource so we can leverage the new methods on inspector Getting rid of some custom code but making it so we run from local by default * Disabling tests on Windows due to modelcontextprotocol/inspector#893 --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: aaronpowell <[email protected]> Co-authored-by: Fredi Machado <[email protected]>

Copilot AI self-assigned this Oct 22, 2025

Initial plan

32efe61

Copilot AI assigned aaronpowell Oct 22, 2025

Copilot started work on behalf of aaronpowell October 22, 2025 04:59 View session

aaronpowell added this to the 13 milestone Oct 22, 2025

Copilot AI and others added 2 commits October 22, 2025 05:10

Replace IDistributedApplicationLifecycleHook with event-based patterns

0d3ab6c

Co-authored-by: aaronpowell <[email protected]>

Add tests for installer resources and update Dapr tests

414747e

Co-authored-by: aaronpowell <[email protected]>

Copilot AI changed the title ~~[WIP] Remove deprecated IDistributedApplicationLifecycleHook usage~~ Remove deprecated IDistributedApplicationLifecycleHook interface Oct 22, 2025

Copilot AI requested a review from aaronpowell October 22, 2025 05:20

Copilot finished work on behalf of aaronpowell October 22, 2025 05:20

Copilot started work on behalf of aaronpowell October 23, 2025 00:29 View session

Refactor Dapr to use IDistributedApplicationEventingSubscriber

69ebc86

Co-authored-by: aaronpowell <[email protected]>

Copilot finished work on behalf of aaronpowell October 23, 2025 00:34

aaronpowell added 2 commits October 23, 2025 01:06

Merge branch 'aspire-13' into copilot/remove-deprecated-lifecycle-hook

47f3b1a

Fixing build issue

3fe64f9

aaronpowell marked this pull request as ready for review October 23, 2025 02:44

aaronpowell requested review from FullStackChef, WhitWaldo and paule96 as code owners October 23, 2025 02:44

Updating the endpoint port

d500b03

aaronpowell requested a review from martinjt as a code owner October 23, 2025 03:26

davidfowl reviewed Oct 23, 2025

View reviewed changes

Disabling some tests so we can move forward in other parts of the Asp…

3daa28c

…ire 13 update

aaronpowell merged commit 06d5985 into aspire-13 Oct 24, 2025
103 of 104 checks passed

aaronpowell deleted the copilot/remove-deprecated-lifecycle-hook branch October 24, 2025 00:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove deprecated IDistributedApplicationLifecycleHook interface #915

Remove deprecated IDistributedApplicationLifecycleHook interface #915

Uh oh!

Copilot AI commented Oct 22, 2025 •

edited

Loading

Uh oh!

davidfowl commented Oct 22, 2025

Uh oh!

aaronpowell commented Oct 22, 2025

Uh oh!

davidfowl commented Oct 22, 2025 •

edited

Loading

Uh oh!

aaronpowell commented Oct 23, 2025

Uh oh!

Copilot AI commented Oct 23, 2025

Uh oh!

aaronpowell commented Oct 23, 2025

Uh oh!

davidfowl Oct 23, 2025

Uh oh!

aaronpowell Oct 23, 2025

Uh oh!

davidfowl Oct 23, 2025

Uh oh!

davidfowl commented Oct 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Remove deprecated IDistributedApplicationLifecycleHook interface #915

Remove deprecated IDistributedApplicationLifecycleHook interface #915

Uh oh!

Conversation

Copilot AI commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Changes

Deno & Bun: Installer Resource Pattern

Dapr: IDistributedApplicationEventingSubscriber Pattern

Tests

Benefits

Migration Notes

Comments on the Issue (you are @copilot in this section)

Uh oh!

davidfowl commented Oct 22, 2025

Uh oh!

aaronpowell commented Oct 22, 2025

Uh oh!

davidfowl commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aaronpowell commented Oct 23, 2025

Uh oh!

Copilot AI commented Oct 23, 2025

Uh oh!

aaronpowell commented Oct 23, 2025

Uh oh!

davidfowl Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

aaronpowell Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

davidfowl Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

davidfowl commented Oct 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Oct 22, 2025 •

edited

Loading

davidfowl commented Oct 22, 2025 •

edited

Loading