Skip to content

Commit 1c581de

Browse files
Turn off diagnostics for Solution Generation, leave hint at uploading logs in the build script.
1 parent 506e815 commit 1c581de

File tree

1 file changed

+14
-14
lines changed

1 file changed

+14
-14
lines changed

.github/workflows/build.yml

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ jobs:
8383

8484
- name: Generate solution w/ ${{ env.TEST_PLATFORM }} Tests
8585
working-directory: ./
86-
run: powershell -version 5.1 -command "./common/GenerateAllSolution.ps1 -IncludeHeads ${{ env.TEST_PLATFORM }} -UseDiagnostics" -ErrorAction Stop
86+
run: powershell -version 5.1 -command "./common/GenerateAllSolution.ps1 -IncludeHeads ${{ env.TEST_PLATFORM }}" -ErrorAction Stop
8787

8888
- name: Enable Uno.WinUI (in WinUI3 matrix only)
8989
working-directory: ./common/Scripts/
@@ -129,12 +129,12 @@ jobs:
129129
testspace '[${{ matrix.platform }}]./TestResults/*.trx'
130130
if: ${{ always() && (steps.test-generator.conclusion == 'success' || steps.test-platform.conclusion == 'success') }}
131131

132-
- name: Artifact - Slngen Logs
133-
uses: actions/upload-artifact@v3
134-
if: success() || failure()
135-
with:
136-
name: slngen-logs
137-
path: ./**/slngen.*log
132+
#- name: Artifact - Slngen Logs
133+
# uses: actions/upload-artifact@v3
134+
# if: success() || failure()
135+
# with:
136+
# name: slngen-logs
137+
# path: ./**/slngen.*log
138138

139139
# Test job to build a single experiment to ensure our changes work for both our main types of solutions at the moment
140140
new-experiment:
@@ -215,7 +215,7 @@ jobs:
215215
- name: Generate solution
216216
shell: pwsh
217217
working-directory: ./
218-
run: ./common/GenerateAllSolution.ps1 -UseDiagnostics
218+
run: ./common/GenerateAllSolution.ps1
219219

220220
- name: Install ninja for WASM native dependencies
221221
run: sudo apt-get install ninja-build
@@ -228,9 +228,9 @@ jobs:
228228

229229
# TODO: Do we want to run tests here? Can we do that on linux easily?
230230

231-
- name: Artifact - Slngen Logs
232-
uses: actions/upload-artifact@v3
233-
if: success() || failure()
234-
with:
235-
name: slngen-logs
236-
path: ./**/slngen.*log
231+
#- name: Artifact - Slngen Logs
232+
# uses: actions/upload-artifact@v3
233+
# if: success() || failure()
234+
# with:
235+
# name: slngen-logs
236+
# path: ./**/slngen.*log

0 commit comments

Comments
 (0)