Skip to content

Commit 48fc84d

Browse files
Arlodotexemichael-hawker
authored andcommitted
Fix sign artifact mismatch in GitHub Actions workflow
The sign job was failing with 'Artifact not found for name: nuget-list-2' because the Labs-Windows workflow was missing the upload step for the nuget-list artifact that the sign job expected to download. Changes made: - Added missing SignClientFileList.txt containing '**/CommunityToolkit.*' - Added upload step in package job to create nuget-list-{winui} artifacts - Fixed conditional for signed package upload artifacts This ensures both required artifacts are uploaded by the package job: 1. nuget-packages-winui{N} (the actual .nupkg files) 2. nuget-list-{N} (SignClientFileList.txt for signing) The sign job should now successfully download both artifacts to proceed with signing.
1 parent b6e67a0 commit 48fc84d

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
**/CommunityToolkit.*

.github/workflows/build.yml

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -326,6 +326,15 @@ jobs:
326326
--username dummy --password ${{ secrets.DEVOPS_PACKAGE_PUSH_TOKEN }}
327327
dotnet nuget push "**/*.nupkg" --api-key dummy --source LabsFeed --skip-duplicate
328328
329+
- name: Upload Package List
330+
uses: actions/upload-artifact@v4
331+
if: ${{ (env.IS_PR == 'false' || github.event.pull_request.head.repo.full_name != github.repository) && env.HAS_BUILDABLE_COMPONENTS == 'true' }}
332+
with:
333+
name: nuget-list-${{ matrix.winui }}
334+
if-no-files-found: error
335+
path: |
336+
${{ github.workspace }}/.github/workflows/SignClientFileList.txt
337+
329338
# if we're not doing a PR build (or it's a PR from a fork) then we upload our packages so we can sign as a separate job or have available to test.
330339
- name: Upload Packages as Artifacts
331340
uses: actions/upload-artifact@v4
@@ -402,7 +411,7 @@ jobs:
402411
403412
- name: Upload Signed Packages as Artifacts (for release)
404413
uses: actions/upload-artifact@v4
405-
if: ${{ env.IS_RELEASE == 'true' }}
414+
if: ${{ startsWith(github.ref, 'refs/heads/rel/') || inputs.is_scheduled }}
406415
with:
407416
name: signed-nuget-packages-${{ matrix.winui }}
408417
if-no-files-found: error

0 commit comments

Comments
 (0)