Hide Discussion/Issue GitHub buttons if the ProjectUrl isn't set for navigation

Author: michael-hawker

common/CommunityToolkit.Labs.Shared/Renderers/ToolkitDocumentationRenderer.xaml

@@ -113,7 +113,9 @@
                   Margin="0,16,0,0"
                   ColumnSpacing="8">
 
-                <StackPanel Orientation="Horizontal"
+                <StackPanel x:Name="ButtonPanel"
+                            x:Load="{x:Bind renderer:ToolkitDocumentationRenderer.IsProjectPathValid()}"
+                            Orientation="Horizontal"
                             Spacing="8">
                     <Button Visibility="{x:Bind renderer:ToolkitDocumentationRenderer.IsIdValid(Metadata.DiscussionId), Mode=OneWay}">
                         <StackPanel Orientation="Horizontal">

common/CommunityToolkit.Labs.Shared/Renderers/ToolkitDocumentationRenderer.xaml.cs

@@ -15,6 +15,8 @@
 #endif
 #endif
 
+#nullable enable
+
 namespace CommunityToolkit.Labs.Shared.Renderers;
 
 /// <summary>
@@ -34,8 +36,6 @@ public ToolkitDocumentationRenderer()
             ProjectUrl = Assembly.GetExecutingAssembly()?.GetCustomAttribute<CommunityToolkit.Attributes.PackageProjectUrlAttribute>()?.PackageProjectUrl;
         }
 
-        // TODO: If ProjectUrl is null should we log an error?
-
         this.InitializeComponent();
     }
 
@@ -223,11 +223,13 @@ private async void MarkdownTextBlock_LinkClicked(object sender, LinkClickedEvent
     }
 #endif
 
-    public static Uri ToGitHubUri(string path, int id) => new Uri($"{ProjectUrl}/{path}/{id}");
+    public static Uri? ToGitHubUri(string path, int id) => IsProjectPathValid() ? new Uri($"{ProjectUrl}/{path}/{id}") : null;
 
     public static Visibility IsIdValid(int id) => id switch
     {
         <= 0 => Visibility.Collapsed,
         _ => Visibility.Visible,
     };
+
+    public static bool IsProjectPathValid() => !string.IsNullOrWhiteSpace(ProjectUrl);
 }

common/Labs.Head.props

@@ -113,9 +113,10 @@
         <_Parameter1>CommitHash</_Parameter1>
         <_Parameter2>$(SourceRevisionId)</_Parameter2>
       </AssemblyAttributes>
-      <AssemblyAttributes Include="CommunityToolkit.Attributes.PackageProjectUrlAttribute">
+      <AssemblyAttributes Include="CommunityToolkit.Attributes.PackageProjectUrlAttribute" Condition="'$(PackageProjectUrl)' != ''">
         <_Parameter1>$(PackageProjectUrl)</_Parameter1>
       </AssemblyAttributes>
+      <Warning Text="The PackageProjectUrl property was not set." Condition="'$(PackageProjectUrl)' == ''" />
     </ItemGroup>
 
     <!-- Extra attributes specific to platforms -->