Remove workaround for unit test runner

Author: Sergio0694

components/DependencyPropertyGenerator/CommunityToolkit.DependencyPropertyGenerator.CodeFixers/UseGeneratedDependencyPropertyOnManualPropertyCodeFixer.cs

@@ -536,14 +536,6 @@ bool TryExtractAdditionalLocation(AdditionalLocationKind currentLocationKind, [N
             // Ensure the current kind is present and that we can extract an additional location
             if (!additionalLocationKind.HasFlag(currentLocationKind))
             {
-                // Special case for the unit test runner. If we have 3 diagnostics (see details on the contract in the analyzer),
-                // it means we're running in the test runner, which does not remove 'None' diagnostics. In this case, we need to
-                // increment the current index, or otherwise we'll read incorrect locations after this one.
-                if (diagnostic.AdditionalLocations.Count == 3)
-                {
-                    currentLocationIndex++;
-                }
-
                 fieldLocation = null;
 
                 return false;
@@ -552,16 +544,6 @@ bool TryExtractAdditionalLocation(AdditionalLocationKind currentLocationKind, [N
             // Parse the additional location
             fieldLocation = diagnostic.AdditionalLocations[currentLocationIndex++];
 
-            // Special case: if the location is 'None', we should ignore it. This is because while the location is
-            // available when running tests, it will be removed when running in the IDE, because the serialization
-            // logic that Roslyn uses will filter out all 'None' locations. This step is needed to match that logic.
-            if (fieldLocation == Location.None)
-            {
-                fieldLocation = null;
-
-                return false;
-            }
-
             return true;
         }
 

components/DependencyPropertyGenerator/CommunityToolkit.DependencyPropertyGenerator.SourceGenerators/Diagnostics/Analyzers/UseGeneratedDependencyPropertyOnManualPropertyAnalyzer.cs

@@ -597,24 +597,25 @@ void HandleSetAccessor(IPropertySymbol propertySymbol, PropertyFlags propertyFla
                             //   1) The field location (this is always present)
                             //   2) The location of the 'typeof(...)' expression for the property type, if present
                             //   3) The location of the default value expression, if it should be directly carried over
-                            Location[] additionalLocations =
+                            Location?[] additionalLocations =
                             [
                                 fieldLocation,
-                                fieldFlags.PropertyTypeExpressionLocation ?? Location.None,
-                                fieldFlags.DefaultValueExpressionLocation ?? Location.None
+                                fieldFlags.PropertyTypeExpressionLocation,
+                                fieldFlags.DefaultValueExpressionLocation
                             ];
 
                             // Track the available locations, so we can extract them back. We cannot rely on the length
-                            // of the supplied array, because Roslyn will remove all 'None' locations from the array.
+                            // of the supplied array, because Roslyn will remove all 'None' locations from the array. To
+                            // match this behavior in tests too, we'll just filter out all 'null' elements below as well.
                             AdditionalLocationKind additionalLocationKind =
                                 AdditionalLocationKind.FieldLocation |
-                                (additionalLocations[1] != Location.None ? AdditionalLocationKind.PropertyTypeExpressionLocation : 0) |
-                                (additionalLocations[2] != Location.None ? AdditionalLocationKind.DefaultValueExpressionLocation : 0);
+                                (additionalLocations[1] is not null ? AdditionalLocationKind.PropertyTypeExpressionLocation : 0) |
+                                (additionalLocations[2] is not null ? AdditionalLocationKind.DefaultValueExpressionLocation : 0);
 
                             context.ReportDiagnostic(Diagnostic.Create(
                                 UseGeneratedDependencyPropertyForManualProperty,
                                 pair.Key.Locations.FirstOrDefault(),
-                                additionalLocations,
+                                additionalLocations.OfType<Location>(),
                                 ImmutableDictionary.Create<string, string?>()
                                     .Add(DefaultValuePropertyName, fieldFlags.DefaultValue?.ToString())
                                     .Add(DefaultValueTypeReferenceIdPropertyName, fieldFlags.DefaultValueTypeReferenceId)