Fix codegen for 'bool' default values

Author: Sergio0694

components/DependencyPropertyGenerator/CommunityToolkit.DependencyPropertyGenerator.SourceGenerators/Extensions/IOperationExtensions.cs

@@ -36,13 +36,14 @@ public static bool IsConstantValueDefault(this IOperation operation)
             return true;
         }
 
-        // Manually match for known primitive types
+        // Manually match for known primitive types (this should be kept in sync with 'IsWellKnownWinRTProjectedValueType')
         return (operation.Type.SpecialType, operation.ConstantValue.Value) switch
         {
             (SpecialType.System_Byte, default(byte)) or
-            (SpecialType.System_Char, default(char)) or
+            (SpecialType.System_SByte, default(sbyte)) or
             (SpecialType.System_Int16, default(short)) or
             (SpecialType.System_UInt16, default(ushort)) or
+            (SpecialType.System_Char, default(char)) or
             (SpecialType.System_Int32, default(int)) or
             (SpecialType.System_UInt32, default(uint)) or
             (SpecialType.System_Int64, default(long)) or

components/DependencyPropertyGenerator/CommunityToolkit.DependencyPropertyGenerator.SourceGenerators/Extensions/WinRTExtensions.cs

@@ -57,15 +57,16 @@ public static bool IsWellKnownWinRTProjectedValueType(this ITypeSymbol symbol, b
 
         // Lastly, special case the well known primitive types
         if (symbol.SpecialType is
-            SpecialType.System_Int32 or
             SpecialType.System_Byte or
             SpecialType.System_SByte or
             SpecialType.System_Int16 or
             SpecialType.System_UInt16 or
+            SpecialType.System_Char or
+            SpecialType.System_Int32 or
             SpecialType.System_UInt32 or
             SpecialType.System_Int64 or
             SpecialType.System_UInt64 or
-            SpecialType.System_Char or
+            SpecialType.System_Boolean or
             SpecialType.System_Single or
             SpecialType.System_Double)
         {

components/DependencyPropertyGenerator/CommunityToolkit.DependencyPropertyGenerator.Tests/Test_DependencyPropertyGenerator.cs

@@ -4282,4 +4282,120 @@ public partial string? Name
 
         CSharpGeneratorTest<DependencyPropertyGenerator>.VerifySources(source, ("MyNamespace.MyControl.g.cs", result), languageVersion: LanguageVersion.Preview);
     }
+
+    [TestMethod]
+    public void SingleProperty_Bool_WithNoCaching()
+    {
+        const string source = """
+            using CommunityToolkit.WinUI;
+            using Windows.UI.Xaml;
+
+            namespace MyNamespace;
+
+            public partial class MyControl : DependencyObject
+            {
+                [GeneratedDependencyProperty]
+                public partial bool IsSelected { get; set; }
+            }
+            """;
+
+        const string result = """
+            // <auto-generated/>
+            #pragma warning disable
+            #nullable enable
+
+            namespace MyNamespace
+            {
+                /// <inheritdoc cref="MyControl"/>
+                partial class MyControl
+                {
+                    /// <summary>
+                    /// The backing <see cref="global::Windows.UI.Xaml.DependencyProperty"/> instance for <see cref="IsSelected"/>.
+                    /// </summary>
+                    [global::System.CodeDom.Compiler.GeneratedCode("CommunityToolkit.WinUI.DependencyPropertyGenerator", <ASSEMBLY_VERSION>)]
+                    public static readonly global::Windows.UI.Xaml.DependencyProperty IsSelectedProperty = global::Windows.UI.Xaml.DependencyProperty.Register(
+                        name: "IsSelected",
+                        propertyType: typeof(bool),
+                        ownerType: typeof(MyControl),
+                        typeMetadata: null);
+
+                    /// <inheritdoc/>
+                    [global::System.CodeDom.Compiler.GeneratedCode("CommunityToolkit.WinUI.DependencyPropertyGenerator", <ASSEMBLY_VERSION>)]
+                    [global::System.Diagnostics.DebuggerNonUserCode]
+                    [global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
+                    public partial bool IsSelected
+                    {
+                        get
+                        {
+                            object? __boxedValue = GetValue(IsSelectedProperty);
+
+                            OnIsSelectedGet(ref __boxedValue);
+
+                            bool __unboxedValue = (bool)__boxedValue;
+
+                            OnIsSelectedGet(ref __unboxedValue);
+
+                            return __unboxedValue;
+                        }
+                        set
+                        {
+                            OnIsSelectedSet(ref value);
+
+                            object? __boxedValue = value;
+
+                            OnIsSelectedSet(ref __boxedValue);
+
+                            SetValue(IsSelectedProperty, __boxedValue);
+
+                            OnIsSelectedChanged(value);
+                        }
+                    }
+
+                    /// <summary>Executes the logic for when the <see langword="get"/> accessor <see cref="IsSelected"/> is invoked</summary>
+                    /// <param name="propertyValue">The raw property value that has been retrieved from <see cref="IsSelectedProperty"/>.</param>
+                    /// <remarks>This method is invoked on the boxed value retrieved via <see cref="GetValue"/> on <see cref="IsSelectedProperty"/>.</remarks>
+                    [global::System.CodeDom.Compiler.GeneratedCode("CommunityToolkit.WinUI.DependencyPropertyGenerator", <ASSEMBLY_VERSION>)]
+                    partial void OnIsSelectedGet(ref object propertyValue);
+
+                    /// <summary>Executes the logic for when the <see langword="get"/> accessor <see cref="IsSelected"/> is invoked</summary>
+                    /// <param name="propertyValue">The unboxed property value that has been retrieved from <see cref="IsSelectedProperty"/>.</param>
+                    /// <remarks>This method is invoked on the unboxed value retrieved via <see cref="GetValue"/> on <see cref="IsSelectedProperty"/>.</remarks>
+                    [global::System.CodeDom.Compiler.GeneratedCode("CommunityToolkit.WinUI.DependencyPropertyGenerator", <ASSEMBLY_VERSION>)]
+                    partial void OnIsSelectedGet(ref bool propertyValue);
+
+                    /// <summary>Executes the logic for when the <see langword="set"/> accessor <see cref="IsSelected"/> is invoked</summary>
+                    /// <param name="propertyValue">The boxed property value that has been produced before assigning to <see cref="IsSelectedProperty"/>.</param>
+                    /// <remarks>This method is invoked on the boxed value that is about to be passed to <see cref="SetValue"/> on <see cref="IsSelectedProperty"/>.</remarks>
+                    [global::System.CodeDom.Compiler.GeneratedCode("CommunityToolkit.WinUI.DependencyPropertyGenerator", <ASSEMBLY_VERSION>)]
+                    partial void OnIsSelectedSet(ref object propertyValue);
+
+                    /// <summary>Executes the logic for when the <see langword="set"/> accessor <see cref="IsSelected"/> is invoked</summary>
+                    /// <param name="propertyValue">The property value that is being assigned to <see cref="IsSelected"/>.</param>
+                    /// <remarks>This method is invoked on the raw value being assigned to <see cref="IsSelected"/>, before <see cref="SetValue"/> is used.</remarks>
+                    [global::System.CodeDom.Compiler.GeneratedCode("CommunityToolkit.WinUI.DependencyPropertyGenerator", <ASSEMBLY_VERSION>)]
+                    partial void OnIsSelectedSet(ref bool propertyValue);
+
+                    /// <summary>Executes the logic for when <see cref="IsSelected"/> has just changed.</summary>
+                    /// <param name="value">The new property value that has been set.</param>
+                    /// <remarks>This method is invoked right after the value of <see cref="IsSelected"/> is changed.</remarks>
+                    [global::System.CodeDom.Compiler.GeneratedCode("CommunityToolkit.WinUI.DependencyPropertyGenerator", <ASSEMBLY_VERSION>)]
+                    partial void OnIsSelectedChanged(bool newValue);
+
+                    /// <summary>Executes the logic for when <see cref="IsSelected"/> has just changed.</summary>
+                    /// <param name="e">Event data that is issued by any event that tracks changes to the effective value of this property.</param>
+                    /// <remarks>This method is invoked by the <see cref="global::Windows.UI.Xaml.DependencyProperty"/> infrastructure, after the value of <see cref="IsSelected"/> is changed.</remarks>
+                    [global::System.CodeDom.Compiler.GeneratedCode("CommunityToolkit.WinUI.DependencyPropertyGenerator", <ASSEMBLY_VERSION>)]
+                    partial void OnIsSelectedPropertyChanged(global::Windows.UI.Xaml.DependencyPropertyChangedEventArgs e);
+
+                    /// <summary>Executes the logic for when any dependency property has just changed.</summary>
+                    /// <param name="e">Event data that is issued by any event that tracks changes to the effective value of this property.</param>
+                    /// <remarks>This method is invoked by the <see cref="global::Windows.UI.Xaml.DependencyProperty"/> infrastructure, after the value of any dependency property has just changed.</remarks>
+                    [global::System.CodeDom.Compiler.GeneratedCode("CommunityToolkit.WinUI.DependencyPropertyGenerator", <ASSEMBLY_VERSION>)]
+                    partial void OnPropertyChanged(global::Windows.UI.Xaml.DependencyPropertyChangedEventArgs e);
+                }
+            }
+            """;
+
+        CSharpGeneratorTest<DependencyPropertyGenerator>.VerifySources(source, ("MyNamespace.MyControl.g.cs", result), languageVersion: LanguageVersion.Preview);
+    }
 }