Skip to content

Commit a2f339c

Browse files
committed
Fix .targets again, add basic test
1 parent ea71909 commit a2f339c

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

components/DependencyPropertyGenerator/CommunityToolkit.DependencyPropertyGenerator.Tests/CommunityToolkit.DependencyPropertyGenerator.Tests.csproj

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,4 +40,7 @@
4040
Link="EmbeddedResources\GeneratedDependencyPropertyAttribute.cs"
4141
LogicalName="GeneratedDependencyPropertyAttribute.g.cs" />
4242
</ItemGroup>
43+
44+
<!-- Import the .targets from the package, just as a sanity check to verify they're not invalid -->
45+
<Import Project="..\src\CommunityToolkit.WinUI.DependencyPropertyGenerator.targets" />
4346
</Project>

components/DependencyPropertyGenerator/src/CommunityToolkit.WinUI.DependencyPropertyGenerator.targets

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@
5050
<!-- Check the Roslyn version and warn if it's not high enough (we don't need to remove the analyzers, as they're leveraging multi-targeting) -->
5151
<Target Name="CommunityToolkitGeneratedDependencyPropertyWarnForRoslynVersionNotHighEnough"
5252
Condition="'$(CSharpCoreTargetsPath)' != ''"
53-
AfterTargets="ResolvePackageDependenciesForBuild;ResolveNuGetPackageAssets"
54-
DependsOnTargets="CommunityToolkitGeneratedDependencyPropertyGatherAnalyzers">
53+
DependsOnTargets="ResolveAssemblyReferences"
54+
BeforeTargets="CoreCompile">
5555

5656
<!--
5757
Use the CSharpCoreTargetsPath property to find the version of the compiler we are using. This is the same mechanism

0 commit comments

Comments
 (0)