Analyze more cases even with invalid field declarations

Author: Sergio0694

components/DependencyPropertyGenerator/CommunityToolkit.DependencyPropertyGenerator.SourceGenerators/Diagnostics/Analyzers/UseGeneratedDependencyPropertyOnManualPropertyAnalyzer.cs

@@ -191,16 +191,16 @@ public override void Initialize(AnalysisContext context)
                     }
                     else if (memberSymbol is IFieldSymbol
                             {
-                                DeclaredAccessibility: Accessibility.Public,
                                 IsStatic: true,
-                                IsReadOnly: true,
                                 IsFixedSizeBuffer: false,
                                 IsRequired: false,
                                 Type.IsReferenceType: true,
                                 IsVolatile: false
                             } fieldSymbol)
                     {
-                        // We only care about fields that are 'DependencyProperty'
+                        // We only care about fields that are 'DependencyProperty'. Note that we should also be checking the declared
+                        // accessibility here and the fact the field is readonly, but we delay that in the initialization callback.
+                        // This is done so that we can still emit more diagnostics when analyzing the symbol completes below.
                         if (!SymbolEqualityComparer.Default.Equals(dependencyPropertySymbol, fieldSymbol.Type))
                         {
                             continue;
@@ -395,6 +395,16 @@ void HandleSetAccessor(IPropertySymbol propertySymbol, PropertyFlags propertyFla
                         fieldFlags.FieldSymbol = fieldSymbol;
                     }
 
+                    // Do the accessibility and readonly check here, to still enable diagnostics at the end in more scenarios.
+                    // If the field is invalid, just mark it as such, but continue executing the rest of the analysis here.
+                    if (fieldSymbol is { DeclaredAccessibility: not Accessibility.Public } or { IsReadOnly: false })
+                    {
+                        if (fieldFlags is not null)
+                        {
+                            fieldFlags.HasAnyDiagnostics = true;
+                        }
+                    }
+
                     // Additional diagnostic #1: the dependency property field name should have the "Property" suffix
                     if (!fieldSymbol.Name.EndsWith("Property"))
                     {

components/DependencyPropertyGenerator/CommunityToolkit.DependencyPropertyGenerator.Tests/Test_Analyzers.cs

@@ -3226,6 +3226,64 @@ public void Dispose()
         await CSharpAnalyzerTest<UseGeneratedDependencyPropertyOnManualPropertyAnalyzer>.VerifyAnalyzerAsync(source, LanguageVersion.CSharp13);
     }
 
+    [TestMethod]
+    [DataRow("private static readonly")]
+    [DataRow("public static")]
+    public async Task UseGeneratedDependencyPropertyOnManualPropertyAnalyzer_InvalidFieldDeclaration_DoesNotWarn(string fieldDeclaration)
+    {
+        string source = $$"""
+            using Windows.UI.Xaml;
+            
+            namespace MyApp;
+
+            public partial class MyObject : DependencyObject
+            {
+                {{fieldDeclaration}} DependencyProperty NameProperty = DependencyProperty.Register(
+                    name: "Name",
+                    propertyType: typeof(string),
+                    ownerType: typeof(MyObject),
+                    typeMetadata: null);
+
+                public string? Name
+                {
+                    get => (string?)GetValue(NameProperty);
+                    set => SetValue(NameProperty, value);
+                }
+            }
+            """;
+
+        await CSharpAnalyzerTest<UseGeneratedDependencyPropertyOnManualPropertyAnalyzer>.VerifyAnalyzerAsync(source, LanguageVersion.CSharp13);
+    }
+
+    [TestMethod]
+    [DataRow("private static readonly")]
+    [DataRow("public static")]
+    public async Task UseGeneratedDependencyPropertyOnManualPropertyAnalyzer_InvalidFieldDeclaration_EmitsAdditionalDiagnosticsToo_DoesNotWarn(string fieldDeclaration)
+    {
+        string source = $$"""
+            using Windows.UI.Xaml;
+            
+            namespace MyApp;
+
+            public partial class MyObject : DependencyObject
+            {
+                {{fieldDeclaration}} DependencyProperty NameProperty = DependencyProperty.Register(
+                    {|WCTDPG0027:{|WCTDPG0028:name: "Name2"|}|},
+                    {|WCTDPG0030:propertyType: typeof(int?)|},
+                    ownerType: typeof(MyObject),
+                    typeMetadata: null);
+
+                public string? Name
+                {
+                    get => (string?)GetValue(NameProperty);
+                    set => SetValue(NameProperty, value);
+                }
+            }
+            """;
+
+        await CSharpAnalyzerTest<UseGeneratedDependencyPropertyOnManualPropertyAnalyzer>.VerifyAnalyzerAsync(source, LanguageVersion.CSharp13);
+    }
+
     [TestMethod]
     public async Task InvalidPropertyForwardedAttributeDeclarationAnalyzer_NoDependencyPropertyAttribute_DoesNotWarn()
     {