More renaming

Co-Authored-By: Justin Liu <[email protected]>

Author: niels9001

components/Shimmer/samples/Shimmer.md

@@ -12,6 +12,6 @@ issue-id: 0
 ---
 # Shimmer
 
-The Shimmer control can be used to communicate to the user a certain UI element is fetching data or is loading. The `AnimationDurationInMilliseconds` can be set to change the time in between fades.
+The Shimmer control can be used to communicate to the user a certain UI element is fetching data or is loading. The `Duration` can be set to change the time in between fades.
 
 > [!SAMPLE ShimmerSample]

components/Shimmer/src/Shimmer/Shimmer.Properties.cs

@@ -9,19 +9,19 @@ public partial class Shimmer : Control
         nameof(Duration), typeof(TimeSpan), typeof(Shimmer), new PropertyMetadata(TimeSpan.FromMilliseconds(1600), (s, e) =>
         {
             var self = (Shimmer)s;
-            if (self.IsAnimating)
+            if (self.IsActive)
             {
                 self.TryStartAnimation();
             }
         }));
 
-    public static readonly DependencyProperty IsAnimatingProperty = DependencyProperty.Register(
-        nameof(IsAnimating), typeof(bool), typeof(Shimmer), new PropertyMetadata(true, (s, e) =>
+    public static readonly DependencyProperty IsActiveProperty = DependencyProperty.Register(
+        nameof(IsActive), typeof(bool), typeof(Shimmer), new PropertyMetadata(true, (s, e) =>
         {
             var self = (Shimmer)s;
-            var isAnimating = (bool)e.NewValue;
+            var isActive = (bool)e.NewValue;
 
-            if (isAnimating)
+            if (isActive)
             {
                 self.TryStartAnimation();
             }
@@ -37,9 +37,9 @@ public TimeSpan Duration
         set => SetValue(DurationProperty, value);
     }
 
-    public bool IsAnimating
+    public bool IsActive
     {
-        get => (bool)GetValue(IsAnimatingProperty);
-        set => SetValue(IsAnimatingProperty, value);
+        get => (bool)GetValue(IsActiveProperty);
+        set => SetValue(IsActiveProperty, value);
     }
 }

components/Shimmer/src/Shimmer/Shimmer.cs

@@ -86,9 +86,7 @@ private void OnUnloaded(object sender, RoutedEventArgs e)
 
         if (_initialized && _shape != null)
         {
-#pragma warning disable CS8625 // Cannot convert null literal to non-nullable reference type.
             ElementCompositionPreview.SetElementChildVisual(_shape, null);
-#pragma warning restore CS8625 // Cannot convert null literal to non-nullable reference type.
 
             _rectangleGeometry.Dispose();
             _shapeVisual.Dispose();