Add support for modern .NET to AppServices library #576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
commented
Oct 11, 2024
Arlodotexe
requested changes
Oct 11, 2024
Member
Arlodotexe
left a comment
Arlodotexe
left a comment
There was a problem hiding this comment.
Broadly, we're still not quite ready to ship modern .NET for UWP in the Toolkit. AppServices is one component where WinUI 2 with modern .NET isn't needed, but TFM support is added via our tooling and applies to all components in the solution.
If you only need NuGet packages, you can build locally and output NuGet packages with our component build script:
.\tooling\Build-Toolkit-Components.ps1 -MultiTargets uwp -winui 2 -Components AppServices -PreviewVersion local -NupkgOutput ./some/output/path -ReleaseWhile the code changes to AppServices here seem good, we need to make sure tooling is sorted for all components before we try to enable this and merge it in.
Sergio0694
force-pushed
the
user/sergiopedri/uwp-net9-appservices
branch
from
5fc22ee to
d423cfe
Compare
Arlodotexe
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for .NET 8 to the AppServices library (including UWP on .NET 9).