From 305af8349fa19c0a586165b75213eea68f3af69f Mon Sep 17 00:00:00 2001 From: Arlo Date: Fri, 24 Jan 2025 11:40:27 -0600 Subject: [PATCH 1/5] Update uno.check version to 1.27.4 and tooling submodule reference --- .config/dotnet-tools.json | 2 +- tooling | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json index 3b3d280a3..69c13801e 100644 --- a/.config/dotnet-tools.json +++ b/.config/dotnet-tools.json @@ -3,7 +3,7 @@ "isRoot": true, "tools": { "uno.check": { - "version": "1.20.2", + "version": "1.27.4", "commands": [ "uno-check" ] diff --git a/tooling b/tooling index 725c1b575..81a7ceed3 160000 --- a/tooling +++ b/tooling @@ -1 +1 @@ -Subproject commit 725c1b575a06ab5c68ea457cfaac15f7d2f638e7 +Subproject commit 81a7ceed33be91b35dbf541b166de7e2d382494c From ba23199b2ada39bce4e274942cdcd47f6de263c0 Mon Sep 17 00:00:00 2001 From: Arlo Date: Fri, 24 Jan 2025 13:41:59 -0600 Subject: [PATCH 2/5] Treat CS1591 and CS1574 as warnings, not errors --- Directory.Build.props | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Directory.Build.props b/Directory.Build.props index 72e05671d..ebe4b1e45 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -15,7 +15,7 @@ $(NoWarn);Uno0001 - NU1901;NU1902;NU1903;NU1904 + NU1901;NU1902;NU1903;NU1904;CS1591;CS1574 From ac57120d1b199f680612abf14f2e10e2af9c005a Mon Sep 17 00:00:00 2001 From: Arlo Date: Fri, 24 Jan 2025 13:42:05 -0600 Subject: [PATCH 3/5] Update tooling pointer --- tooling | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tooling b/tooling index 81a7ceed3..be7217854 160000 --- a/tooling +++ b/tooling @@ -1 +1 @@ -Subproject commit 81a7ceed33be91b35dbf541b166de7e2d382494c +Subproject commit be721785480efc04b80c9c57cfe9446b849ae4ac From 47a3062555a6c98c5c0421807d0d7b769f73a179 Mon Sep 17 00:00:00 2001 From: Arlo Date: Fri, 24 Jan 2025 16:56:50 -0600 Subject: [PATCH 4/5] Refactor warnings handling and update documentation comments --- Directory.Build.props | 8 +++++++- components/MarkdownTextBlock/src/TextElements/MyList.cs | 2 +- components/RivePlayer/src/StateMachineInputCollection.cs | 2 +- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/Directory.Build.props b/Directory.Build.props index ebe4b1e45..7f02eacdb 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -15,7 +15,13 @@ $(NoWarn);Uno0001 - NU1901;NU1902;NU1903;NU1904;CS1591;CS1574 + NU1901;NU1902;NU1903;NU1904; + + + $(WarningsNotAsErrors);CS1591;CS1574; + + + $(WarningsNotAsErrors);CS0419;CS1570; diff --git a/components/MarkdownTextBlock/src/TextElements/MyList.cs b/components/MarkdownTextBlock/src/TextElements/MyList.cs index 46b15e1a8..8fcd67dfa 100644 --- a/components/MarkdownTextBlock/src/TextElements/MyList.cs +++ b/components/MarkdownTextBlock/src/TextElements/MyList.cs @@ -96,7 +96,7 @@ public void AddChild(IAddChild child) private BulletType ToBulletType(char bullet) { - /// Gets or sets the type of the bullet (e.g: '1', 'a', 'A', 'i', 'I'). + // Gets or sets the type of the bullet (e.g: '1', 'a', 'A', 'i', 'I'). switch (bullet) { case '1': diff --git a/components/RivePlayer/src/StateMachineInputCollection.cs b/components/RivePlayer/src/StateMachineInputCollection.cs index bbd93c229..eac9f8bb7 100644 --- a/components/RivePlayer/src/StateMachineInputCollection.cs +++ b/components/RivePlayer/src/StateMachineInputCollection.cs @@ -11,7 +11,7 @@ namespace CommunityToolkit.Labs.WinUI.Rive; /// /// /// -/// +/// /// /// /// From 025a07717e0777b782e2544a5c16cc1c467846ac Mon Sep 17 00:00:00 2001 From: Arlo Date: Fri, 24 Jan 2025 19:53:47 -0600 Subject: [PATCH 5/5] Update tooling pointer to latest main --- tooling | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tooling b/tooling index be7217854..1ac9b8094 160000 --- a/tooling +++ b/tooling @@ -1 +1 @@ -Subproject commit be721785480efc04b80c9c57cfe9446b849ae4ac +Subproject commit 1ac9b8094bc263c29f7a883b564371eecb8ff152