Skip to content

Minor '[GeneratedDependencyProperty]' fixes #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Minor '[GeneratedDependencyProperty]' fixes #632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edd1d4f
Fix XML docs
Sergio0694 Jan 28, 2025
e8f26b0
Fix mixed callbacks codegen
Sergio0694 Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...olkit.DependencyPropertyGenerator.SourceGenerators/DependencyPropertyGenerator.Execute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1053,7 +1053,7 @@ public static void WriteAdditionalTypes(EquatableArray<DependencyPropertyInfo> p
if (propertyInfo.IsSharedPropertyChangedCallbackImplemented)
{
writer.IncreaseIndent();
writer.WriteLine($"PropertyChangedUnsafeAccessors.On{propertyInfo.PropertyName}PropertyChanged(__this, e);");
writer.WriteLine("PropertyChangedUnsafeAccessors.OnPropertyChanged(__this, e);");
writer.DecreaseIndent();
}

Expand Down
8 changes: 4 additions & 4 deletions ...or/CommunityToolkit.DependencyPropertyGenerator.Tests/Test_DependencyPropertyGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1454,7 +1454,7 @@ private void OnNumberPropertyChanged(DependencyObject d, DependencyPropertyChang
global::MyNamespace.MyControl __this = (global::MyNamespace.MyControl)d;

PropertyChangedUnsafeAccessors.OnNumberPropertyChanged(__this, e);
PropertyChangedUnsafeAccessors.OnNumberPropertyChanged(__this, e);
PropertyChangedUnsafeAccessors.OnPropertyChanged(__this, e);
}
}

Expand Down Expand Up @@ -3272,7 +3272,7 @@ private void OnFirstNamePropertyChanged(DependencyObject d, DependencyPropertyCh
global::MyNamespace.MyControl __this = (global::MyNamespace.MyControl)d;

PropertyChangedUnsafeAccessors.OnFirstNamePropertyChanged(__this, e);
PropertyChangedUnsafeAccessors.OnFirstNamePropertyChanged(__this, e);
PropertyChangedUnsafeAccessors.OnPropertyChanged(__this, e);
}

/// <inheritdoc cref="cref="global::MyNamespace.MyControl.OnPropertyChanged""/>
Expand Down Expand Up @@ -3555,7 +3555,7 @@ private void OnFirstNamePropertyChanged(DependencyObject d, DependencyPropertyCh
global::MyNamespace.MyControl __this = (global::MyNamespace.MyControl)d;

PropertyChangedUnsafeAccessors.OnFirstNamePropertyChanged(__this, e);
PropertyChangedUnsafeAccessors.OnFirstNamePropertyChanged(__this, e);
PropertyChangedUnsafeAccessors.OnPropertyChanged(__this, e);
}

/// <inheritdoc cref="cref="global::MyNamespace.MyControl.OnPropertyChanged""/>
Expand All @@ -3564,7 +3564,7 @@ private void OnLastNamePropertyChanged(DependencyObject d, DependencyPropertyCha
global::MyNamespace.MyControl __this = (global::MyNamespace.MyControl)d;

PropertyChangedUnsafeAccessors.OnLastNamePropertyChanged(__this, e);
PropertyChangedUnsafeAccessors.OnLastNamePropertyChanged(__this, e);
PropertyChangedUnsafeAccessors.OnPropertyChanged(__this, e);
}
}

Expand Down
2 changes: 1 addition & 1 deletion components/DependencyPropertyGenerator/src/GeneratedDependencyProperty.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public sealed class GeneratedDependencyProperty
{
/// <summary><inheritdoc cref="DependencyProperty.UnsetValue"/></summary>
/// <remarks>
/// This constant is only meant to be used in assignments to <see cref="DefaultValue"/> (because <see cref="DependencyProperty.UnsetValue"/>
/// This constant is only meant to be used in assignments to <see cref="GeneratedDependencyPropertyAttribute.DefaultValue"/> (because <see cref="DependencyProperty.UnsetValue"/>
/// cannot be used in that context, as it is not a constant, but rather a static field). Using this constant in other scenarios is undefined behavior.
/// </remarks>
public const object UnsetValue = null!;
Expand Down
Loading