-
Notifications
You must be signed in to change notification settings - Fork 81
Bumping version number and adding packageid #719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks @niels9001! FYI @Arlodotexe looks like CI is failing due to GetChangedComponents (multiple here) Did we want to update the namespaces too? e.g.
Or open another ticket to track that and update separately? |
It would be good to align them in a single sweep or back-to-back using a follow-up PR. |
39e46f5 to
18f96b6
Compare
| <ToolkitComponentName>TitleBar</ToolkitComponentName> | ||
| <Description>This package contains TitleBar.</Description> | ||
| <Version>0.0.1</Version> | ||
| <Version>0.0.2</Version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Arlodotexe do we still need version here? This should just be handled automatically now, eh?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michael-hawker We have automated versioning via https://github.com/CommunityToolkit/Tooling-Windows-Submodule/blob/786cf7bea168a37dbdeea2cf9acabf9d1cd35793/ToolkitComponent.SourceProject.props#L16, if it's set manually like this then it overrides the default computed version value.
Tooling supports both, it depends on our preference for this particular package.
michael-hawker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@niels9001 going to approve so we can merge this in, but could be good to do the namespace one too if you have an extra min. I may check back later, as if we can merge it soon it may make the CI that should kick-off overnight. 🤞
Closes: #661