Skip to content

Conversation

@niels9001
Copy link
Collaborator

@niels9001 niels9001 commented Aug 26, 2025

Closes: #661

@michael-hawker
Copy link
Member

Thanks @niels9001!

FYI @Arlodotexe looks like CI is failing due to GetChangedComponents (multiple here)

Did we want to update the namespaces too? e.g.

namespace CommunityToolkit.Labs.WinUI.MarkdownTextBlock;

Or open another ticket to track that and update separately?

@Arlodotexe
Copy link
Member

Thanks @niels9001!

FYI @Arlodotexe looks like CI is failing due to GetChangedComponents (multiple here)

Did we want to update the namespaces too? e.g.

namespace CommunityToolkit.Labs.WinUI.MarkdownTextBlock;

Or open another ticket to track that and update separately?

It would be good to align them in a single sweep or back-to-back using a follow-up PR.

@michael-hawker michael-hawker force-pushed the niels9001/titlebar-packageid branch from 39e46f5 to 18f96b6 Compare August 26, 2025 21:31
<ToolkitComponentName>TitleBar</ToolkitComponentName>
<Description>This package contains TitleBar.</Description>
<Version>0.0.1</Version>
<Version>0.0.2</Version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Arlodotexe do we still need version here? This should just be handled automatically now, eh?

Copy link
Member

@Arlodotexe Arlodotexe Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-hawker We have automated versioning via https://github.com/CommunityToolkit/Tooling-Windows-Submodule/blob/786cf7bea168a37dbdeea2cf9acabf9d1cd35793/ToolkitComponent.SourceProject.props#L16, if it's set manually like this then it overrides the default computed version value.

Tooling supports both, it depends on our preference for this particular package.

Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niels9001 going to approve so we can merge this in, but could be good to do the namespace one too if you have an extra min. I may check back later, as if we can merge it soon it may make the CI that should kick-off overnight. 🤞

@michael-hawker michael-hawker merged commit 4e42800 into main Aug 27, 2025
24 checks passed
@michael-hawker michael-hawker deleted the niels9001/titlebar-packageid branch August 27, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent Package Identities

3 participants