Skip to content

Commit d6d1f6c

Browse files
authored
Fixed IAnimatedVisual impl line for WinUI 2.8 (+fixed 2.7 -> 2.8) (#524)
1 parent 76d6e51 commit d6d1f6c

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

source/UIDataCodeGen/CodeGen/CodegenConfiguration.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,6 @@ Version winUIVersion
114114
/// </summary>
115115
public Version WinUIVersion { get; set; }
116116

117-
public bool ImplementCreateAndDestroyMethods => WinUIVersion >= Version.Parse("2.7") && WinUIVersion < Version.Parse("3.0");
117+
public bool ImplementCreateAndDestroyMethods => WinUIVersion >= Version.Parse("2.8") && WinUIVersion < Version.Parse("3.0");
118118
}
119119
}

source/UIDataCodeGen/CodeGen/Cppwinrt/CppwinrtInstantiatorGenerator.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -507,10 +507,8 @@ protected override void WriteAnimatedVisualStart(
507507
{
508508
builder.WriteLine($"winrt::{_animatedVisualTypeName2},");
509509
}
510-
else
511-
{
512-
builder.WriteLine($"winrt::{_animatedVisualTypeName},");
513-
}
510+
511+
builder.WriteLine($"winrt::{_animatedVisualTypeName},");
514512

515513
builder.WriteLine($"IClosable>");
516514
builder.UnIndent();

source/UIDataCodeGen/CodeGen/IAnimatedVisualInfo.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ interface IAnimatedVisualInfo
2626

2727
/// <summary>
2828
/// Do we need to implement CreateAnimations and DestroyAnimations method.
29-
/// Available after WinUI 2.7 with new interface IAnimatedVisual2.
29+
/// Available after WinUI 2.8 with new interface IAnimatedVisual2.
3030
/// </summary>
3131
bool ImplementCreateAndDestroyMethods { get; }
3232

0 commit comments

Comments
 (0)