Revert initializer-setter changes (not needed). Refactor getter-initializer implementation.

Author: stephenquan

src/CommunityToolkit.Maui.SourceGenerators.Internal.UnitTests/BindablePropertyAttributeSourceGeneratorTests/CommonUsageTests.cs

@@ -701,7 +701,7 @@ static object __createDefaultText(global::Microsoft.Maui.Controls.BindableObject
 			        return defaultValue;
 			    }
 
-			    public partial string Text { get => __initializingText ? field : (string)GetValue(TextProperty); set => SetValue(TextProperty, field = value); }
+			    public partial string Text { get => __initializingText ? field : (string)GetValue(TextProperty); set => SetValue(TextProperty, value); }
 
 			    /// <summary>
 			    /// Backing BindableProperty for the <see cref = "CustomDuration"/> property.
@@ -716,7 +716,7 @@ static object __createDefaultCustomDuration(global::Microsoft.Maui.Controls.Bind
 			        return defaultValue;
 			    }
 			
-			    public partial System.TimeSpan CustomDuration { get => __initializingCustomDuration ? field : (System.TimeSpan)GetValue(CustomDurationProperty); set => SetValue(CustomDurationProperty, field = value); }
+			    public partial System.TimeSpan CustomDuration { get => __initializingCustomDuration ? field : (System.TimeSpan)GetValue(CustomDurationProperty); set => SetValue(CustomDurationProperty, value); }
 			}
 			""";
 

src/CommunityToolkit.Maui.SourceGenerators.Internal/Generators/BindablePropertyAttributeSourceGenerator.cs

@@ -322,36 +322,21 @@ static void GenerateProperty(StringBuilder sb, in BindablePropertyModel info)
 		{
 			sb.Append("__initializing")
 				.Append(info.PropertyName)
-				.Append(" ? field : ")
-				.Append("(")
-				.Append(formattedReturnType)
-				.Append(")GetValue(")
-				.Append(info.BindablePropertyName)
-				.Append(");\n");
-		}
-		else
-		{
-			sb.Append("(")
-				.Append(formattedReturnType)
-				.Append(")GetValue(")
-				.Append(info.BindablePropertyName)
-				.Append(");\n");
+				.Append(" ? field : ");
 		}
 
+		sb.Append("(")
+			.Append(formattedReturnType)
+			.Append(")GetValue(")
+			.Append(info.BindablePropertyName)
+			.Append(");\n");
+
 		if (info.SetterAccessibility is not null)
 		{
 			sb.Append(info.SetterAccessibility)
 				.Append("set => SetValue(")
-				.Append(info.IsReadOnlyBindableProperty ? info.BindablePropertyKeyName : info.BindablePropertyName);
-
-			if (info.HasInitializer)
-			{
-				sb.Append(", field = value);\n");
-			}
-			else
-			{
-				sb.Append(", value);\n");
-			}
+				.Append(info.IsReadOnlyBindableProperty ? info.BindablePropertyKeyName : info.BindablePropertyName)
+				.Append(", value);\n");
 		}
 		// else Do not create a Setter because the property is read-only