Skip to content

Commit 1e60956

Browse files
committed
Rename AndroidForegroundServiceEnabled property
Changed the property name for enabling the Android Foreground Service from `AndroidForegroundServiceEnabled` to `IsAndroidForegroundServiceEnabled` in `MediaElement.shared.cs` and `MediaElementOptions.shared.cs`. Updated the initialization and setter method accordingly. Modified related test cases in `AppBuilderExtensionsTests.cs` to reflect the new property name and ensure accurate verification of the service setting.
1 parent 63ad21b commit 1e60956

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

src/CommunityToolkit.Maui.MediaElement/MediaElement.shared.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ internal event EventHandler StopRequested
228228
/// <summary>
229229
/// Gets or sets whether the Android Foreground Service is enabled.
230230
/// </summary>
231-
public bool IsAndroidForegroundServiceEnabled { get; init; } = MediaElementOptions.AndroidForegroundServiceEnabled;
231+
public bool IsAndroidForegroundServiceEnabled { get; init; } = MediaElementOptions.IsAndroidForegroundServiceEnabled;
232232

233233
/// <summary>
234234
/// Gets or sets whether the media should start playing as soon as it's loaded.

src/CommunityToolkit.Maui.MediaElement/MediaElementOptions.shared.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ internal MediaElementOptions(in MauiAppBuilder builder) : this()
2020
/// <summary>
2121
/// Set Android Foreground Service for MediaElement on construction
2222
/// </summary>
23-
internal static bool AndroidForegroundServiceEnabled { get; private set; } = true;
23+
internal static bool IsAndroidForegroundServiceEnabled { get; private set; } = true;
2424

2525
/// <summary>
2626
/// Set Android View type for MediaElement as SurfaceView or TextureView on construction
@@ -31,5 +31,5 @@ internal MediaElementOptions(in MauiAppBuilder builder) : this()
3131
/// Set Android Foreground Service for MediaElement on construction
3232
/// </summary>
3333
/// <param name="androidForegroundServiceEnabled"></param>
34-
public void SetDefaultAndroidForegroundService(bool androidForegroundServiceEnabled) => AndroidForegroundServiceEnabled = androidForegroundServiceEnabled;
34+
public void SetDefaultAndroidForegroundService(bool androidForegroundServiceEnabled) => IsAndroidForegroundServiceEnabled = androidForegroundServiceEnabled;
3535
}

src/CommunityToolkit.Maui.UnitTests/Extensions/AppBuilderExtensionsTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ public void UseMauiCommunityToolkitMediaElement_ShouldSetAndroidServiceByDefault
145145
{
146146
var builder = MauiApp.CreateBuilder();
147147
builder.UseMauiCommunityToolkitMediaElement();
148-
MediaElementOptions.AndroidForegroundServiceEnabled.Should().Be(true);
148+
MediaElementOptions.IsAndroidForegroundServiceEnabled.Should().Be(true);
149149
}
150150

151151
[Fact]
@@ -156,7 +156,7 @@ public void UseMauiCommunityToolkitMediaElement_ServiceCanBeDisabled()
156156
{
157157
options.SetDefaultAndroidForegroundService(false);
158158
});
159-
MediaElementOptions.AndroidForegroundServiceEnabled.Should().Be(false);
159+
MediaElementOptions.IsAndroidForegroundServiceEnabled.Should().Be(false);
160160
}
161161
}
162162
#pragma warning restore CA1416

0 commit comments

Comments
 (0)