Bindable property for camera view (#2974)

Author: ne0rrmatrix

Directory.Build.props

@@ -11,6 +11,11 @@
     <AccelerateBuildsInVisualStudio>true</AccelerateBuildsInVisualStudio>
     <GenerateErrorForMissingTargetingPacks>false</GenerateErrorForMissingTargetingPacks>
 
+    <!--Uncomment the line below if you need to debug code generated by Source Generators
+If you see any LongPath issue on Windows, check this doc
+https://docs.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=cmd#enable-long-paths-in-windows-10-version-1607-and-later-->
+    <!--<EmitCompilerGeneratedFiles>true</EmitCompilerGeneratedFiles> -->
+
     <!-- Prevent NuGet Package Vulnerabilities -->
     <NuGetAudit>enable</NuGetAudit>
     <NuGetAuditMode>all</NuGetAuditMode>

samples/CommunityToolkit.Maui.Sample/CommunityToolkit.Maui.Sample.csproj

@@ -23,14 +23,6 @@
     <ApplicationDisplayVersion>1.0</ApplicationDisplayVersion>
     <ApplicationVersion>1</ApplicationVersion>
 
-    <!--
-    Uncomment the lines below if you need to debug the SG code
-    If you see any LongPath issue on Windows, check this doc
-    https://docs.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=cmd#enable-long-paths-in-windows-10-version-1607-and-later
-    -->
-    <!--<EmitCompilerGeneratedFiles>true</EmitCompilerGeneratedFiles>
-    <CompilerGeneratedFilesOutputPath>$(BaseIntermediateOutputPath)\GeneratedFiles</CompilerGeneratedFilesOutputPath> -->
-
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
 
     <NoWarn>IL2026</NoWarn>

src/CommunityToolkit.Maui.Analyzers.UnitTests/CommunityToolkit.Maui.Analyzers.UnitTests.csproj

@@ -2,7 +2,6 @@
 
   <PropertyGroup>
     <TargetFramework>$(NetVersion)</TargetFramework>
-    <EmitCompilerGeneratedFiles>true</EmitCompilerGeneratedFiles>
     <CompilerGeneratedFilesOutputPath>$(BaseIntermediateOutputPath)\GF</CompilerGeneratedFilesOutputPath>
     <AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
     <GenerateBindingRedirectsOutputType>true</GenerateBindingRedirectsOutputType>

src/CommunityToolkit.Maui.Camera/CommunityToolkit.Maui.Camera.csproj

@@ -51,6 +51,10 @@
     <None Include="ReadMe.txt" pack="true" PackagePath="." />
   </ItemGroup>
 
+  <ItemGroup>
+    <ProjectReference Include="..\CommunityToolkit.Maui.SourceGenerators.Internal\CommunityToolkit.Maui.SourceGenerators.Internal.csproj" OutputItemType="Analyzer" ReferenceOutputAssembly="false" />
+  </ItemGroup>
+  
   <ItemGroup Condition="$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'android'">
     <!-- Required NuGet Packages -->
     <PackageReference Include="Xamarin.AndroidX.Camera.Camera2" Version="1.4.2.3" />

src/CommunityToolkit.Maui.Camera/Interfaces/ICameraView.shared.cs

@@ -16,7 +16,7 @@ public interface ICameraView : IView
 	Size ImageCaptureResolution { get; }
 
 	/// <summary>
-	/// Gets a value indicating whether the torch is on.
+	/// Gets a value indicating whether the torch (flash) is on.
 	/// </summary>
 	bool IsTorchOn { get; }
 
@@ -39,12 +39,12 @@ public interface ICameraView : IView
 	float ZoomFactor { get; internal set; }
 
 	/// <summary>
-	/// Gets whether the implementation is available.
+	/// Gets a value indicating whether the camera feature is available on the current device.
 	/// </summary>
 	bool IsAvailable { get; internal set; }
 
 	/// <summary>
-	/// Gets whether the implementation is busy.
+	/// Gets a value indicating whether the camera is currently busy.
 	/// </summary>
 	bool IsBusy { get; internal set; }
 

src/CommunityToolkit.Maui.Camera/Primitives/CameraViewDefaults.shared.cs

@@ -7,7 +7,7 @@ namespace CommunityToolkit.Maui.Core;
 
 /// <summary>Default Values for <see cref="ICameraView"/></summary>
 [EditorBrowsable(EditorBrowsableState.Never)]
-public static class CameraViewDefaults
+static class CameraViewDefaults
 {
 	/// <summary>
 	/// Default value for <see cref="ICameraView.IsAvailable"/>
@@ -38,34 +38,4 @@ public static class CameraViewDefaults
 	/// Default value for <see cref="ICameraView.CameraFlashMode"/>
 	/// </summary>
 	public static CameraFlashMode CameraFlashMode { get; } = CameraFlashMode.Off;
-
-	internal static Command<CancellationToken> CreateCaptureImageCommand(BindableObject bindable)
-	{
-		var cameraView = (CameraView)bindable;
-		return new(async token => await cameraView.CaptureImage(token).ConfigureAwait(false));
-	}
-
-	internal static Command<CancellationToken> CreateStartCameraPreviewCommand(BindableObject bindable)
-	{
-		var cameraView = (CameraView)bindable;
-		return new(async token => await cameraView.StartCameraPreview(token).ConfigureAwait(false));
-	}
-
-	internal static ICommand CreateStopCameraPreviewCommand(BindableObject bindable)
-	{
-		var cameraView = (CameraView)bindable;
-		return new Command(_ => cameraView.StopCameraPreview());
-	}
-
-	internal static Command<Stream> CreateStartVideoRecordingCommand(BindableObject bindable)
-	{
-		var cameraView = (CameraView)bindable;
-		return new Command<Stream>(async stream => await cameraView.StartVideoRecording(stream).ConfigureAwait(false));
-	}
-
-	internal static Command<CancellationToken> CreateStopVideoRecordingCommand(BindableObject bindable)
-	{
-		var cameraView = (CameraView)bindable;
-		return new Command<CancellationToken>(async token => await cameraView.StopVideoRecording(token).ConfigureAwait(false));
-	}
 }