Fix potential threading issues

Author: ne0rrmatrix

src/CommunityToolkit.Maui.MediaElement/Primitives/Metadata.macios.cs

@@ -77,7 +77,7 @@ public async Task SetMetadata(AVPlayerItem? playerItem, IMediaElement? mediaElem
 			return;
 		}
 		ClearNowPlaying();
-		var artwork = await MetadataArtworkUrl(mediaElement.MetadataArtworkSource).ConfigureAwait(false);
+		var artwork = await MetadataArtworkUrl(mediaElement.MetadataArtworkSource);
 
 		if (artwork is UIImage image)
 		{
@@ -184,12 +184,12 @@ MPRemoteCommandHandlerStatus ToggleCommand(MPRemoteCommandEvent? commandEvent)
 		{
 			var uri = fileMediaSource.Path;
 
-			return await GetBitmapFromFile(uri, cancellationToken).ConfigureAwait(false);
+			return await GetBitmapFromFile(uri, cancellationToken);
 		}
 		else if (artworkUrl is ResourceMediaSource resourceMediaSource)
 		{
 			var path = resourceMediaSource.Path;
-			return await GetBitmapFromResource(path, cancellationToken).ConfigureAwait(false);
+			return await GetBitmapFromResource(path, cancellationToken);
 		}
 		return null;
 	}
@@ -202,7 +202,7 @@ MPRemoteCommandHandlerStatus ToggleCommand(MPRemoteCommandEvent? commandEvent)
 		}
 		using var fileStream = File.OpenRead(resource);
 		using var memoryStream = new MemoryStream();
-		await fileStream.CopyToAsync(memoryStream, cancellationToken).ConfigureAwait(false);
+		await fileStream.CopyToAsync(memoryStream, cancellationToken);
 		memoryStream.Position = 0;
 		NSData temp = NSData.FromStream(memoryStream) ?? new NSData();
 		return UIImage.LoadFromData(temp);
@@ -221,14 +221,14 @@ MPRemoteCommandHandlerStatus ToggleCommand(MPRemoteCommandEvent? commandEvent)
 		{
 			return null;
 		}
-		using var inputStream = await FileSystem.OpenAppPackageFileAsync(resource).ConfigureAwait(false);
+		using var inputStream = await FileSystem.OpenAppPackageFileAsync(resource);
 		using var memoryStream = new MemoryStream();
 		if (inputStream is null)
 		{
 			System.Diagnostics.Trace.TraceInformation($"{inputStream} is null.");
 			return null;
 		}
-		await inputStream.CopyToAsync(memoryStream, cancellationToken).ConfigureAwait(false);
+		await inputStream.CopyToAsync(memoryStream, cancellationToken);
 		memoryStream.Position = 0;
 		NSData? nsdata = NSData.FromStream(memoryStream);
 		if (nsdata is null)

src/CommunityToolkit.Maui.MediaElement/Views/MediaManager.android.cs

@@ -339,7 +339,7 @@ protected virtual async partial ValueTask PlatformUpdateSource()
 		Player.PlayWhenReady = MediaElement.ShouldAutoPlay;
 		cancellationTokenSource ??= new();
 		// ConfigureAwait(true) is required to prevent crash on startup
-		var result = await SetPlayerData(cancellationTokenSource.Token).ConfigureAwait(true);
+		var result = await SetPlayerData(cancellationTokenSource.Token);
 		var item = result?.Build();
 
 		if (item?.MediaMetadata is not null)
@@ -541,7 +541,7 @@ void StopService(in BoundServiceConnection boundServiceConnection)
 					var uri = uriMediaSource.Uri;
 					if (!string.IsNullOrWhiteSpace(uri?.AbsoluteUri))
 					{
-						return await CreateMediaItem(uri.AbsoluteUri, cancellationToken).ConfigureAwait(false);
+						return await CreateMediaItem(uri.AbsoluteUri, cancellationToken);
 					}
 
 					break;
@@ -551,7 +551,7 @@ void StopService(in BoundServiceConnection boundServiceConnection)
 					var filePath = fileMediaSource.Path;
 					if (!string.IsNullOrWhiteSpace(filePath))
 					{
-						return await CreateMediaItem(filePath, cancellationToken).ConfigureAwait(false);
+						return await CreateMediaItem(filePath, cancellationToken);
 					}
 
 					break;
@@ -563,7 +563,7 @@ void StopService(in BoundServiceConnection boundServiceConnection)
 					if (!string.IsNullOrWhiteSpace(path))
 					{
 						var assetFilePath = $"asset://{package}{System.IO.Path.PathSeparator}{path}";
-						return await CreateMediaItem(assetFilePath, cancellationToken).ConfigureAwait(false);
+						return await CreateMediaItem(assetFilePath, cancellationToken);
 					}
 
 					break;
@@ -580,7 +580,7 @@ void StopService(in BoundServiceConnection boundServiceConnection)
 		MediaMetadata.Builder mediaMetaData = new();
 		mediaMetaData.SetArtist(MediaElement.MetadataArtist);
 		mediaMetaData.SetTitle(MediaElement.MetadataTitle);
-		var data = await GetImageFromMediaSource(MediaElement.MetadataArtworkSource, cancellationToken).ConfigureAwait(true) ?? BlankByteArray();
+		var data = await GetImageFromMediaSource(MediaElement.MetadataArtworkSource, cancellationToken) ?? BlankByteArray();
 		mediaMetaData.SetArtworkData(data, (Java.Lang.Integer)MediaMetadata.PictureTypeFrontCover);
 
 		mediaItem = new MediaItem.Builder();
@@ -606,7 +606,7 @@ void StopService(in BoundServiceConnection boundServiceConnection)
 				System.Diagnostics.Trace.TraceInformation("Arkwork Uri is null or empty");
 				return null;
 			}
-			return await client.GetByteArrayAsync(uri, cancellationToken).ConfigureAwait(false);
+			return await client.GetByteArrayAsync(uri, cancellationToken);
 		}
 		else if (artworkUrl is FileMediaSource fileMediaSource)
 		{
@@ -616,7 +616,7 @@ void StopService(in BoundServiceConnection boundServiceConnection)
 				System.Diagnostics.Trace.TraceInformation("Arkwork File path is null or empty");
 				return null;
 			}
-			return await GetByteArrayFromFile(filePath, cancellationToken).ConfigureAwait(false);
+			return await GetByteArrayFromFile(filePath, cancellationToken);
 		}
 		else if (artworkUrl is ResourceMediaSource resourceMediaSource)
 		{
@@ -627,7 +627,7 @@ void StopService(in BoundServiceConnection boundServiceConnection)
 				System.Diagnostics.Trace.TraceInformation("Arkwork Resource path is null or empty");
 				return null;
 			}
-			return await GetByteArrayFromResource(item).ConfigureAwait(false);
+			return await GetByteArrayFromResource(item);
 		}
 		return null;
 	}
@@ -641,7 +641,7 @@ void StopService(in BoundServiceConnection boundServiceConnection)
 			return null;
 		}
 		using var memoryStream = new MemoryStream();
-		await stream.CopyToAsync(memoryStream, CancellationToken.None).ConfigureAwait(false);
+		await stream.CopyToAsync(memoryStream, CancellationToken.None);
 		var bytes = memoryStream.ToArray();
 		return bytes;
 	}
@@ -655,7 +655,7 @@ void StopService(in BoundServiceConnection boundServiceConnection)
 		}
 		var stream = File.OpenRead(filePath);
 		var memoryStream = new MemoryStream();
-		await stream.CopyToAsync(memoryStream, cancellationToken).ConfigureAwait(false);
+		await stream.CopyToAsync(memoryStream, cancellationToken);
 		var bytes = memoryStream.ToArray();
 		return bytes;
 	}

src/CommunityToolkit.Maui.MediaElement/Views/MediaManager.macios.cs

@@ -503,7 +503,7 @@ async ValueTask SetPoster(CancellationToken cancellationToken = default)
 		{
 			return;
 		}
-		var artwork = await Metadata.MetadataArtworkUrl(MediaElement.MetadataArtworkSource, cancellationToken).ConfigureAwait(false);
+		var artwork = await Metadata.MetadataArtworkUrl(MediaElement.MetadataArtworkSource, cancellationToken);
 		if (artwork is null)
 		{
 			System.Diagnostics.Trace.TraceInformation($"{artwork} is null.");