Refctor EffectiveDefaultValueCreatorMethodName property (replacing GetDefaultValueCreatorMethodName method)

Author: stephenquan

src/CommunityToolkit.Maui.SourceGenerators.Internal.UnitTests/BindablePropertyModelTests.cs

@@ -91,6 +91,7 @@ public void BindablePropertyModel_WithAllParameters_StoresCorrectValues()
 		Assert.Equal(newKeywordText, model.NewKeywordText);
 		Assert.Equal(hasInitializer, model.HasInitializer);
 		Assert.Equal("TestPropertyProperty", model.BindablePropertyName);
+		Assert.Equal(defaultValueCreatorMethodName, model.EffectiveDefaultValueCreatorMethodName);
 	}
 
 	[Fact]
@@ -161,4 +162,36 @@ static Compilation CreateCompilation(string source)
 			references,
 			new CSharpCompilationOptions(OutputKind.DynamicallyLinkedLibrary));
 	}
+
+	[Fact]
+	public void BindablePropertyName_WithInitializer_ReturnsCorrectEffectiveDefaultValueCreatorMethodName()
+	{
+		// Arrange
+		var compilation = CreateCompilation("public class TestClass { public string TestProperty { get; set; } = \"Initial Value\"; }");
+		var typeSymbol = compilation.GetTypeByMetadataName("TestClass")!;
+		var propertySymbol = typeSymbol.GetMembers("TestProperty").OfType<IPropertySymbol>().First();
+
+		var model = new BindablePropertyModel(
+			"TestProperty",
+			propertySymbol.Type,
+			typeSymbol,
+			"null",
+			"Microsoft.Maui.Controls.BindingMode.OneWay",
+			"null",
+			"null",
+			"null",
+			"null",
+			"null",
+			string.Empty,
+			true, // IsReadOnlyBindableProperty
+			string.Empty, // SetterAccessibility
+			true
+		);
+
+		// Act
+		var effectiveDefaultValueCreatorMethodName = model.EffectiveDefaultValueCreatorMethodName;
+
+		// Assert
+		Assert.Equal("__createDefaultTestProperty", effectiveDefaultValueCreatorMethodName);
+	}
 }

src/CommunityToolkit.Maui.SourceGenerators.Internal/Generators/BindablePropertyAttributeSourceGenerator.cs

@@ -242,7 +242,7 @@ static void GenerateReadOnlyBindableProperty(StringBuilder sb, in BindableProper
 			.Append(", ")
 			.Append(info.CoerceValueMethodName)
 			.Append(", ")
-			.Append(GetDefaultValueCreatorMethodName(in info))
+			.Append(info.EffectiveDefaultValueCreatorMethodName)
 			.Append(");\n");
 
 		// Generate public BindableProperty from the key
@@ -298,7 +298,7 @@ static void GenerateBindableProperty(StringBuilder sb, in BindablePropertyModel
 			.Append(", ")
 			.Append(info.CoerceValueMethodName)
 			.Append(", ")
-			.Append(GetDefaultValueCreatorMethodName(in info))
+			.Append(info.EffectiveDefaultValueCreatorMethodName)
 			.Append(");\n");
 
 		sb.Append('\n');
@@ -546,23 +546,6 @@ static string GetFormattedReturnType(ITypeSymbol typeSymbol)
 		}
 	}
 
-	/// <summary>
-	/// Determines the name of the method used to create the default value for the specified bindable property model.
-	/// </summary>
-	/// <param name="info">The bindable property model for which to retrieve the default value creator method name.</param>
-	/// <returns>A string containing the name of the method that creates the default value for the property.
-	/// If the property has an initializer, the returned name is of the generated default value method;
-	/// otherwise, the default value creator method name from the model is returned.</returns>
-	static string GetDefaultValueCreatorMethodName(in BindablePropertyModel info)
-	{
-		if (info.HasInitializer)
-		{
-			return "__createDefault" + info.PropertyName;
-		}
-
-		return info.DefaultValueCreatorMethodName;
-	}
-
 	/// <summary>
 	/// Generates the boolean initialization flag used by bindable properties with initializers to indicate that the getter
 	/// should return the backing field while the generated default value method is executing.
@@ -591,7 +574,7 @@ static void GenerateDefaultValueMethod(StringBuilder sb, in BindablePropertyMode
 		var sanitizedPropertyName = IsDotnetKeyword(info.PropertyName) ? string.Concat("@", info.PropertyName) : info.PropertyName;
 
 		sb.Append("static object ")
-			.Append(GetDefaultValueCreatorMethodName(in info))
+			.Append(info.EffectiveDefaultValueCreatorMethodName)
 			.Append("(global::Microsoft.Maui.Controls.BindableObject bindable)\n")
 			.Append("{\n")
 			.Append("((")

src/CommunityToolkit.Maui.SourceGenerators.Internal/Models/Records.cs

@@ -7,6 +7,7 @@ record BindablePropertyModel(string PropertyName, ITypeSymbol ReturnType, ITypeS
 {
 	public string BindablePropertyName => $"{PropertyName}Property";
 	public string BindablePropertyKeyName => $"{char.ToLower(PropertyName[0])}{PropertyName[1..]}PropertyKey";
+	public string EffectiveDefaultValueCreatorMethodName => HasInitializer ? $"__createDefault{PropertyName}" : DefaultValueCreatorMethodName;
 }
 
 record SemanticValues(ClassInformation ClassInformation, EquatableArray<BindablePropertyModel> BindableProperties);