Refactor and clean up media manager methods

Simplified `SetMetadata` in `Metadata.macios.cs` by removing a null check for `artwork` before checking if it is a `UIImage`. Cleaned up `Dispose` in `MediaManager.android.cs` by removing redundant empty lines. Streamlined `StopService` in `MediaManager.android.cs` by removing `HttpClient` usage and `GetBytesFromMetadataArtworkUrl` method. Updated `Dispose` in `MediaManager.macios.cs` to change `SetPoster` return type from `Task` to `ValueTask`. Refactored `UpdateMetadata` in `MediaManager.windows.cs` to handle different `MetadataArtworkSource` types explicitly and removed redundant `ArtworkUrl` method. Cleaned up `OnPlaybackSessionPlaybackStateChanged` in `MediaManager.windows.cs` by removing the now redundant `ArtworkUrl` method.

Author: ne0rrmatrix

src/CommunityToolkit.Maui.MediaElement/Primitives/Metadata.macios.cs

@@ -79,7 +79,7 @@ public async Task SetMetadata(AVPlayerItem? playerItem, IMediaElement? mediaElem
 		ClearNowPlaying();
 		var artwork = await MetadataArtworkUrl(mediaElement.MetadataArtworkSource).ConfigureAwait(false);
 
-		if (artwork is not null && artwork is UIImage image)
+		if (artwork is UIImage image)
 		{
 			NowPlayingInfo.Artwork = new(boundsSize: new(320, 240), requestHandler: _ => image);
 		}

src/CommunityToolkit.Maui.MediaElement/Views/MediaManager.android.cs

@@ -505,8 +505,6 @@ protected override void Dispose(bool disposing)
 		}
 	}
 
-	
-
 	[MemberNotNull(nameof(connection))]
 	void StartService()
 	{
@@ -597,7 +595,6 @@ void StopService(in BoundServiceConnection boundServiceConnection)
 	{
 		if (mediaSource is null)
 		{
-			System.Diagnostics.Trace.TraceInformation("Atwork MediaSource is null");
 			return null;
 		}
 		var artworkUrl = mediaSource;
@@ -609,7 +606,6 @@ void StopService(in BoundServiceConnection boundServiceConnection)
 				System.Diagnostics.Trace.TraceInformation("Arkwork Uri is null or empty");
 				return null;
 			}
-			using var client = new HttpClient();
 			return await client.GetByteArrayAsync(uri, cancellationToken).ConfigureAwait(false);
 		}
 		else if (artworkUrl is FileMediaSource fileMediaSource)
@@ -635,31 +631,13 @@ void StopService(in BoundServiceConnection boundServiceConnection)
 		}
 		return null;
 	}
-
-	static async Task<byte[]?> GetBytesFromMetadataArtworkUrl(string? url, CancellationToken cancellationToken = default)
-	{
-		var response = await client.GetAsync(url, cancellationToken).ConfigureAwait(false);
-		var stream = response.IsSuccessStatusCode ? await response.Content.ReadAsStreamAsync(cancellationToken).ConfigureAwait(false) : null;
-
-		if (stream is null)
-		{
-			System.Diagnostics.Trace.TraceInformation("Arkwork Url stream is null");
-			return null;
-		}
-
-		using var memoryStream = new MemoryStream();
-		await stream.CopyToAsync(memoryStream, cancellationToken).ConfigureAwait(false);
-		var bytes = memoryStream.ToArray();
-		return bytes;
-	}
 
 	static async Task<byte[]?> GetByteArrayFromResource(string resource)
 	{
 		// Android file system does not report size of file so we need to use a buffer for the stream.
 		using var stream = await FileSystem.Current.OpenAppPackageFileAsync(resource);
 		if(stream is null)
 		{
-			System.Diagnostics.Trace.TraceInformation("Arkwork Resource stream is null");
 			return null;
 		}
 		using var memoryStream = new MemoryStream();

src/CommunityToolkit.Maui.MediaElement/Views/MediaManager.macios.cs

@@ -497,7 +497,7 @@ protected virtual void Dispose(bool disposing)
 		}
 	}
 
-	async Task SetPoster(CancellationToken cancellationToken = default)
+	async ValueTask SetPoster(CancellationToken cancellationToken = default)
 	{
 		if (PlayerItem is null || metaData is null || MediaElement is null)
 		{

src/CommunityToolkit.Maui.MediaElement/Views/MediaManager.windows.cs

@@ -362,30 +362,45 @@ async ValueTask UpdateMetadata()
 			return;
 		}
 
-		var artwork = ArtworkUrl(MediaElement.MetadataArtworkSource);
-		if(string.IsNullOrEmpty(artwork))
+		if (MediaElement.MetadataArtworkSource is UriMediaSource uriMediaSource)
 		{
-			return;
+			var artwork = uriMediaSource.Uri?.AbsoluteUri ?? string.Empty;
+			var file = RandomAccessStreamReference.CreateFromUri(new Uri(artwork));
+			if (file is not null)
+			{
+				systemMediaControls.DisplayUpdater.Thumbnail = file;
+				systemMediaControls.DisplayUpdater.Update();
+				Uri uri = new(artwork);
+				Dispatcher.Dispatch(() => Player.PosterSource = new BitmapImage(uri));
+			}
 		}
-		
-		var file = RandomAccessStreamReference.CreateFromUri(new Uri(artwork));
-		if (file is not null)
+
+		if (MediaElement.MetadataArtworkSource is FileMediaSource fileMediaSource)
 		{
-			systemMediaControls.DisplayUpdater.Thumbnail = file;
-			systemMediaControls.DisplayUpdater.Update();
-			Uri uri = new(artwork);
-			Dispatcher.Dispatch(() => Player.PosterSource = new BitmapImage(uri));
+			var artwork = fileMediaSource.Path;
+			if (File.Exists(artwork))
+			{
+				StorageFile ImageFile = await StorageFile.GetFileFromPathAsync(artwork);
+				Dispatcher.Dispatch(async () =>
+				{
+					var bitmap = await LoadBitmapImageAsync(ImageFile);
+					Player.PosterSource = bitmap;
+				});
+				systemMediaControls.DisplayUpdater.Thumbnail = RandomAccessStreamReference.CreateFromFile(ImageFile);
+
+			}
 		}
-		
-		if (File.Exists(artwork))
+		if (MediaElement.MetadataArtworkSource is ResourceMediaSource resourceMediaSource)
 		{
-			StorageFile ImageFile = await StorageFile.GetFileFromPathAsync(artwork);
-			Dispatcher.Dispatch(async () =>
+			var artwork = "ms-appx:///" + resourceMediaSource.Path;
+			var file = RandomAccessStreamReference.CreateFromUri(new Uri(artwork));
+			if (file is not null)
 			{
-				var bitmap = await LoadBitmapImageAsync(ImageFile);
-				Player.PosterSource = bitmap;
-			});
-			systemMediaControls.DisplayUpdater.Thumbnail = RandomAccessStreamReference.CreateFromFile(ImageFile);
+				systemMediaControls.DisplayUpdater.Thumbnail = file;
+				systemMediaControls.DisplayUpdater.Update();
+				Uri uri = new(artwork);
+				Dispatcher.Dispatch(() => Player.PosterSource = new BitmapImage(uri));
+			}
 		}
 
 		systemMediaControls.DisplayUpdater.Type = MediaPlaybackType.Music;
@@ -514,23 +529,6 @@ void OnPlaybackSessionPlaybackStateChanged(MediaPlaybackSession sender, object a
 			});
 		}
 	}
-
-	static string ArtworkUrl(MediaSource? artwork)
-	{
-		if (artwork is UriMediaSource uriMediaSource)
-		{
-			return uriMediaSource.Uri?.AbsoluteUri ?? string.Empty;
-		}
-		else if (artwork is FileMediaSource fileMediaSource)
-		{
-			return fileMediaSource.Path ?? string.Empty;
-		}
-		else if (artwork is ResourceMediaSource resourceMediaSource)
-		{
-			return "ms-appx:///" + resourceMediaSource.Path;
-		}
-		return string.Empty;
-	}
 
 	void OnPlaybackSessionSeekCompleted(MediaPlaybackSession sender, object args)
 	{