Use [BindableProperty] for RatingView (#2964)

* Changed to using the BindableProperty SourceGen syntax.

* Completed changes to the RatingView so that it's now using the SG bindable properties, fixed failing tests and had to remove 2 as these no longer made sense. There was a hard coded Default which was added to the Defaults as well.  Only issue is that the DefaultValue use from the SG only returns an Int no matter what the default Value should be like a Bool, Double, Color etc so there are CreateDefault Methods to resolve this until the SG is fixed and these can be removed...

* Update Formatting, Remove Unneeded DefaultValueCreatorMethods

* Fix Validators for Rating + MaximumRating, Use `PropertyChanging` for ArgumentOutOfRange Validation

* Remove Validators

* Remove `[RequiresUnreferencedCode]`

* `dotnet format`

* Add `[BindableProperty]` to `RatingView.FillOption`

* Update RatingView.shared.cs

---------

Co-authored-by: Brandon Minnick <[email protected]>

Author: CliffAgius

src/CommunityToolkit.Maui.Core/Primitives/Defaults/RatingViewDefaults.shared.cs

@@ -1,14 +1,10 @@
-// Ignore Spelling: color
-
-using System.ComponentModel;
-
-namespace CommunityToolkit.Maui.Core;
+namespace CommunityToolkit.Maui.Core;
 
 /// <summary>Default Values for RatingView</summary>
 static class RatingViewDefaults
 {
 	/// <summary>Default rating value.</summary>
-	public const double DefaultRating = 0.0;
+	public const double Rating = 0.0;
 
 	/// <summary>Default view element read only.</summary>
 	public const bool IsReadOnly = false;
@@ -28,6 +24,15 @@ static class RatingViewDefaults
 	/// <summary>Default spacing between ratings.</summary>
 	public const double Spacing = 10.0;
 
+	/// <summary>Default rating shape.</summary>
+	public const RatingViewShape Shape = RatingViewShape.Star;
+
+	/// <summary>Default Fill When Tapped</summary>
+	public const RatingViewFillOption FillWhenTapped = RatingViewFillOption.Shape;
+	
+	/// <summary>Default Fill Option</summary>
+	public const RatingViewFillOption FillOption = RatingViewFillOption.Shape;
+
 	/// <summary>Default color for an empty rating.</summary>
 	public static Color EmptyShapeColor { get; } = Colors.Transparent;
 
@@ -37,9 +42,6 @@ static class RatingViewDefaults
 	/// <summary>Default rating item padding.</summary>
 	public static Thickness ShapePadding { get; } = new(0);
 
-	/// <summary>Default rating shape.</summary>
-	public static RatingViewShape Shape { get; } = RatingViewShape.Star;
-
 	/// <summary>Default border color for a rating shape.</summary>
 	public static Color ShapeBorderColor { get; } = Colors.Grey;
 }

src/CommunityToolkit.Maui.SourceGenerators.Benchmarks/BindablePropertyAttributeSourceGeneratorBenchmarks.cs

@@ -37,4 +37,4 @@ public Task GenerateBindableProperty_NestedClass_GeneratesCorrectCode()
 	[Benchmark]
 	public Task GenerateBindableProperty_WithComplexDefaultValues_GeneratesCorrectCode()
 		=> edgeCaseTests.GenerateBindableProperty_WithComplexDefaultValues_GeneratesCorrectCode();
-}
+}

src/CommunityToolkit.Maui.SourceGenerators.Benchmarks/Program.cs

@@ -10,4 +10,4 @@ public static void Main(string[] args)
 		var config = DefaultConfig.Instance;
 		BenchmarkRunner.Run<BindablePropertyAttributeSourceGeneratorBenchmarks>(config, args);
 	}
-}
+}

src/CommunityToolkit.Maui.SourceGenerators.Internal/Helpers/AttributeExtensions.cs

@@ -29,9 +29,9 @@ public static string GetNamedTypeArgumentsAttributeValueByNameAsCastedString(thi
 			return $"({data.Type}){members[(int)data.Value]}";
 		}
 
-		if(data.Type?.SpecialType is SpecialType.System_String)
+		if (data.Type?.SpecialType is SpecialType.System_String)
 		{
-			return data.Value is null ? $"\"{placeholder}\"": $"({data.Type})\"{data.Value}\"";
+			return data.Value is null ? $"\"{placeholder}\"" : $"({data.Type})\"{data.Value}\"";
 		}
 
 		if (data.Type?.SpecialType is SpecialType.System_Char)

src/CommunityToolkit.Maui.UnitTests/Mocks/MockCameraProvider.cs

@@ -21,7 +21,7 @@ private set
 
 	public void Dispose()
 	{
-		
+
 	}
 
 	public Task RefreshAvailableCameras(CancellationToken token)

src/CommunityToolkit.Maui.UnitTests/Views/RatingView/RatingViewTests.cs

@@ -82,7 +82,7 @@ public void Defaults_ShapeDefaultsApplied()
 	public void Defaults_ShouldHaveCorrectDefaultProperties()
 	{
 		RatingView ratingView = new();
-		ratingView.Rating.Should().Be(RatingViewDefaults.DefaultRating);
+		ratingView.Rating.Should().Be(RatingViewDefaults.Rating);
 		ratingView.EmptyShapeColor.Should().BeOfType<Color>().And.Be(RatingViewDefaults.EmptyShapeColor);
 		ratingView.FillColor.Should().BeOfType<Color>().And.Be(RatingViewDefaults.FillColor);
 		ratingView.IsReadOnly.Should().BeFalse().And.Be(RatingViewDefaults.IsReadOnly);
@@ -93,7 +93,8 @@ public void Defaults_ShouldHaveCorrectDefaultProperties()
 		ratingView.ShapeBorderColor.Should().BeOfType<Color>().And.Be(RatingViewDefaults.ShapeBorderColor);
 		ratingView.ShapeBorderThickness.Should().Be(RatingViewDefaults.ShapeBorderThickness);
 		ratingView.Spacing.Should().Be(RatingViewDefaults.Spacing);
-		ratingView.FillOption.Should().BeOneOf(RatingViewFillOption.Shape).And.Be(RatingViewFillOption.Shape);
+		ratingView.FillWhenTapped.Should().Be(RatingViewDefaults.FillWhenTapped);
+		ratingView.FillOption.Should().BeOneOf(RatingViewDefaults.FillOption);
 		ratingView.CustomShapePath.Should().BeNull();
 	}
 
@@ -170,7 +171,7 @@ public void Events_RatingChanged_ShouldBeRaised_RatingPropertyChanged_NotReadOnl
 	{
 		const double currentRating = 3.5;
 		RatingView ratingView = new();
-		ratingView.Rating.Should().Be(RatingViewDefaults.DefaultRating);
+		ratingView.Rating.Should().Be(RatingViewDefaults.Rating);
 		var signaled = false;
 		ratingView.RatingChanged += (sender, e) => signaled = true;
 		ratingView.Rating = currentRating;
@@ -621,24 +622,6 @@ public void Properties_MaximumRating_NumberOfChildrenLower()
 		ratingView.RatingLayout.Count.Should().Be(minMaximumRating);
 	}
 
-	[Fact]
-	public void Properties_MaximumRating_Validator()
-	{
-		RatingView ratingView = new();
-		RatingView.MaximumRatingProperty.ValidateValue(ratingView, 0).Should().BeFalse();
-		RatingView.MaximumRatingProperty.ValidateValue(ratingView, RatingViewDefaults.MaximumRatingLimit + 1).Should().BeFalse();
-		RatingView.MaximumRatingProperty.ValidateValue(ratingView, 1).Should().BeTrue();
-	}
-
-	[Fact]
-	public void Properties_Rating_Validator()
-	{
-		RatingView ratingView = new();
-		RatingView.RatingProperty.ValidateValue(ratingView, -1.0).Should().BeFalse();
-		RatingView.RatingProperty.ValidateValue(ratingView, (double)(RatingViewDefaults.MaximumRatingLimit + 1)).Should().BeFalse();
-		RatingView.RatingProperty.ValidateValue(ratingView, 0.1).Should().BeTrue();
-	}
-
 	[Fact]
 	public void RatingViewDoesNotThrowsArgumentOutOfRangeExceptionWhenRatingSetBeforeMaximumRating()
 	{
@@ -675,7 +658,7 @@ public void RatingViewThrowsInvalidOperationExceptionWhenChildIsNotBorder()
 	public void RatingViewThrowsArgumentOutOfRangeExceptionWhenOutsideLowerBounds()
 	{
 		RatingView ratingView = new();
-		Assert.Throws<ArgumentOutOfRangeException>(() => ratingView.Rating = 0 - double.Epsilon);
+		Assert.Throws<ArgumentOutOfRangeException>(() => ratingView.Rating = -1);
 	}
 
 	[Fact]