Skip to content

Fix macios filepicker #2981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matt-goldman wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Fix macios filepicker #2981

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4d9487c
Test file saver with export to service mode
matt-goldman Dec 1, 2025
ed5f254
Used correct constructor with asCopy set to true
matt-goldman Dec 1, 2025
47ddfe5
Add temporary directory cleanup in file saving process
matt-goldman Dec 2, 2025
07be3c6
Fixes disposal of temporary file on iOS
VladislavAntonyuk Dec 4, 2025
7757fce
Merge branch 'main' into fix-macios-filepicker
TheCodeTraveler Dec 4, 2025
f87e43d
Fixes disposal of temporary directory on iOS
VladislavAntonyuk Dec 4, 2025
08f9ffd
Update src/CommunityToolkit.Maui.Core/Essentials/FileSaver/FileSaverI…
matt-goldman Dec 6, 2025
102300e
Merge branch 'main' into fix-macios-filepicker
matt-goldman Dec 6, 2025
d88f395
Merge branch 'main' into fix-macios-filepicker
matt-goldman Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/CommunityToolkit.Maui.Core/Essentials/FileSaver/FileSaverImplementation.macios.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ async Task<string> InternalSaveAsync(string initialPath, string fileName, Stream
taskCompetedSource?.TrySetCanceled(CancellationToken.None);
var tcs = taskCompetedSource = new(cancellationToken);

documentPickerViewController = new([fileUrl])
documentPickerViewController = new([fileUrl], true)
Copy link
Collaborator

@VladislavAntonyuk VladislavAntonyuk Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we delete temp file in this case if we copy it instead of move?

Copy link
Author

@matt-goldman matt-goldman Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so. I started refactoring this, I wanted to see if I could make it a more logical flow, and added a Cleanup method that handled that and the dispose. But I didn't want to introduce too many changes.

Copy link
Collaborator

@VladislavAntonyuk VladislavAntonyuk Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally if we don't use the temp file at all and write directly to the target location.

To make it simple for now you can wrap the code in try/finally block and delete temp file in finally section if it exists. It should not add complexity and many changes.

Copy link
Author

@matt-goldman matt-goldman Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally if we don't use the temp file at all and write directly to the target location.

I've spent a bit of time looking into this and I don't think it's practical. The only way to write directly outside the app's sandbox is using a security scoped URL and something like NSFileCoordinator. The problem is, this requires the user to grant access to it first, so it's not something we can do with a new file.

Additionally, we would have to track that the user has granted access and have safety checks that fall back to the temp file approach if not. And the problem with the first part is that it requires app-wide tracking and coordination. It's not impossible (far from it) but it's outside the scope of the vertical slice of this API.

The current approach (creating a temp file, then moving) is the canonical approach with Apple's API.

To make it simple for now you can wrap the code in try/finally block and delete temp file in finally section if it exists. It should not add complexity and many changes.

Agreed 🙂 Done in 47ddfe5. Please let me know if this is ok, or if you want me to make any other changes.

Copy link
Collaborator

@VladislavAntonyuk VladislavAntonyuk Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a tiny change to ensure the temp file is always deleted. Please let me know if it looks good

{
DirectoryUrl = NSUrl.FromString(initialPath)
};
Expand Down
Loading