Skip to content

Commit 2ed2861

Browse files
Arlodotexemichael-hawker
authored andcommitted
Force dotnet to install and use the version explictly installed in CI. Adjust warnings handling in Directory.Build.props
1 parent d71b08b commit 2ed2861

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@ on:
1717

1818
env:
1919
DOTNET_VERSION: ${{ '8.0.x' }}
20+
DOTNET_INSTALL_DIR: dotnet-install
21+
DOTNET_ROOT: dotnet-install
2022
ENABLE_DIAGNOSTICS: false
2123
#COREHOST_TRACE: 1
2224
COREHOST_TRACEFILE: corehosttrace.log

.github/workflows/config/Directory.Build.props

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,9 @@
1717
<Copyright>(c) .NET Foundation and Contributors. All rights reserved.</Copyright>
1818
<PackageProjectUrl>https://github.com/CommunityToolkit/Tooling-Windows-Submodule</PackageProjectUrl>
1919
<PackageReleaseNotes>https://github.com/CommunityToolkit/Tooling-Windows-Submodule/releases</PackageReleaseNotes>
20-
<!-- TODO: Remove when closing https://github.com/CommunityToolkit/Labs-Windows/issues/256 -->
21-
<NoWarn>$(NoWarn);NU1505;NU1504</NoWarn>
20+
21+
<!-- See https://github.com/CommunityToolkit/Labs-Windows/pull/605#issuecomment-2498743676 -->
22+
<WarningsNotAsErrors>NU1901;NU1902;NU1903;NU1904</WarningsNotAsErrors>
2223
</PropertyGroup>
2324

2425
<PropertyGroup>

0 commit comments

Comments
 (0)