Skip to content

Commit 6bc1f28

Browse files
authored
Merge pull request #52 from CommunityToolkit/fix/uno/suppress-uno-idisposable
Suppress warnings for IDisposable exposed by Uno
2 parents 6a0c5c5 + e64ac0e commit 6bc1f28

File tree

2 files changed

+17
-1
lines changed

2 files changed

+17
-1
lines changed

.github/workflows/build.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,13 @@ jobs:
147147
TEST_PROJECT_DIRECTORY: components/CiTestExp
148148

149149
steps:
150+
- name: Configure Pagefile
151+
uses: al-cheb/[email protected]
152+
with:
153+
minimum-size: 32GB
154+
maximum-size: 32GB
155+
disk-root: "C:"
156+
150157
- name: Install .NET SDK v${{ env.DOTNET_VERSION }}
151158
uses: actions/setup-dotnet@v3
152159
with:

MultiTarget/Uno.props

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<ItemGroup Condition="'$(IsUno)' == 'true'">
55
<PackageReference Include="Uno.UI" Version="4.6.18" />
66
</ItemGroup>
7-
7+
88
<PropertyGroup Condition="'$(IsUno)' == 'true'">
99
<UnoUIUseRoslynSourceGenerators>true</UnoUIUseRoslynSourceGenerators>
1010
</PropertyGroup>
@@ -20,11 +20,20 @@
2020
<ItemGroup Condition="'$(IsWpfHead)' == 'true'">
2121
<PackageReference Include="Uno.UI.Skia.Wpf" Version="4.6.18" />
2222
</ItemGroup>
23+
2324
<PropertyGroup Condition="'$(IsWpfHead)' == 'true'">
2425
<!-- Ignorable issue from SkiaSharp package, see: https://github.com/CommunityToolkit/Labs-Windows/pull/119#issuecomment-1125373091 -->
2526
<NoWarn>$(NoWarn);NU1701</NoWarn>
2627
</PropertyGroup>
2728

29+
<PropertyGroup>
30+
<!--
31+
Uno uses IDisposable internally, but exposes it publicly.
32+
See https://github.com/CommunityToolkit/Labs-Windows/pull/275#issuecomment-1331113635
33+
-->
34+
<NoWarn>$(NoWarn);CA1063;CA1001;</NoWarn>
35+
</PropertyGroup>
36+
2837
<ItemGroup Condition="'$(IsWasmHead)' == 'true'">
2938
<PackageReference Include="Uno.UI.WebAssembly" Version="4.6.18" />
3039
</ItemGroup>

0 commit comments

Comments
 (0)