-
Notifications
You must be signed in to change notification settings - Fork 108
Open
Labels
components::helpersHelpers for Colors, Network, Camera, WeakEventListener, PackageVersion, ScreenUnit and more.Helpers for Colors, Network, Camera, WeakEventListener, PackageVersion, ScreenUnit and more.enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers
Description
ThemeListener
doesn't work in the Windows App SDK at the moment, so thinking we should remove it for now until it's supported in the WASDK?
In either case, we should refactor to remove the call to EnqueueAsync
for the DispatcherQueue
Extensions so we don't need the Helper package to depend on the Extensions package. I think that's the only call there:
Windows/components/Helpers/src/ThemeListener.cs
Lines 110 to 123 in be4577e
return DispatcherQueue.EnqueueAsync( | |
() => | |
{ | |
// TODO: This doesn't stop the multiple calls if we're in our faked 'White' HighContrast Mode below. | |
if (CurrentTheme != Application.Current.RequestedTheme || | |
IsHighContrast != _accessible.HighContrast) | |
{ | |
#if DEBUG | |
global::System.Diagnostics.Debug.WriteLine("Color Values Changed"); | |
#endif | |
UpdateProperties(); | |
} | |
}, DispatcherQueuePriority.Normal); |
Seems to be the only use of the Extensions I believe in this project. (which also means the Collections package is pulling them in as they depend on the Helpers)
fabianoriccardi
Metadata
Metadata
Assignees
Labels
components::helpersHelpers for Colors, Network, Camera, WeakEventListener, PackageVersion, ScreenUnit and more.Helpers for Colors, Network, Camera, WeakEventListener, PackageVersion, ScreenUnit and more.enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers
Type
Projects
Status
📋 Backlog