Fix test that was working locally but failing in CI due to different OS? code paths throwing different Exception Types...

Author: michael-hawker

UnitTests/UnitTests.UWP/Helpers/Test_StorageHelper.cs

@@ -73,10 +73,22 @@ public void Test_StorageHelper_LegacyDateTestFailure()
         /// </summary>
         [TestCategory("Helpers")]
         [TestMethod]
-        [ExpectedException(typeof(ArgumentException))]
         public void Test_StorageHelper_DateTestFailure()
         {
-            _localStorageHelperSystem.Save("Today", DateTime.Today);
+            Exception expectedException = null;
+
+            // We can't use standard exception checking here like Assert.Throws or ExpectedException
+            // as local and online platforms seem to throw different exception types :(
+            try
+            {
+                _localStorageHelperSystem.Save("Today", DateTime.Today);
+            }
+            catch (Exception exception)
+            {
+                expectedException = exception;
+            }
+
+            Assert.IsNotNull(expectedException, "Was expecting an Exception.");
         }
 
         [TestCategory("Helpers")]