Fixed last minute bugs...

Author: deltakosh

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/BladeControl/BladePage.xaml.cs

@@ -10,14 +10,12 @@
 // THE CODE OR THE USE OR OTHER DEALINGS IN THE CODE.
 // ******************************************************************
 
-using Windows.UI.Xaml.Controls;
-
 namespace Microsoft.Toolkit.Uwp.SampleApp.SamplePages
 {
     /// <summary>
     /// An page that shows how to use the Blade Control
     /// </summary>
-    public sealed partial class BladePage : Page
+    public sealed partial class BladePage
     {
         public BladePage()
         {

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/Facebook Service/FacebookPage.xaml

@@ -8,9 +8,6 @@
     xmlns:local="using:Microsoft.Toolkit.Uwp.SampleApp.SamplePages"
     mc:Ignorable="d">
     <Page.Resources>
-
-        <local:FacebookPhotoTemplateSelector x:Key="facebookPhotoTemplateSelector" FacebookAlbumTemplate="{StaticResource FacebookAlbumSchemaTemplate}" FacebookPhotoTemplate="{StaticResource FacebookPhotoSchemaTemplate}" />
-
         <DataTemplate x:Key="FacebookPostSchemaTemplate" x:DataType="facebook:FacebookPost">
             <Border Background="White" BorderBrush="#FFCCCCCC" BorderThickness="1" Margin="24,0,24,12">
                 <Grid>
@@ -54,6 +51,9 @@
             </Border>
         </DataTemplate>
 
+        <local:FacebookPhotoTemplateSelector x:Key="facebookPhotoTemplateSelector" 
+                                             FacebookAlbumTemplate="{StaticResource FacebookAlbumSchemaTemplate}" 
+                                             FacebookPhotoTemplate="{StaticResource FacebookPhotoSchemaTemplate}" />
     </Page.Resources>
 
     <Grid Background="{StaticResource Brush-Grey-05}" MaxWidth="800">
@@ -97,7 +97,9 @@
 
                         <StackPanel x:Name="CredentialsBox" Orientation="Vertical" Margin="24" Grid.Row="1">
                             <TextBox Header="App ID" x:Name="AppIDText" Margin="0,0,0,12"/>
-                            <HyperlinkButton Content="Show me how to get this ID" NavigateUri="https://developer.microsoft.com/en-us/windows/uwp-community-toolkit/services/facebook" Margin="0,0,0,15"></HyperlinkButton>
+                            <HyperlinkButton Content="Show me how to get this ID" 
+                                             NavigateUri="http://uwpcommunitytoolkit.readthedocs.io/en/master/services/Facebook/" 
+                                             Margin="0,0,0,15"></HyperlinkButton>
                             <StackPanel Orientation="Horizontal">
                                 <ComboBox x:Name="QueryType" Header="Type:"></ComboBox>
                                 <Button Content="Connect" x:Name="ConnectButton" Click="ConnectButton_OnClick" Margin="10,0,0,0" VerticalAlignment="Bottom"></Button>

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/GridSplitter/GridSplitter.bind

@@ -93,7 +93,6 @@
             Width="11"
             Background="{StaticResource Brush-Grey-04}"
             GripperCursor="@[GripperCursor:Enum:GripperCursorType.Default]"
-            HorizontalAlignment="@[HorizontalAlignment:Enum:HorizontalAlignment.Left]"
             Grid.Column="@[Column:Slider:1:0-2]"
             ResizeDirection="@[ResizeDirection:Enum:GridResizeDirection.Auto]"
             ResizeBehavior="@[ResizeBehavior:Enum:GridResizeBehavior.BasedOnAlignment]"

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/GridSplitter/GridSplitterPage.xaml

@@ -114,7 +114,7 @@
                 Width="11"
                 GripperCursor="{Binding GripperCursor.Value,Mode=TwoWay}"
                 Background="{StaticResource Brush-Grey-04}"
-                HorizontalAlignment="{Binding HorizontalAlignment.Value,Mode=TwoWay}"
+                HorizontalAlignment="Left"
                 Grid.Column="{Binding Column.Value}"
                 GripperForeground="White"
                 ResizeDirection="{Binding ResizeDirection.Value,Mode=TwoWay}"

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/Helpers/HelpersPage.xaml

@@ -12,8 +12,22 @@
             <TextBlock Margin="0,20,20,0">
                 We will soon provide more samples for helpers.
             </TextBlock>
-            <HyperlinkButton Content="Click here to go to helpers documentation" 
-                             NavigateUri="https://developer.microsoft.com/en-us/windows/uwp-community-toolkit/codehelpers"></HyperlinkButton>
+            <HyperlinkButton Content="Colors" 
+                             NavigateUri="http://uwpcommunitytoolkit.readthedocs.io/en/master/helpers/Colors/"/>
+            <HyperlinkButton Content="ConnectionHelper" 
+                             NavigateUri="http://uwpcommunitytoolkit.readthedocs.io/en/master/helpers/ConnectionHelper/"/>
+            <HyperlinkButton Content="Converters" 
+                             NavigateUri="http://uwpcommunitytoolkit.readthedocs.io/en/master/helpers/Converters/"/>
+            <HyperlinkButton Content="HyperlinkExtensions" 
+                             NavigateUri="http://uwpcommunitytoolkit.readthedocs.io/en/master/helpers/HyperlinkExtensions/"/>
+            <HyperlinkButton Content="StorageFileHelper" 
+                             NavigateUri="http://uwpcommunitytoolkit.readthedocs.io/en/master/helpers/StorageFileHelper/"/>
+            <HyperlinkButton Content="Streams" 
+                             NavigateUri="http://uwpcommunitytoolkit.readthedocs.io/en/master/helpers/Streams/"/>
+            <HyperlinkButton Content="VisualTreeExtensions" 
+                             NavigateUri="http://uwpcommunitytoolkit.readthedocs.io/en/master/helpers/VisualTreeExtensions/"/>
+            <HyperlinkButton Content="WeakEventListener" 
+                             NavigateUri="http://uwpcommunitytoolkit.readthedocs.io/en/master/helpers/WeakEventListener/"/>
         </StackPanel>
     </Grid>
 </Page>

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/LinkedIn Service/LinkedInPage.xaml

@@ -51,7 +51,9 @@
                         </Grid>
 
                         <StackPanel x:Name="CredentialsBox" Orientation="Vertical" Margin="24" Grid.Row="1">
-                            <HyperlinkButton Content="Show me how to get these values" NavigateUri="https://developer.microsoft.com/en-us/windows/uwp-community-toolkit/services/linkedin" Margin="0,0,0,15"/>
+                            <HyperlinkButton Content="Show me how to get these values" 
+                                             NavigateUri="http://uwpcommunitytoolkit.readthedocs.io/en/master/services/Linkedin/" 
+                                             Margin="0,0,0,15"/>
                             <TextBox Header="Client Id:" x:Name="ClientId" Margin="0,0,0,12"/>
                             <TextBox Header="Client Secret:" x:Name="ClientSecret" Margin="0,0,0,12"/>
                             <TextBox Header="Callback URI:" x:Name="CallbackUri" Margin="0,0,0,12"/>
@@ -60,7 +62,7 @@
                     </Grid>
 
                     <!-- Share area -->
-                    <Grid Grid.Row="1" x:Name="ShareBox">
+                    <Grid Grid.Row="1" x:Name="ShareBox" Visibility="Collapsed">
                         <Grid.RowDefinitions>
                             <RowDefinition Height="Auto"/>
                             <RowDefinition Height="Auto"/>

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/LinkedIn Service/LinkedInPage.xaml.cs

@@ -30,6 +30,16 @@ public LinkedInPage()
 
         private async void ConnectButton_Click(object sender, RoutedEventArgs e)
         {
+            if (!await Tools.CheckInternetConnectionAsync())
+            {
+                return;
+            }
+
+            if (string.IsNullOrEmpty(ClientId.Text) || string.IsNullOrEmpty(ClientSecret.Text) || string.IsNullOrEmpty(CallbackUri.Text))
+            {
+                return;
+            }
+
             var oAuthTokens = new LinkedInOAuthTokens
             {
                 ClientId = ClientId.Text,
@@ -47,6 +57,8 @@ private async void ConnectButton_Click(object sender, RoutedEventArgs e)
 
                 ProfileImage.DataContext = profile;
                 ProfileImage.Visibility = Visibility.Visible;
+
+                ShareBox.Visibility = Visibility.Visible;
             }
         }
 
@@ -57,6 +69,11 @@ private async void ShareButton_Click(object sender, RoutedEventArgs e)
                 return;
             }
 
+            if (string.IsNullOrEmpty(ShareText.Text))
+            {
+                return;
+            }
+
             var response = await LinkedInService.Instance.ShareActivityAsync(ShareText.Text);
 
             var message = new MessageDialog("Share sent to LinkedIn");

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/Microsoft Graph Service/MicrosoftGraphPage.xaml

@@ -79,6 +79,9 @@
                             <TextBox Header="Client Id:" 
                                      x:Name="ClientId" 
                                      Margin="0,0,0,12"/>
+                            <HyperlinkButton Content="Show me how to get this ID" 
+                                             NavigateUri="http://uwpcommunitytoolkit.readthedocs.io/en/master/services/MicrosoftGraph/" 
+                                             Margin="0,0,0,15"/>
                             <Button Content="Sign in" 
                                     x:Name="ConnectButton" 
                                     Click="ConnectButton_Click" 

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/Microsoft Graph Service/MicrosoftGraphPage.xaml.cs

@@ -45,6 +45,11 @@ private async void ConnectButton_Click(object sender, RoutedEventArgs e)
                 return;
             }
 
+            if (string.IsNullOrEmpty(ClientId.Text))
+            {
+                return;
+            }
+
             // Initialize the service
             MicrosoftGraphService.Instance.Initialize(ClientId.Text);
 

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/Object Storage/ObjectStoragePage.xaml.cs

@@ -16,8 +16,8 @@ namespace Microsoft.Toolkit.Uwp.SampleApp.SamplePages
 {
     public sealed partial class ObjectStoragePage
     {
-        private IObjectStorageHelper localStorageHelper = new LocalObjectStorageHelper();
-        private IObjectStorageHelper roamingStorageHelper = new RoamingObjectStorageHelper();
+        private readonly IObjectStorageHelper localStorageHelper = new LocalObjectStorageHelper();
+        private readonly IObjectStorageHelper roamingStorageHelper = new RoamingObjectStorageHelper();
 
         public ObjectStoragePage()
         {
@@ -26,6 +26,11 @@ public ObjectStoragePage()
 
         private void ReadButton_Click(object sender, RoutedEventArgs e)
         {
+            if (string.IsNullOrEmpty(KeyTextBox.Text))
+            {
+                return;
+            }
+
             if (StorageModeToggle.IsOn)
             {
                 // Read from roaming storage
@@ -46,6 +51,16 @@ private void ReadButton_Click(object sender, RoutedEventArgs e)
 
         private void SaveButton_Click(object sender, RoutedEventArgs e)
         {
+            if (string.IsNullOrEmpty(KeyTextBox.Text))
+            {
+                return;
+            }
+
+            if (string.IsNullOrEmpty(ContentTextBox.Text))
+            {
+                return;
+            }
+
             if (StorageModeToggle.IsOn)
             {
                 // Save into roaming storage