Remove try/catch

twsouthwick · twsouthwick · commit 2df0f18c53bd · 2017-02-04T08:03:01.000-08:00
diff --git a/Microsoft.Toolkit.Uwp.UI/AdvancedCollectionView/AdvancedCollectionView.cs b/Microsoft.Toolkit.Uwp.UI/AdvancedCollectionView/AdvancedCollectionView.cs
@@ -392,18 +392,11 @@ int IComparer<object>.Compare(object x, object y)
                     cy = pi.GetValue(y);
                 }
 
-                try
-                {
-                    var cmp = sd.Comparer.Compare(cx, cy);
+                var cmp = sd.Comparer.Compare(cx, cy);
 
-                    if (cmp != 0)
-                    {
-                        return sd.Direction == SortDirection.Ascending ? +cmp : -cmp;
-                    }
-                }
-                catch
+                if (cmp != 0)
                 {
-                    // fail silently
+                    return sd.Direction == SortDirection.Ascending ? +cmp : -cmp;
                 }
             }
 

Original file line number	Diff line number	Diff line change
`@@ -392,18 +392,11 @@ int IComparer<object>.Compare(object x, object y)`
`392`	`392`	`cy = pi.GetValue(y);`
`393`	`393`	`}`
`394`	`394`
`395`		`- try`
`396`		`- {`
`397`		`- var cmp = sd.Comparer.Compare(cx, cy);`
	`395`	`+ var cmp = sd.Comparer.Compare(cx, cy);`
`398`	`396`
`399`		`- if (cmp != 0)`
`400`		`- {`
`401`		`- return sd.Direction == SortDirection.Ascending ? +cmp : -cmp;`
`402`		`- }`
`403`		`- }`
`404`		`- catch`
	`397`	`+ if (cmp != 0)`
`405`	`398`	`{`
`406`		`- // fail silently`
	`399`	`+ return sd.Direction == SortDirection.Ascending ? +cmp : -cmp;`
`407`	`400`	`}`
`408`	`401`	`}`
`409`	`402`