Merge branch 'master' into Kyaa-UpdateIssueTemplate

Author: michael-hawker

.editorconfig

@@ -327,4 +327,4 @@ dotnet_diagnostic.SA1413.severity = none # UseTrailingCommasInMultiLineInitializ
 dotnet_diagnostic.SA1314.severity = none # TypeParameterNamesMustBeginWithT: We do have a few templates that don't start with T. We need to double check that changing this is not a breaking change. If not, we can re-enable this.
 dotnet_diagnostic.SA1000.severity = none # Hide warnings when using the new() expression from C# 9.
 dotnet_diagnostic.SA1313.severity = none # Hide warnings for record parameters.
-dotnet_diagnostic.SA1101.severity = none # Hide warnings when accessing properties without "this".
+dotnet_diagnostic.SA1101.severity = none # Hide warnings when accessing properties without "this".

GazeInputTest/GazeInputTest.csproj

@@ -150,7 +150,7 @@
   </ItemGroup>
   <ItemGroup>
     <PackageReference Include="Microsoft.NETCore.UniversalWindowsPlatform">
-      <Version>6.2.10</Version>
+      <Version>6.2.12</Version>
     </PackageReference>
     <PackageReference Include="StyleCop.Analyzers">
       <Version>1.0.2</Version>

Microsoft.Toolkit.HighPerformance/Buffers/Internals/RawObjectMemoryManager{T}.cs

@@ -9,6 +9,7 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 using Microsoft.Toolkit.HighPerformance.Extensions;
+using Microsoft.Toolkit.HighPerformance.Helpers;
 
 namespace Microsoft.Toolkit.HighPerformance.Buffers.Internals
 {
@@ -49,7 +50,7 @@ public RawObjectMemoryManager(object instance, IntPtr offset, int length)
         /// <inheritdoc/>
         public override Span<T> GetSpan()
         {
-            ref T r0 = ref this.instance.DangerousGetObjectDataReferenceAt<T>(this.offset);
+            ref T r0 = ref ObjectMarshal.DangerousGetObjectDataReferenceAt<T>(this.instance, this.offset);
 
             return MemoryMarshal.CreateSpan(ref r0, this.length);
         }
@@ -68,7 +69,7 @@ public override unsafe MemoryHandle Pin(int elementIndex = 0)
             // traditional means (eg. via the implicit T[] array conversion), if T is a
             // reference type or a type containing some references.
             GCHandle handle = GCHandle.Alloc(this.instance, GCHandleType.Pinned);
-            ref T r0 = ref this.instance.DangerousGetObjectDataReferenceAt<T>(this.offset);
+            ref T r0 = ref ObjectMarshal.DangerousGetObjectDataReferenceAt<T>(this.instance, this.offset);
             ref T r1 = ref Unsafe.Add(ref r0, (nint)(uint)elementIndex);
             void* p = Unsafe.AsPointer(ref r1);
 

Microsoft.Toolkit.HighPerformance/Buffers/MemoryOwner{T}.cs

@@ -91,7 +91,7 @@ private MemoryOwner(int start, int length, ArrayPool<T> pool, T[] array)
         public static MemoryOwner<T> Empty
         {
             [MethodImpl(MethodImplOptions.AggressiveInlining)]
-            get => new MemoryOwner<T>(0, ArrayPool<T>.Shared, AllocationMode.Default);
+            get => new(0, ArrayPool<T>.Shared, AllocationMode.Default);
         }
 
         /// <summary>
@@ -103,7 +103,7 @@ public static MemoryOwner<T> Empty
         /// <remarks>This method is just a proxy for the <see langword="private"/> constructor, for clarity.</remarks>
         [Pure]
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
-        public static MemoryOwner<T> Allocate(int size) => new MemoryOwner<T>(size, ArrayPool<T>.Shared, AllocationMode.Default);
+        public static MemoryOwner<T> Allocate(int size) => new(size, ArrayPool<T>.Shared, AllocationMode.Default);
 
         /// <summary>
         /// Creates a new <see cref="MemoryOwner{T}"/> instance with the specified parameters.
@@ -115,7 +115,7 @@ public static MemoryOwner<T> Empty
         /// <remarks>This method is just a proxy for the <see langword="private"/> constructor, for clarity.</remarks>
         [Pure]
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
-        public static MemoryOwner<T> Allocate(int size, ArrayPool<T> pool) => new MemoryOwner<T>(size, pool, AllocationMode.Default);
+        public static MemoryOwner<T> Allocate(int size, ArrayPool<T> pool) => new(size, pool, AllocationMode.Default);
 
         /// <summary>
         /// Creates a new <see cref="MemoryOwner{T}"/> instance with the specified parameters.
@@ -127,7 +127,7 @@ public static MemoryOwner<T> Empty
         /// <remarks>This method is just a proxy for the <see langword="private"/> constructor, for clarity.</remarks>
         [Pure]
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
-        public static MemoryOwner<T> Allocate(int size, AllocationMode mode) => new MemoryOwner<T>(size, ArrayPool<T>.Shared, mode);
+        public static MemoryOwner<T> Allocate(int size, AllocationMode mode) => new(size, ArrayPool<T>.Shared, mode);
 
         /// <summary>
         /// Creates a new <see cref="MemoryOwner{T}"/> instance with the specified parameters.
@@ -140,7 +140,7 @@ public static MemoryOwner<T> Empty
         /// <remarks>This method is just a proxy for the <see langword="private"/> constructor, for clarity.</remarks>
         [Pure]
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
-        public static MemoryOwner<T> Allocate(int size, ArrayPool<T> pool, AllocationMode mode) => new MemoryOwner<T>(size, pool, mode);
+        public static MemoryOwner<T> Allocate(int size, ArrayPool<T> pool, AllocationMode mode) => new(size, pool, mode);
 
         /// <summary>
         /// Gets the number of items in the current instance

Microsoft.Toolkit.HighPerformance/Buffers/SpanOwner{T}.cs

@@ -80,7 +80,7 @@ private SpanOwner(int length, ArrayPool<T> pool, AllocationMode mode)
         public static SpanOwner<T> Empty
         {
             [MethodImpl(MethodImplOptions.AggressiveInlining)]
-            get => new SpanOwner<T>(0, ArrayPool<T>.Shared, AllocationMode.Default);
+            get => new(0, ArrayPool<T>.Shared, AllocationMode.Default);
         }
 
         /// <summary>
@@ -92,7 +92,7 @@ public static SpanOwner<T> Empty
         /// <remarks>This method is just a proxy for the <see langword="private"/> constructor, for clarity.</remarks>
         [Pure]
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
-        public static SpanOwner<T> Allocate(int size) => new SpanOwner<T>(size, ArrayPool<T>.Shared, AllocationMode.Default);
+        public static SpanOwner<T> Allocate(int size) => new(size, ArrayPool<T>.Shared, AllocationMode.Default);
 
         /// <summary>
         /// Creates a new <see cref="SpanOwner{T}"/> instance with the specified parameters.
@@ -104,7 +104,7 @@ public static SpanOwner<T> Empty
         /// <remarks>This method is just a proxy for the <see langword="private"/> constructor, for clarity.</remarks>
         [Pure]
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
-        public static SpanOwner<T> Allocate(int size, ArrayPool<T> pool) => new SpanOwner<T>(size, pool, AllocationMode.Default);
+        public static SpanOwner<T> Allocate(int size, ArrayPool<T> pool) => new(size, pool, AllocationMode.Default);
 
         /// <summary>
         /// Creates a new <see cref="SpanOwner{T}"/> instance with the specified parameters.
@@ -116,7 +116,7 @@ public static SpanOwner<T> Empty
         /// <remarks>This method is just a proxy for the <see langword="private"/> constructor, for clarity.</remarks>
         [Pure]
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
-        public static SpanOwner<T> Allocate(int size, AllocationMode mode) => new SpanOwner<T>(size, ArrayPool<T>.Shared, mode);
+        public static SpanOwner<T> Allocate(int size, AllocationMode mode) => new(size, ArrayPool<T>.Shared, mode);
 
         /// <summary>
         /// Creates a new <see cref="SpanOwner{T}"/> instance with the specified parameters.
@@ -129,7 +129,7 @@ public static SpanOwner<T> Empty
         /// <remarks>This method is just a proxy for the <see langword="private"/> constructor, for clarity.</remarks>
         [Pure]
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
-        public static SpanOwner<T> Allocate(int size, ArrayPool<T> pool, AllocationMode mode) => new SpanOwner<T>(size, pool, mode);
+        public static SpanOwner<T> Allocate(int size, ArrayPool<T> pool, AllocationMode mode) => new(size, pool, mode);
 
         /// <summary>
         /// Gets the number of items in the current instance
@@ -183,7 +183,7 @@ public ref T DangerousGetReference()
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public ArraySegment<T> DangerousGetArray()
         {
-            return new ArraySegment<T>(array!, 0, this.length);
+            return new(array!, 0, this.length);
         }
 
         /// <summary>

Microsoft.Toolkit.HighPerformance/Buffers/StringPool.cs

@@ -137,7 +137,7 @@ static void FindFactors(int size, int factor, out int x, out int y)
         /// process. Since <see cref="StringPool"/> is thread-safe, the shared instance can be used
         /// concurrently by multiple threads without the need for manual synchronization.
         /// </remarks>
-        public static StringPool Shared { get; } = new StringPool();
+        public static StringPool Shared { get; } = new();
 
         /// <summary>
         /// Gets the total number of <see cref="string"/> that can be stored in the current instance.

Microsoft.Toolkit.HighPerformance/Enumerables/ReadOnlyRefEnumerable{T}.cs

@@ -10,6 +10,8 @@
 #endif
 using Microsoft.Toolkit.HighPerformance.Extensions;
 using Microsoft.Toolkit.HighPerformance.Helpers.Internals;
+using Microsoft.Toolkit.HighPerformance.Memory.Internals;
+
 #if !SPAN_RUNTIME_SUPPORT
 using RuntimeHelpers = Microsoft.Toolkit.HighPerformance.Helpers.Internals.RuntimeHelpers;
 #endif
@@ -76,6 +78,32 @@ internal ReadOnlyRefEnumerable(in T reference, int length, int step)
             this.span = MemoryMarshal.CreateReadOnlySpan(ref Unsafe.AsRef(reference), length);
             this.step = step;
         }
+
+        /// <summary>
+        /// Creates a new instance of the <see cref="ReadOnlyRefEnumerable{T}"/> struct with the specified parameters.
+        /// </summary>
+        /// <param name="value">The reference to the first <typeparamref name="T"/> item to map.</param>
+        /// <param name="length">The number of items in the sequence.</param>
+        /// <param name="step">The distance between items in the sequence to enumerate.</param>
+        /// <returns>A <see cref="ReadOnlyRefEnumerable{T}"/> instance with the specified parameters.</returns>
+        /// <exception cref="ArgumentOutOfRangeException">Thrown when one of the parameters are negative.</exception>
+        [Pure]
+        public static ReadOnlyRefEnumerable<T> DangerousCreate(in T value, int length, int step)
+        {
+            if (length < 0)
+            {
+                ThrowArgumentOutOfRangeExceptionForLength();
+            }
+
+            if (step < 0)
+            {
+                ThrowArgumentOutOfRangeExceptionForStep();
+            }
+
+            OverflowHelper.EnsureIsInNativeIntRange(length, 1, step);
+
+            return new ReadOnlyRefEnumerable<T>(in value, length, step);
+        }
 #else
         /// <summary>
         /// Initializes a new instance of the <see cref="ReadOnlyRefEnumerable{T}"/> struct.
@@ -360,6 +388,22 @@ public readonly ref readonly T Current
             }
         }
 
+        /// <summary>
+        /// Throws an <see cref="ArgumentOutOfRangeException"/> when the "length" parameter is invalid.
+        /// </summary>
+        private static void ThrowArgumentOutOfRangeExceptionForLength()
+        {
+            throw new ArgumentOutOfRangeException("length");
+        }
+
+        /// <summary>
+        /// Throws an <see cref="ArgumentOutOfRangeException"/> when the "step" parameter is invalid.
+        /// </summary>
+        private static void ThrowArgumentOutOfRangeExceptionForStep()
+        {
+            throw new ArgumentOutOfRangeException("step");
+        }
+
         /// <summary>
         /// Throws an <see cref="ArgumentException"/> when the target span is too short.
         /// </summary>

Microsoft.Toolkit.HighPerformance/Enumerables/RefEnumerable{T}.cs

@@ -10,7 +10,9 @@
 #endif
 using Microsoft.Toolkit.HighPerformance.Extensions;
 using Microsoft.Toolkit.HighPerformance.Helpers.Internals;
-#if !SPAN_RUNTIME_SUPPORT
+#if SPAN_RUNTIME_SUPPORT
+using Microsoft.Toolkit.HighPerformance.Memory.Internals;
+#else
 using RuntimeHelpers = Microsoft.Toolkit.HighPerformance.Helpers.Internals.RuntimeHelpers;
 #endif
 
@@ -64,6 +66,32 @@ internal RefEnumerable(ref T reference, int length, int step)
             Span = MemoryMarshal.CreateSpan(ref reference, length);
             Step = step;
         }
+
+        /// <summary>
+        /// Creates a new instance of the <see cref="RefEnumerable{T}"/> struct with the specified parameters.
+        /// </summary>
+        /// <param name="value">The reference to the first <typeparamref name="T"/> item to map.</param>
+        /// <param name="length">The number of items in the sequence.</param>
+        /// <param name="step">The distance between items in the sequence to enumerate.</param>
+        /// <returns>A <see cref="RefEnumerable{T}"/> instance with the specified parameters.</returns>
+        /// <exception cref="ArgumentOutOfRangeException">Thrown when one of the parameters are negative.</exception>
+        [Pure]
+        public static RefEnumerable<T> DangerousCreate(ref T value, int length, int step)
+        {
+            if (length < 0)
+            {
+                ThrowArgumentOutOfRangeExceptionForLength();
+            }
+
+            if (step < 0)
+            {
+                ThrowArgumentOutOfRangeExceptionForStep();
+            }
+
+            OverflowHelper.EnsureIsInNativeIntRange(length, 1, step);
+
+            return new RefEnumerable<T>(ref value, length, step);
+        }
 #else
         /// <summary>
         /// Initializes a new instance of the <see cref="RefEnumerable{T}"/> struct.
@@ -453,6 +481,22 @@ public readonly ref T Current
             }
         }
 
+        /// <summary>
+        /// Throws an <see cref="ArgumentOutOfRangeException"/> when the "length" parameter is invalid.
+        /// </summary>
+        private static void ThrowArgumentOutOfRangeExceptionForLength()
+        {
+            throw new ArgumentOutOfRangeException("length");
+        }
+
+        /// <summary>
+        /// Throws an <see cref="ArgumentOutOfRangeException"/> when the "step" parameter is invalid.
+        /// </summary>
+        private static void ThrowArgumentOutOfRangeExceptionForStep()
+        {
+            throw new ArgumentOutOfRangeException("step");
+        }
+
         /// <summary>
         /// Throws an <see cref="ArgumentException"/> when the target span is too short.
         /// </summary>

Microsoft.Toolkit.HighPerformance/Extensions/ArrayExtensions.1D.cs

@@ -9,6 +9,9 @@
 using System.Runtime.InteropServices;
 #endif
 using Microsoft.Toolkit.HighPerformance.Enumerables;
+#if !NETCORE_RUNTIME && !NET5_0
+using Microsoft.Toolkit.HighPerformance.Helpers;
+#endif
 using Microsoft.Toolkit.HighPerformance.Helpers.Internals;
 using RuntimeHelpers = Microsoft.Toolkit.HighPerformance.Helpers.Internals.RuntimeHelpers;
 
@@ -40,7 +43,7 @@ public static ref T DangerousGetReference<T>(this T[] array)
 #else
             IntPtr offset = RuntimeHelpers.GetArrayDataByteOffset<T>();
 
-            return ref array.DangerousGetObjectDataReferenceAt<T>(offset);
+            return ref ObjectMarshal.DangerousGetObjectDataReferenceAt<T>(array, offset);
 #endif
         }
 
@@ -69,7 +72,7 @@ public static ref T DangerousGetReferenceAt<T>(this T[] array, int i)
             return ref ri;
 #else
             IntPtr offset = RuntimeHelpers.GetArrayDataByteOffset<T>();
-            ref T r0 = ref array.DangerousGetObjectDataReferenceAt<T>(offset);
+            ref T r0 = ref ObjectMarshal.DangerousGetObjectDataReferenceAt<T>(array, offset);
             ref T ri = ref Unsafe.Add(ref r0, (nint)(uint)i);
 
             return ref ri;
@@ -146,7 +149,7 @@ public static int Count<T>(this T[] array, T value)
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public static SpanEnumerable<T> Enumerate<T>(this T[] array)
         {
-            return new SpanEnumerable<T>(array);
+            return new(array);
         }
 
         /// <summary>
@@ -172,7 +175,7 @@ public static SpanEnumerable<T> Enumerate<T>(this T[] array)
         public static SpanTokenizer<T> Tokenize<T>(this T[] array, T separator)
             where T : IEquatable<T>
         {
-            return new SpanTokenizer<T>(array, separator);
+            return new(array, separator);
         }
 
         /// <summary>