Fixed Task not completing issue

Vijay-Nirmal · Vijay-Nirmal · commit 4b70980f2d12 · 2021-07-27T22:36:40.000+05:30
diff --git a/Microsoft.Toolkit.Uwp.UI/Extensions/ListViewBase/ListViewExtensions.SmoothScrollIntoView.cs b/Microsoft.Toolkit.Uwp.UI/Extensions/ListViewBase/ListViewExtensions.SmoothScrollIntoView.cs
@@ -201,6 +201,9 @@ public static async Task SmoothScrollIntoViewWithItemAsync(this ListViewBase lis
         /// <param name="disableAnimation">if set to <c>true</c> disable animation.</param>
         private static async Task ChangeViewAsync(this ScrollViewer scrollViewer, double? horizontalOffset, double? verticalOffset, float? zoomFactor, bool disableAnimation)
         {
+            horizontalOffset = horizontalOffset > scrollViewer.ScrollableWidth ? scrollViewer.ScrollableWidth : horizontalOffset;
+            verticalOffset = verticalOffset > scrollViewer.ScrollableHeight ? scrollViewer.ScrollableHeight : verticalOffset;
+
             // MUST check this and return immediately, otherwise this async task will never complete because ViewChanged event won't get triggered
             if (horizontalOffset == scrollViewer.HorizontalOffset && verticalOffset == scrollViewer.VerticalOffset)
             {

Original file line number	Diff line number	Diff line change
`@@ -201,6 +201,9 @@ public static async Task SmoothScrollIntoViewWithItemAsync(this ListViewBase lis`
`201`	`201`	`/// <param name="disableAnimation">if set to <c>true</c> disable animation.</param>`
`202`	`202`	`private static async Task ChangeViewAsync(this ScrollViewer scrollViewer, double? horizontalOffset, double? verticalOffset, float? zoomFactor, bool disableAnimation)`
`203`	`203`	`{`
	`204`	`+ horizontalOffset = horizontalOffset > scrollViewer.ScrollableWidth ? scrollViewer.ScrollableWidth : horizontalOffset;`
	`205`	`+ verticalOffset = verticalOffset > scrollViewer.ScrollableHeight ? scrollViewer.ScrollableHeight : verticalOffset;`
	`206`	`+`
`204`	`207`	`// MUST check this and return immediately, otherwise this async task will never complete because ViewChanged event won't get triggered`
`205`	`208`	`if (horizontalOffset == scrollViewer.HorizontalOffset && verticalOffset == scrollViewer.VerticalOffset)`
`206`	`209`	`{`