Merge branch 'master' into dev/7.0.0

Author: azchohfi

azure-pipelines.yml

@@ -52,8 +52,14 @@ steps:
 #- powershell: .\build\Install-WindowsSdkISO.ps1 18362
 #  displayName: Insider SDK
 
-- powershell: .\build\build.ps1 -target=Default
-  displayName: Build 
+- powershell: .\build\build.ps1 -target=Build
+  displayName: Build
+
+- powershell: .\build\build.ps1 -target=Test
+  displayName: Test
+
+- powershell: .\build\build.ps1 -target=Package
+  displayName: Package
 
 - task: PublishTestResults@2
   inputs:

build/build.cake

@@ -94,6 +94,14 @@ void VerifyHeaders(bool Replace)
     }
 }
 
+void RetrieveVersion()
+{
+	Information("\nRetrieving version...");
+    var results = StartPowershellFile(versionClient);
+    Version = results[1].Properties["NuGetPackageVersion"].Value.ToString();
+    Information("\nBuild Version: " + Version);
+}
+
 //////////////////////////////////////////////////////////////////////
 // DEFAULT TASK
 //////////////////////////////////////////////////////////////////////
@@ -137,14 +145,11 @@ Task("Version")
 
     NuGetInstall(new []{"nerdbank.gitversioning"}, installSettings);
 
-    Information("\nRetrieving version...");
-    var results = StartPowershellFile(versionClient);
-    Version = results[1].Properties["NuGetPackageVersion"].Value.ToString();
-    Information("\nBuild Version: " + Version);
+	RetrieveVersion();
 });
 
-Task("Build")
-    .Description("Build all projects and get the assemblies")
+Task("BuildProjects")
+    .Description("Build all projects")
     .IsDependentOn("Version")
     .Does(() =>
 {
@@ -173,9 +178,9 @@ Task("Build")
 });
 
 Task("InheritDoc")
-	.Description("Updates <inheritdoc /> tags from base classes, interfaces, and similar methods")
-	.IsDependentOn("Build")
-	.Does(() =>
+    .Description("Updates <inheritdoc /> tags from base classes, interfaces, and similar methods")
+    .IsDependentOn("BuildProjects")
+    .Does(() =>
 {
 	Information("\nDownloading InheritDoc...");
 	var installSettings = new NuGetInstallSettings {
@@ -201,9 +206,13 @@ Task("InheritDoc")
     Information("\nFinished generating documentation with InheritDoc");
 });
 
+Task("Build")
+    .Description("Build all projects runs InheritDoc")
+    .IsDependentOn("BuildProjects")
+    .IsDependentOn("InheritDoc");
+
 Task("Package")
 	.Description("Pack the NuPkg")
-	.IsDependentOn("InheritDoc")
 	.Does(() =>
 {
 	// Invoke the pack target in the end
@@ -236,12 +245,14 @@ Task("Package")
     buildSettings.SetPlatformTarget(PlatformTarget.x86);
     MSBuild(Solution, buildSettings);
 
+    RetrieveVersion();
+
     var nuGetPackSettings = new NuGetPackSettings
 	{
 		OutputDirectory = nupkgDir,
         Version = Version
 	};
-
+	
     var nuspecs = GetFiles("./*.nuspec");
     foreach (var nuspec in nuspecs)
     {
@@ -264,7 +275,6 @@ public string getMSTestAdapterPath(){
 
 Task("Test")
 	.Description("Runs all Tests")
-	.IsDependentOn("Build")
     .Does(() =>
 {
 	var vswhere = VSWhereLatest(new VSWhereLatestSettings
@@ -300,7 +310,8 @@ Task("Test")
 //////////////////////////////////////////////////////////////////////
 
 Task("Default")
-	.IsDependentOn("Test")
+    .IsDependentOn("Build")
+    .IsDependentOn("Test")
     .IsDependentOn("Package");
 
 Task("UpdateHeaders")

contributing.md

@@ -36,12 +36,11 @@ For every contribution, you must:
 * target master branch (or an appropriate release branch if appropriate for a bug fix)
 
 * If adding a new feature
-    * Before starting coding, **you should open an uservoice entry** under "Windows Community Toolkit" on [Uservoice](https://wpdev.uservoice.com/forums/110705-universal-windows-platform/category/193402-uwp-community-toolkit) and start discussing with the community to see if your idea/feature is interesting enough.
+    * Before starting coding, **you should open an [issue](https://github.com/windows-toolkit/WindowsCommunityToolkit/issues/new?assignees=&labels=feature+request+%3Amailbox_with_mail%3A&template=feature_request.md&title=%5BFeature%5D)** and start discussing with the community to see if your idea/feature is interesting enough.
     * Add or update a sample for the [Sample app](https://github.com/windows-toolkit/WindowsCommunityToolkit/tree/master/Microsoft.Toolkit.Uwp.SampleApp)
         * If creating a new sample, create a new icon by following the [Thumbnail Style Guide and templates](https://github.com/Microsoft/UWPCommunityToolkit-design-assets)
     * Add or update unit tests (if applicable)
 
-
 PR has to be validated by at least two core members before being merged.
 
 Once merged, you can get a pre-release package of the toolkit by adding this ([Nuget repo](https://dotnet.myget.org/F/uwpcommunitytoolkit/api/v3/index.json) | [Gallery](https://dotnet.myget.org/gallery/uwpcommunitytoolkit)) to your Visual Studio.