Skip to content

Commit 513f9de

Browse files
committed
Remove redundant empty Pack target
- Remove the empty Pack target from all project files. - Put the empty Pack target in `Directory.Build.targets`.
1 parent 6ffb05a commit 513f9de

File tree

12 files changed

+6
-22
lines changed

12 files changed

+6
-22
lines changed

Directory.Build.targets

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,4 +31,10 @@
3131
</ItemGroup>
3232
</Target>
3333

34+
<!--
35+
Define an empty Pack target to avoid error when packing solution from command-line.
36+
This gets overridden by the actual Pack target imported by the .NET SDK.
37+
-->
38+
<Target Name="Pack" />
39+
3440
</Project>

GazeInputTest/GazeInputTest.csproj

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,4 @@
155155
<VisualStudioVersion>14.0</VisualStudioVersion>
156156
</PropertyGroup>
157157
<Import Project="$(MSBuildExtensionsPath)\Microsoft\WindowsXaml\v$(VisualStudioVersion)\Microsoft.Windows.UI.Xaml.CSharp.targets" />
158-
<!-- No-op to avoid build error when packing solution from commandline -->
159-
<Target Name="Pack" />
160158
</Project>

Microsoft.Toolkit.Uwp.SampleApp/Microsoft.Toolkit.Uwp.SampleApp.csproj

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1562,6 +1562,4 @@
15621562
</AppxPackagePayload>
15631563
</ItemGroup>
15641564
</Target>
1565-
<!-- No-op to avoid build error when packing solution from commandline -->
1566-
<Target Name="Pack" />
15671565
</Project>

Microsoft.Toolkit.Uwp.Samples.BackgroundTasks/Microsoft.Toolkit.Uwp.Samples.BackgroundTasks.csproj

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,4 @@
137137
<ErrorReport>prompt</ErrorReport>
138138
</PropertyGroup>
139139
<Import Project="$(MSBuildExtensionsPath)\Microsoft\WindowsXaml\v$(VisualStudioVersion)\Microsoft.Windows.UI.Xaml.CSharp.targets" />
140-
<!-- No-op to avoid build error when packing solution from commandline -->
141-
<Target Name="Pack" />
142140
</Project>

Microsoft.Toolkit.Win32.WpfCore.SampleApp.PackagingProject/Microsoft.Toolkit.Win32.WpfCore.SampleApp.PackagingProject.wapproj

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,4 @@
7676
</ProjectReference>
7777
</ItemGroup>
7878
<Import Project="$(WapProjPath)\Microsoft.DesktopBridge.targets" />
79-
<!-- No-op to avoid build error when packing solution from commandline -->
80-
<Target Name="Pack" />
8179
</Project>

SmokeTests/SmokeTest.csproj

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,4 @@
129129
<Error Condition="'@(NuGetPackageFiltered)' == '' and $(CurrentProject) != 'UWPBaseline' and '$(CurrentProject)' != 'UWPBaselineWinUI'" Text="NuGet '$(CurrentProject).[SEMVER].nupkg' doesn't exist!" />
130130
<Error Condition="'$(CurrentProject)' != 'UWPBaseline' and '$(CurrentProject)' != 'UWPBaselineWinUI' and '$(NuGetPackageVersion)' == 'To Fill In With Local Version Number'" Text="Please set 'NuGetPackageVersion' at the top of 'SmokeTest.csproj' with the version to smoke test locally." />
131131
</Target>
132-
<!-- No-op to avoid build error when packing solution from commandline -->
133-
<Target Name="Pack" />
134132
</Project>

UITests/UITests.App/UITests.App.csproj

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -250,6 +250,4 @@
250250
</PropertyGroup>
251251
<Import Project="$(MSBuildExtensionsPath)\Microsoft\WindowsXaml\v$(VisualStudioVersion)\Microsoft.Windows.UI.Xaml.CSharp.targets" />
252252
<Import Project="..\UITests.Tests.Shared\UITests.Tests.Shared.projitems" Label="Shared" />
253-
<!-- No-op to avoid build error when packing solution from commandline -->
254-
<Target Name="Pack" />
255253
</Project>

UnitTests/UnitTests.Notifications.UWP/UnitTests.Notifications.UWP.csproj

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,4 @@
171171
<VisualStudioVersion>14.0</VisualStudioVersion>
172172
</PropertyGroup>
173173
<Import Project="$(MSBuildExtensionsPath)\Microsoft\WindowsXaml\v$(VisualStudioVersion)\Microsoft.Windows.UI.Xaml.CSharp.targets" />
174-
<!-- No-op to avoid build error when packing solution from commandline -->
175-
<Target Name="Pack" />
176174
</Project>

UnitTests/UnitTests.Notifications.WinRT/UnitTests.Notifications.WinRT.csproj

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,4 @@
169169
</Reference>
170170
</ItemGroup>
171171
<Import Project="$(MSBuildExtensionsPath)\Microsoft\WindowsXaml\v$(VisualStudioVersion)\Microsoft.Windows.UI.Xaml.CSharp.targets" />
172-
<!-- No-op to avoid build error when packing solution from commandline -->
173-
<Target Name="Pack" />
174172
</Project>

UnitTests/UnitTests.UWP/UnitTests.UWP.csproj

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -538,6 +538,4 @@
538538
<Prefer32Bit>true</Prefer32Bit>
539539
</PropertyGroup>
540540
<Import Project="$(MSBuildExtensionsPath)\Microsoft\WindowsXaml\v$(VisualStudioVersion)\Microsoft.Windows.UI.Xaml.CSharp.targets" />
541-
<!-- No-op to avoid build error when packing solution from commandline -->
542-
<Target Name="Pack" />
543541
</Project>

0 commit comments

Comments
 (0)