Fixed FormatException when ColorHelper in non-US

Author: Sergio0694

Microsoft.Toolkit.Uwp/Helpers/ColorHelper.cs

@@ -3,7 +3,9 @@
 // See the LICENSE file in the project root for more information.
 
 using System;
+using System.Globalization;
 using System.Reflection;
+using Microsoft.Toolkit.Diagnostics;
 using Windows.UI;
 using Color = Windows.UI.Color;
 
@@ -22,10 +24,7 @@ public static class ColorHelper
         /// <returns>The created <see cref="Color"/>.</returns>
         public static Color ToColor(this string colorString)
         {
-            if (string.IsNullOrEmpty(colorString))
-            {
-                throw new ArgumentException(nameof(colorString));
-            }
+            Guard.IsNotNullOrEmpty(colorString, nameof(colorString));
 
             if (colorString[0] == '#')
             {
@@ -80,8 +79,7 @@ public static Color ToColor(this string colorString)
                             return Color.FromArgb(255, r, g, b);
                         }
 
-                    default:
-                        throw new FormatException(string.Format("The {0} string passed in the colorString argument is not a recognized Color format.", colorString));
+                    default: return ThrowHelper.ThrowFormatException<Color>("The string passed in the colorString argument is not a recognized Color format.");
                 }
             }
 
@@ -91,24 +89,24 @@ public static Color ToColor(this string colorString)
 
                 if (values.Length == 4)
                 {
-                    var scA = double.Parse(values[0].Substring(3));
-                    var scR = double.Parse(values[1]);
-                    var scG = double.Parse(values[2]);
-                    var scB = double.Parse(values[3]);
+                    var scA = double.Parse(values[0].Substring(3), CultureInfo.InvariantCulture);
+                    var scR = double.Parse(values[1], CultureInfo.InvariantCulture);
+                    var scG = double.Parse(values[2], CultureInfo.InvariantCulture);
+                    var scB = double.Parse(values[3], CultureInfo.InvariantCulture);
 
                     return Color.FromArgb((byte)(scA * 255), (byte)(scR * 255), (byte)(scG * 255), (byte)(scB * 255));
                 }
 
                 if (values.Length == 3)
                 {
-                    var scR = double.Parse(values[0].Substring(3));
-                    var scG = double.Parse(values[1]);
-                    var scB = double.Parse(values[2]);
+                    var scR = double.Parse(values[0].Substring(3), CultureInfo.InvariantCulture);
+                    var scG = double.Parse(values[1], CultureInfo.InvariantCulture);
+                    var scB = double.Parse(values[2], CultureInfo.InvariantCulture);
 
                     return Color.FromArgb(255, (byte)(scR * 255), (byte)(scG * 255), (byte)(scB * 255));
                 }
 
-                throw new FormatException(string.Format("The {0} string passed in the colorString argument is not a recognized Color format (sc#[scA,]scR,scG,scB).", colorString));
+                return ThrowHelper.ThrowFormatException<Color>("The string passed in the colorString argument is not a recognized Color format (sc#[scA,]scR,scG,scB).");
             }
 
             var prop = typeof(Colors).GetTypeInfo().GetDeclaredProperty(colorString);
@@ -118,7 +116,7 @@ public static Color ToColor(this string colorString)
                 return (Color)prop.GetValue(null);
             }
 
-            throw new FormatException(string.Format("The {0} string passed in the colorString argument is not a recognized Color.", colorString));
+            return ThrowHelper.ThrowFormatException<Color>("The string passed in the colorString argument is not a recognized Color.");
         }
 
         /// <summary>