Skip to content

Commit 7182a2b

Browse files
committed
Fixing small UI issues and typos
1 parent ffaf616 commit 7182a2b

File tree

16 files changed

+49
-48
lines changed

16 files changed

+49
-48
lines changed

Microsoft.Toolkit.Uwp.SampleApp/Models/Sample.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -227,6 +227,7 @@ public async Task PreparePropertyDescriptorAsync()
227227
catch (Exception ex)
228228
{
229229
Debug.WriteLine($"Unable to extract slider info from {value}({ex.Message})");
230+
TrackingManager.TrackException(ex);
230231
continue;
231232
}
232233

@@ -243,6 +244,7 @@ public async Task PreparePropertyDescriptorAsync()
243244
catch (Exception ex)
244245
{
245246
Debug.WriteLine($"Unable to parse enum from {value}({ex.Message})");
247+
TrackingManager.TrackException(ex);
246248
continue;
247249
}
248250

@@ -267,6 +269,7 @@ public async Task PreparePropertyDescriptorAsync()
267269
catch (Exception ex)
268270
{
269271
Debug.WriteLine($"Unable to parse bool from {value}({ex.Message})");
272+
TrackingManager.TrackException(ex);
270273
continue;
271274
}
272275

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/Analytics/AnalyticsPage.xaml.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,13 +48,15 @@ protected override async void OnNavigatedTo(NavigationEventArgs e)
4848
catch (Exception exception)
4949
{
5050
MarkdownTextBlockTextblock.Text = "Unable to download content: " + exception.Message;
51+
TrackingManager.TrackException(exception);
5152
}
5253

5354
Shell.Current.DisplayWaitRing = false;
5455
}
5556

5657
private async void MarkdownTextBlockTextblock_OnLinkClicked(object sender, LinkClickedEventArgs e)
5758
{
59+
TrackingManager.TrackEvent("Link", e.Link);
5860
await Launcher.LaunchUriAsync(new Uri(e.Link));
5961
}
6062
}

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/MasterDetailsView/MasterDetailsViewCode.bind

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,15 @@
11
// Example of POCO to use with MasterDetailsView
22

3-
Emails = new List<Email>
3+
public class Email
4+
{
5+
public string From { get; set; }
6+
7+
public string Subject { get; set; }
8+
9+
public string Body { get; set; }
10+
}
11+
12+
var Emails = new List<Email>
413
{
514
new Email { From = "Steve Johnson", Subject = "Lunch Tomorrow", Body = "Are you available for lunch tomorrow? A client would like to discuss a project with you." },
615
new Email { From = "Becky Davidson", Subject = "Kids game", Body = "Don't forget the kids have their soccer game this Friday. We have to supply end of game snacks." },

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/OneDrive Service/OneDriveCode.bind

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
// OneDrive For Business you need to register your app from the Azure Management Portal
1919
// For more information to manualy register your app see go to the following article
20-
// https://docs.microsoft.com/fr-fr/azure/active-directory/develop/active-directory-authentication-scenarios#basics-of-registering-an-application-in-azure-ad
20+
// https://docs.microsoft.com/en-US/azure/active-directory/develop/active-directory-authentication-scenarios#basics-of-registering-an-application-in-azure-ad
2121
// When registering your application don't forget to add the Office 365 Sharepoint Online application with the "Read and Write user Files" permissions
2222

2323
// First get the root of your OneDrive

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/OneDrive Service/OneDrivePage.xaml.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ private async Task SigninAsync(int indexProvider, string appClientId)
7878
catch (Exception ex)
7979
{
8080
await OneDriveSampleHelpers.DisplayMessageAsync(ex.Message);
81+
TrackingManager.TrackException(ex);
8182
}
8283
finally
8384
{

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/OneDrive Service/OneDriveSampleHelpers.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,7 @@ public static async Task DownloadAsync(OneDriveStorageItem item)
140140
catch (Exception ex)
141141
{
142142
await OneDriveSampleHelpers.DisplayMessageAsync(ex.Message);
143+
TrackingManager.TrackException(ex);
143144
}
144145
finally
145146
{
@@ -200,6 +201,7 @@ public static async Task UploadSimpleFileAsync(OneDriveStorageFolder folder)
200201
catch (Exception ex)
201202
{
202203
await OneDriveSampleHelpers.DisplayMessageAsync(ex.Message);
204+
TrackingManager.TrackException(ex);
203205
}
204206
finally
205207
{
@@ -242,6 +244,7 @@ public static async Task UploadLargeFileAsync(OneDriveStorageFolder folder)
242244
catch (Exception ex)
243245
{
244246
await OneDriveSampleHelpers.DisplayMessageAsync(ex.Message);
247+
TrackingManager.TrackException(ex);
245248
}
246249
finally
247250
{
@@ -267,6 +270,7 @@ public static async Task RenameAsync(OneDriveStorageItem itemToRename)
267270
catch (Exception ex)
268271
{
269272
await OneDriveSampleHelpers.DisplayMessageAsync(ex.Message);
273+
TrackingManager.TrackException(ex);
270274
}
271275
finally
272276
{
@@ -292,6 +296,7 @@ public static async Task CopyToAsync(OneDriveStorageItem item, OneDriveStorageFo
292296
catch (Exception ex)
293297
{
294298
await OneDriveSampleHelpers.DisplayMessageAsync(ex.Message);
299+
TrackingManager.TrackException(ex);
295300
}
296301
finally
297302
{
@@ -317,6 +322,7 @@ public static async Task MoveToAsync(OneDriveStorageItem item, OneDriveStorageFo
317322
catch (Exception ex)
318323
{
319324
await OneDriveSampleHelpers.DisplayMessageAsync(ex.Message);
325+
TrackingManager.TrackException(ex);
320326
}
321327
finally
322328
{

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/ParallaxService/ParallaxPage.bind

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,6 @@
88
mc:Ignorable="d">
99

1010
<Grid Background="{StaticResource Brush-Grey-05}">
11-
<Grid.ColumnDefinitions>
12-
<ColumnDefinition/>
13-
<ColumnDefinition/>
14-
</Grid.ColumnDefinitions>
1511
<ScrollViewer>
1612
<StackPanel>
1713
<Image Source="ms-appx:///Assets/Photos/BigFourSummerHeat.png"
@@ -28,23 +24,6 @@ Nam eu lobortis velit, ac lobortis nibh. Mauris facilisis urna mi, id iaculis le
2824
</TextBlock>
2925
</Border>
3026
</StackPanel>
31-
</ScrollViewer>
32-
<ScrollViewer Grid.Column="1"
33-
HorizontalScrollBarVisibility="Auto"
34-
HorizontalScrollMode="Enabled"
35-
VerticalScrollBarVisibility="Hidden"
36-
VerticalScrollMode="Disabled">
37-
<Grid>
38-
<Image Source="ms-appx:///Assets/Photos/BigFourSummerHeat.png"
39-
Stretch="UniformToFill"
40-
an:HorizontalMultiplier="@[HorizontalMultiplier:Slider:-.7:-1-1-.1]"/>
41-
<StackPanel Orientation="Horizontal">
42-
<Rectangle Fill="Black" Opacity=".6" Width="200" Margin="12,24"/>
43-
<Rectangle Fill="Black" Opacity=".6" Width="200" Margin="12,24"/>
44-
<Rectangle Fill="Black" Opacity=".6" Width="200" Margin="12,24"/>
45-
<Rectangle Fill="Black" Opacity=".6" Width="200" Margin="12,24"/>
46-
</StackPanel>
47-
</Grid>
4827
</ScrollViewer>
4928
</Grid>
5029
</Page>

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/ParallaxService/ParallaxPage.xaml

Lines changed: 1 addition & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -8,18 +8,14 @@
88
mc:Ignorable="d">
99

1010
<Grid Background="{StaticResource Brush-Grey-05}">
11-
<Grid.ColumnDefinitions>
12-
<ColumnDefinition/>
13-
<ColumnDefinition/>
14-
</Grid.ColumnDefinitions>
1511
<ScrollViewer>
1612
<StackPanel>
1713
<Image Source="ms-appx:///Assets/Photos/BigFourSummerHeat.png"
1814
MaxHeight="500"
1915
Stretch="UniformToFill"
2016
an:ParallaxService.VerticalMultiplier="{Binding VerticalMultiplier.Value}"/>
2117
<Border Background="{StaticResource Brush-Grey-05}">
22-
<TextBlock TextWrapping="WrapWholeWords" FontSize="20">
18+
<TextBlock TextWrapping="WrapWholeWords" FontSize="20" Margin="10">
2319
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nunc fringilla ultrices est eu ornare. Suspendisse purus massa, iaculis in finibus dictum, gravida vel purus. Class aptent taciti sociosqu ad litora torquent per conubia nostra, per inceptos himenaeos. Donec vitae dolor imperdiet, vehicula enim quis, mollis tellus. Donec placerat diam sed est porttitor, venenatis semper mauris tempus. Sed placerat ipsum enim, quis porta nibh accumsan sit amet. Etiam tempus dapibus dolor, eget sollicitudin risus cursus eget. Vestibulum non rhoncus velit. Vestibulum volutpat, lacus quis laoreet accumsan, erat diam dignissim ligula, sit amet molestie purus erat eget tortor. Vestibulum posuere consequat libero, at fermentum tellus tempus eget. Curabitur viverra nisl a augue porta luctus.
2420
Duis sodales metus et purus finibus, at tincidunt felis porta. Fusce elementum ut diam ut sodales. Nunc eget varius lectus. Fusce nec rhoncus arcu. Nunc feugiat, nulla non luctus dapibus, justo odio tincidunt libero, mattis commodo sem nulla sed tellus. Aliquam ut condimentum est, id euismod turpis. Donec nec orci nulla. Suspendisse faucibus mollis sapien, ac congue nulla aliquet vel. In hac habitasse platea dictumst. Duis dapibus sem a ullamcorper vestibulum.
2521
Aliquam varius imperdiet tortor vitae elementum. Curabitur eget diam a neque blandit egestas. Pellentesque habitant morbi tristique senectus et netus et malesuada fames ac turpis egestas. Phasellus pulvinar laoreet ipsum ut scelerisque. Praesent eget molestie sem. Sed pretium suscipit orci, mollis interdum purus vestibulum vitae. Curabitur accumsan nec enim eu imperdiet. Fusce nec lectus mollis, laoreet odio vel, rhoncus nisi. Nulla mi neque, imperdiet nec diam et, tincidunt blandit metus. Quisque bibendum nisl a orci efficitur, sit amet volutpat nisi convallis. Sed lobortis ac lacus et volutpat. Nullam sodales porta nibh, eget semper augue fermentum sit amet. Phasellus sed nibh volutpat, fringilla ligula ut, lacinia dolor.
@@ -31,22 +27,5 @@ Nam eu lobortis velit, ac lobortis nibh. Mauris facilisis urna mi, id iaculis le
3127
</Border>
3228
</StackPanel>
3329
</ScrollViewer>
34-
<ScrollViewer Grid.Column="1"
35-
HorizontalScrollBarVisibility="Auto"
36-
HorizontalScrollMode="Enabled"
37-
VerticalScrollBarVisibility="Hidden"
38-
VerticalScrollMode="Disabled">
39-
<Grid>
40-
<Image Source="ms-appx:///Assets/Photos/BigFourSummerHeat.png"
41-
Stretch="UniformToFill"
42-
an:ParallaxService.HorizontalMultiplier="{Binding HorizontalMultiplier.Value}"/>
43-
<StackPanel Orientation="Horizontal">
44-
<Rectangle Fill="Black" Opacity=".6" Width="200" Margin="12,24"/>
45-
<Rectangle Fill="Black" Opacity=".6" Width="200" Margin="12,24"/>
46-
<Rectangle Fill="Black" Opacity=".6" Width="200" Margin="12,24"/>
47-
<Rectangle Fill="Black" Opacity=".6" Width="200" Margin="12,24"/>
48-
</StackPanel>
49-
</Grid>
50-
</ScrollViewer>
5130
</Grid>
5231
</Page>

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/Twitter Service/TwitterPage.xaml.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,7 @@ private async void GetLocation_OnClick(object sender, RoutedEventArgs e)
108108
catch (Exception ex)
109109
{
110110
await new MessageDialog($"An error occured finding your location. Message: {ex.Message}").ShowAsync();
111+
TrackingManager.TrackException(ex);
111112
}
112113
}
113114

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/Useful links/UsefulLinksPage.xaml.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,13 +45,15 @@ protected override async void OnNavigatedTo(NavigationEventArgs e)
4545
catch (Exception exception)
4646
{
4747
MarkdownTextBlockTextblock.Text = "Unable to download content: " + exception.Message;
48+
TrackingManager.TrackException(exception);
4849
}
4950

5051
Shell.Current.DisplayWaitRing = false;
5152
}
5253

5354
private async void MarkdownTextBlockTextblock_OnLinkClicked(object sender, LinkClickedEventArgs e)
5455
{
56+
TrackingManager.TrackEvent("Link", e.Link);
5557
await Launcher.LaunchUriAsync(new Uri(e.Link));
5658
}
5759
}

0 commit comments

Comments
 (0)